A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix: remove Content-Length from virtual file StreamingResponse (#8928)
Myles Scolnick39ce91b6befc
diff --git a/marimo/_server/api/endpoints/assets.py b/marimo/_server/api/endpoints/assets.pyindex 7a93888e9e..c94ed8d18f 100644--- a/marimo/_server/api/endpoints/assets.py+++ b/marimo/_server/api/endpoints/assets.py@@ -426,12 +426,15 @@ def virtual_file(chunks = read_virtual_file_chunked(filename, int(byte_length))mimetype, _ = mimetypes.guess_type(filename)+ # Do NOT set Content-Length here. StreamingResponse with an explicit+ # Content-Length causes h11 LocalProtocolError ("Too little data for+ # declared Content-Length") for large files. Omitting it lets h11 use+ # chunked transfer encoding instead. See #8917.return StreamingResponse(content=chunks,media_type=mimetype,headers={"Cache-Control": "max-age=86400",- "Content-Length": byte_length,},)diff --git a/tests/_server/api/endpoints/test_assets.py b/tests/_server/api/endpoints/test_assets.pyindex 3c16e0adac..336731deb8 100644--- a/tests/_server/api/endpoints/test_assets.py+++ b/tests/_server/api/endpoints/test_assets.py@@ -133,6 +133,46 @@ def test_vfile(client: TestClient) -> None:assert response.json() == {"detail": "Invalid virtual file request"}+def test_vfile_large_streaming(client: TestClient) -> None:+ """Regression test: large virtual files must stream without+ Content-Length mismatch (h11 LocalProtocolError).++ See https://github.com/marimo-team/marimo/issues/8917+ """+ from marimo._runtime.virtual_file.storage import (+ InMemoryStorage,+ VirtualFileStorageManager,+ )++ manager = VirtualFileStorageManager()+ original_storage = manager.storage+ storage = InMemoryStorage()+ manager.storage = storage++ try:+ # ~2 MB file, similar to a large anywidget ESM bundle+ data = b"x" * (2 * 1024 * 1024)+ filename = "test-large.js"+ storage.store(filename, data)+ byte_length = len(data)++ response = client.get(+ f"/@file/{byte_length}-{filename}",+ headers=token_header(),+ )+ assert response.status_code == 200+ assert response.content == data+ assert (+ response.headers.get("content-type") == "text/javascript"+ or response.headers.get("content-type") == "application/javascript"+ )+ # StreamingResponse must NOT set Content-Length to avoid h11+ # LocalProtocolError with large files+ assert "content-length" not in response.headers+ finally:+ manager.storage = original_storage++def test_public_file_serving(client: TestClient) -> None:# Setup app state with a mock notebookapp_state = AppState.from_app(cast(Any, client.app))