Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix: handle gallery crash on file deletion (#8459)

Péter Gyarmati3b349aceb1e7
diff --git a/marimo/_server/api/endpoints/home.py b/marimo/_server/api/endpoints/home.py
index 27e8c40cd1..3ddf6c5377 100644
--- a/marimo/_server/api/endpoints/home.py
+++ b/marimo/_server/api/endpoints/home.py
@@ -32,6 +32,7 @@ from marimo._server.models.home import (
from marimo._server.router import APIRouter
from marimo._session.model import ConnectionState, SessionMode
from marimo._tutorials import create_temp_tutorial_file # type: ignore
+from marimo._utils.http import HTTPException, HTTPStatus
from marimo._utils.paths import pretty_path
if TYPE_CHECKING:
@@ -111,9 +112,16 @@ async def workspace_files(
]
result: list[FileInfo] = []
for file in marimo_files:
- resolved_path = session_manager.file_router.resolve_file_path(
- file.path
- )
+ try:
+ resolved_path = (
+ session_manager.file_router.resolve_file_path(
+ file.path
+ )
+ )
+ except HTTPException as e:
+ if e.status_code == HTTPStatus.NOT_FOUND:
+ continue
+ raise
opengraph = None
if resolved_path is not None:
# User-defined OpenGraph generators receive this context for dynamic metadata
diff --git a/tests/_server/api/endpoints/test_home.py b/tests/_server/api/endpoints/test_home.py
index 48a3fde24e..ae40377916 100644
--- a/tests/_server/api/endpoints/test_home.py
+++ b/tests/_server/api/endpoints/test_home.py
@@ -206,6 +206,54 @@ def test_workspace_files_run_mode_allowlist(client: TestClient) -> None:
}
+@with_session(SESSION_ID)
+def test_workspace_files_run_mode_allowlist_skips_deleted_file(
+ client: TestClient,
+) -> None:
+ session_manager = get_session_manager(client)
+ session_manager.mode = SessionMode.RUN
+
+ with tempfile.TemporaryDirectory() as temp_dir:
+ file_one = Path(temp_dir) / "one.py"
+ file_one.write_text("import marimo\napp = marimo.App()")
+ file_two = Path(temp_dir) / "two.py"
+ file_two.write_text("import marimo\napp = marimo.App()")
+
+ marimo_files = [
+ MarimoFile(
+ name=file_one.name,
+ path=str(file_one),
+ last_modified=file_one.stat().st_mtime,
+ ),
+ MarimoFile(
+ name=file_two.name,
+ path=str(file_two),
+ last_modified=file_two.stat().st_mtime,
+ ),
+ ]
+ session_manager.file_router = AppFileRouter.from_files(
+ marimo_files,
+ directory=temp_dir,
+ allow_single_file_key=False,
+ )
+
+ file_two.unlink()
+
+ response = client.post(
+ "/api/home/workspace_files",
+ headers=HEADERS,
+ json={"include_markdown": False},
+ )
+ body = response.json()
+ files = body["files"]
+
+ assert response.status_code == 200
+ assert body["root"] == temp_dir
+ assert body["fileCount"] == 1
+ assert body["hasMore"] is False
+ assert [file["path"] for file in files] == [str(file_one)]
+
+
@with_session(SESSION_ID)
def test_thumbnail_redirects_for_https_opengraph_image(
client: TestClient,