Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

bug: Fix external go to definition (#10099)

Yair Chuchem452cb646da09
diff --git a/frontend/src/core/codemirror/__tests__/setup.test.ts b/frontend/src/core/codemirror/__tests__/setup.test.ts
index 91e68191fb..6563144d68 100644
--- a/frontend/src/core/codemirror/__tests__/setup.test.ts
+++ b/frontend/src/core/codemirror/__tests__/setup.test.ts
@@ -1,7 +1,7 @@
/* Copyright 2026 Marimo. All rights reserved. */
import { EditorState, type Extension } from "@codemirror/state";
-import { keymap } from "@codemirror/view";
+import { EditorView, keymap } from "@codemirror/view";
import { describe, expect, test, vi } from "vitest";
import { cellId } from "@/__tests__/branded";
import { OverridingHotkeyProvider } from "@/core/hotkeys/hotkeys";
@@ -163,6 +163,38 @@ test("auto_close_pairs: false removes closeBrackets keymaps", () => {
expect(hasBracketPairHandler(withoutAutoClose)).toBe(false);
});
+test("go to definition falls through to lower-priority LSP keymap", () => {
+ const lspGoToDefinition = vi.fn(() => true);
+ const goToDefinitionKey = getOpts().hotkeys.getHotkey(
+ "cell.goToDefinition",
+ ).key;
+
+ const view = new EditorView({
+ state: EditorState.create({
+ doc: "parser.add_argument('--foo')",
+ selection: { anchor: "parser.".length },
+ extensions: [
+ ...setup(),
+ keymap.of([{ key: goToDefinitionKey, run: lspGoToDefinition }]),
+ ],
+ }),
+ parent: document.body,
+ });
+
+ try {
+ const event = new KeyboardEvent("keydown", {
+ key: goToDefinitionKey,
+ bubbles: true,
+ cancelable: true,
+ });
+ view.contentDOM.dispatchEvent(event);
+
+ expect(lspGoToDefinition).toHaveBeenCalledOnce();
+ } finally {
+ view.destroy();
+ }
+});
+
test("placeholder adds another extension", () => {
const opts = getOpts();
const withAI = new PythonLanguageAdapter()
diff --git a/frontend/src/core/codemirror/cells/extensions.ts b/frontend/src/core/codemirror/cells/extensions.ts
index 2ac33eaf69..c1b3acc662 100644
--- a/frontend/src/core/codemirror/cells/extensions.ts
+++ b/frontend/src/core/codemirror/cells/extensions.ts
@@ -106,11 +106,8 @@ function cellKeymaps({
keybindings.push(
{
key: hotkeys.getHotkey("cell.goToDefinition").key,
- preventDefault: true,
- stopPropagation: true,
run: (ev) => {
- goToDefinitionAtCursorPosition(ev);
- return true;
+ return goToDefinitionAtCursorPosition(ev);
},
},
{