Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix(tests): de-flake tracer fallback test and loosen memory thresholds (#9485)

Myles Scolnick467d3c558551
diff --git a/tests/_messaging/test_variables.py b/tests/_messaging/test_variables.py
index 218f8f0afe..b28946ee58 100644
--- a/tests/_messaging/test_variables.py
+++ b/tests/_messaging/test_variables.py
@@ -176,8 +176,11 @@ def test_get_variable_preview_memory_numpy() -> None:
mem_diff_mb = (mem_after - mem_before) / (1024 * 1024)
- # Memory shouldn't increase significantly during preview
- assert mem_diff_mb < 1, (
+ # Memory shouldn't increase significantly during preview.
+ # Threshold is well under the 100MB array size so we still catch
+ # full copies, but loose enough to absorb allocator noise on
+ # macOS arm64 runners.
+ assert mem_diff_mb < 5, (
f"Memory increased by {mem_diff_mb}MB during preview"
)
assert preview == "[1. 1. 1. ... 1. 1. 1.]"
@@ -197,8 +200,11 @@ def test_get_variable_preview_bytesarray() -> None:
mem_diff_mb = (mem_after - mem_before) / (1024 * 1024)
- # Memory shouldn't increase significantly during preview
- assert mem_diff_mb < 1, (
+ # Memory shouldn't increase significantly during preview.
+ # Threshold is well under the 100MB bytearray size so we still catch
+ # full copies, but loose enough to absorb allocator noise on
+ # macOS arm64 runners.
+ assert mem_diff_mb < 5, (
f"Memory increased by {mem_diff_mb}MB during preview"
)
assert (
diff --git a/tests/test_tracer.py b/tests/test_tracer.py
index 6420b00f0a..633ba35304 100644
--- a/tests/test_tracer.py
+++ b/tests/test_tracer.py
@@ -164,6 +164,16 @@ class TestSetTracerProvider:
monkeypatch.setattr(GLOBAL_SETTINGS, "TRACING", True)
+ # Import these BEFORE entering patch.dict("sys.modules", ...).
+ # On exit, patch.dict clears sys.modules and restores the snapshot
+ # taken at entry, which wipes any modules first loaded inside the
+ # block. If opentelemetry.sdk.trace is only imported inside, the
+ # post-block re-import creates a new TracerProvider class and
+ # isinstance() against the provider built inside the block fails.
+ from opentelemetry import trace
+ from opentelemetry.sdk.trace import TracerProvider
+ from opentelemetry.sdk.trace.export import BatchSpanProcessor
+
with patch.dict(
"sys.modules",
{"opentelemetry.exporter.otlp.proto.http.trace_exporter": None},
@@ -172,10 +182,6 @@ class TestSetTracerProvider:
_set_tracer_provider()
- from opentelemetry import trace
- from opentelemetry.sdk.trace import TracerProvider
- from opentelemetry.sdk.trace.export import BatchSpanProcessor
-
provider = trace.get_tracer_provider()
assert isinstance(provider, TracerProvider)
processors = provider._active_span_processor._span_processors # type: ignore[attr-defined]