Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

chore: adopt disabled test rule (#10789)

Shahmir Varqha492c6938e278
diff --git a/frontend/.oxlintrc.json b/frontend/.oxlintrc.json
index 3875cacdb9..32d367b6ad 100644
--- a/frontend/.oxlintrc.json
+++ b/frontend/.oxlintrc.json
@@ -73,7 +73,6 @@
"react/todo": "off",
"typescript/explicit-member-accessibility": "off",
"vitest/no-conditional-expect": "off",
- "vitest/no-disabled-tests": "off",
"vitest/no-standalone-expect": [
"error",
{ "additionalTestBlockFunctions": ["beforeEach"] }
diff --git a/frontend/src/components/data-table/__tests__/url-detector.test.tsx b/frontend/src/components/data-table/__tests__/url-detector.test.tsx
index 49250f7a11..ca8bf17005 100644
--- a/frontend/src/components/data-table/__tests__/url-detector.test.tsx
+++ b/frontend/src/components/data-table/__tests__/url-detector.test.tsx
@@ -98,7 +98,7 @@ describe("UrlDetector", () => {
expect(img).toHaveAttribute("src", dataUri);
});
- it.skip("prevents event propagation on link clicks", () => {
+ it.fails("prevents event propagation on link clicks", () => {
const mockStopPropagation = vi.fn();
render(<UrlDetector parts={parseContent("Check https://marimo.io")} />);
const link = screen.getByRole("link");
diff --git a/frontend/src/core/codemirror/language/__tests__/utils.test.ts b/frontend/src/core/codemirror/language/__tests__/utils.test.ts
index f88d21957b..81ea27aa1b 100644
--- a/frontend/src/core/codemirror/language/__tests__/utils.test.ts
+++ b/frontend/src/core/codemirror/language/__tests__/utils.test.ts
@@ -158,7 +158,7 @@ Hello,
});
// f-strings not currently supported
- it.skip("handles markdown with variables", () => {
+ it.fails("handles markdown with variables", () => {
const mockEditor = createEditor('mo.md(f"""{a}\n{b}!""")');
// Set to markdown
switchLanguage(mockEditor, { language: "markdown" });
diff --git a/frontend/src/plugins/impl/panel/__tests__/utils.test.ts b/frontend/src/plugins/impl/panel/__tests__/utils.test.ts
index a583dc48c2..ebaf6a15d4 100644
--- a/frontend/src/plugins/impl/panel/__tests__/utils.test.ts
+++ b/frontend/src/plugins/impl/panel/__tests__/utils.test.ts
@@ -19,8 +19,8 @@ describe("MessageSchema", () => {
});
});
-describe.skip("extractBuffers", () => {
- it("should extract ArrayBuffer and replace with id", () => {
+describe("extractBuffers", () => {
+ it.fails("should extract ArrayBuffer and replace with id", () => {
const buffer = new ArrayBuffer(8);
const input = { data: buffer };
const buffers: ArrayBuffer[] = [];
@@ -31,7 +31,7 @@ describe.skip("extractBuffers", () => {
expect(buffers).toEqual([buffer]);
});
- it("should handle nested objects and arrays", () => {
+ it.fails("should handle nested objects and arrays", () => {
const buffer1 = new ArrayBuffer(8);
const buffer2 = new ArrayBuffer(16);
const input = {
@@ -51,7 +51,7 @@ describe.skip("extractBuffers", () => {
expect(buffers).toEqual([buffer1, buffer2]);
});
- it("should handle Map objects", () => {
+ it.fails("should handle Map objects", () => {
const buffer = new ArrayBuffer(8);
const input = new Map([["key", buffer]]);
const buffers: ArrayBuffer[] = [];
diff --git a/frontend/src/plugins/impl/vega/__tests__/vega.test.ts b/frontend/src/plugins/impl/vega/__tests__/vega.test.ts
index 0ba000d477..c3724e436d 100644
--- a/frontend/src/plugins/impl/vega/__tests__/vega.test.ts
+++ b/frontend/src/plugins/impl/vega/__tests__/vega.test.ts
@@ -470,7 +470,7 @@ Bob.Jones,25
`);
});
- it.skip("should handle arrow files", async () => {
+ it.fails("should handle arrow files", async () => {
// Create a small arrow file with schema and one empty record batch
const arrowData = new Uint8Array([
0x41,
diff --git a/frontend/src/utils/__tests__/events.test.ts b/frontend/src/utils/__tests__/events.test.ts
index 1150cbbd09..6ab8ed8538 100644
--- a/frontend/src/utils/__tests__/events.test.ts
+++ b/frontend/src/utils/__tests__/events.test.ts
@@ -179,7 +179,7 @@ describe("Events.fromInput", () => {
// jsdom does not implement isContentEditable, so this is tested
// via shouldIgnoreKeyboardEvent which has a closest() fallback.
- test.skip("returns true for contentEditable", () => {
+ test.fails("returns true for contentEditable", () => {
const div = document.createElement("div");
div.setAttribute("contenteditable", "true");
document.body.append(div);