Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

ci(fe): fail Test FE when lint/typecheck mutate tracked files (#8440)

axssel4949c966da5f
diff --git a/.github/workflows/test_fe.yaml b/.github/workflows/test_fe.yaml
index 574d88a3e7..08410a310d 100644
--- a/.github/workflows/test_fe.yaml
+++ b/.github/workflows/test_fe.yaml
@@ -61,6 +61,17 @@ jobs:
id: lint
run: pnpm turbo lint
+ - name: 🔒 Verify clean git tree after lint
+ id: lint_clean_tree
+ run: |
+ CHANGES="$(git status --porcelain)"
+ if [[ -n "$CHANGES" ]]; then
+ echo "Lint changed tracked files. Commit generated/autofixed files."
+ echo "$CHANGES"
+ git --no-pager diff --stat
+ exit 1
+ fi
+
- name: Comment on lint failure
if: failure() && steps.lint.outcome == 'failure'
uses: ./.github/actions/pr-comment-on-failure
@@ -69,6 +80,14 @@ jobs:
command: "pnpm turbo lint"
github-token: ${{ secrets.GITHUB_TOKEN }}
+ - name: Comment on clean-tree failure after lint
+ if: failure() && steps.lint_clean_tree.outcome == 'failure'
+ uses: ./.github/actions/pr-comment-on-failure
+ with:
+ check-name: "clean-tree"
+ command: "pnpm turbo lint && git status --short"
+ github-token: ${{ secrets.GITHUB_TOKEN }}
+
- name: Comment on dedupe failure
if: failure() && steps.dedupe.outcome == 'failure'
uses: ./.github/actions/pr-comment-on-failure
@@ -101,6 +120,17 @@ jobs:
id: typecheck
run: pnpm turbo typecheck
+ - name: 🔒 Verify clean git tree after typecheck
+ id: typecheck_clean_tree
+ run: |
+ CHANGES="$(git status --porcelain)"
+ if [[ -n "$CHANGES" ]]; then
+ echo "Typecheck/codegen changed tracked files. Commit generated files."
+ echo "$CHANGES"
+ git --no-pager diff --stat
+ exit 1
+ fi
+
- name: 🧪 Test
id: test
run: pnpm turbo test
@@ -121,6 +151,14 @@ jobs:
command: "pnpm turbo test"
github-token: ${{ secrets.GITHUB_TOKEN }}
+ - name: Comment on clean-tree failure after typecheck
+ if: failure() && steps.typecheck_clean_tree.outcome == 'failure'
+ uses: ./.github/actions/pr-comment-on-failure
+ with:
+ check-name: "clean-tree"
+ command: "pnpm turbo typecheck && git status --short"
+ github-token: ${{ secrets.GITHUB_TOKEN }}
+
build_frontend:
needs: changes
if: ${{ needs.changes.outputs.frontend == 'true' }}