Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

tests: for embed_options in mo.ui.altair_chart (#7292)

Myles Scolnick4e99bc8d19cd
diff --git a/marimo/_plugins/ui/_impl/altair_chart.py b/marimo/_plugins/ui/_impl/altair_chart.py
index 50882fa75f..db8f1d1df6 100644
--- a/marimo/_plugins/ui/_impl/altair_chart.py
+++ b/marimo/_plugins/ui/_impl/altair_chart.py
@@ -429,9 +429,7 @@ class altair_chart(UIElement[ChartSelection, ChartDataType]):
import altair as alt
# Capture any global altair embed options that may have been set
- embed_options = {}
- if alt.renderers.options.get("embed_options"):
- embed_options = alt.renderers.options["embed_options"]
+ embed_options = alt.renderers.options.get("embed_options") or {}
register_transformers()
diff --git a/tests/_plugins/ui/_impl/test_altair_chart.py b/tests/_plugins/ui/_impl/test_altair_chart.py
index a09827c6c3..6be77ef759 100644
--- a/tests/_plugins/ui/_impl/test_altair_chart.py
+++ b/tests/_plugins/ui/_impl/test_altair_chart.py
@@ -1607,3 +1607,129 @@ def test_autosize_not_applied_with_nested_hconcat() -> None:
marimo_chart_explicit = altair_chart(vconcat_with_autosize)
# Should keep the explicit autosize value
assert get_autosize(marimo_chart_explicit._spec) == "none"
+
+
[email protected](not HAS_DEPS, reason="optional dependencies not installed")
+def test_embed_options_not_set() -> None:
+ """Test that embed_options defaults to empty dict when not set."""
+ import altair as alt
+
+ # Reset to default (no embed_options)
+ alt.renderers.enable("default")
+ if "embed_options" in alt.renderers.options:
+ del alt.renderers.options["embed_options"]
+
+ data = pd.DataFrame({"x": [1, 2, 3], "y": [4, 5, 6]})
+ chart = alt.Chart(data).mark_point().encode(x="x", y="y")
+
+ marimo_chart = altair_chart(chart)
+
+ # embed_options should be an empty dict
+ assert marimo_chart._component_args["embed-options"] == {}
+
+
[email protected](not HAS_DEPS, reason="optional dependencies not installed")
+def test_embed_options_set() -> None:
+ """Test that embed_options are passed through when set."""
+ import altair as alt
+
+ # Set custom embed options
+ custom_embed_options = {
+ "actions": False,
+ "theme": "dark",
+ "renderer": "svg",
+ }
+ alt.renderers.options["embed_options"] = custom_embed_options
+
+ data = pd.DataFrame({"x": [1, 2, 3], "y": [4, 5, 6]})
+ chart = alt.Chart(data).mark_point().encode(x="x", y="y")
+
+ marimo_chart = altair_chart(chart)
+
+ # embed_options should match what was set
+ assert (
+ marimo_chart._component_args["embed-options"] == custom_embed_options
+ )
+ assert marimo_chart._component_args["embed-options"]["actions"] is False
+ assert marimo_chart._component_args["embed-options"]["theme"] == "dark"
+ assert marimo_chart._component_args["embed-options"]["renderer"] == "svg"
+
+ # Clean up
+ del alt.renderers.options["embed_options"]
+
+
[email protected](not HAS_DEPS, reason="optional dependencies not installed")
+def test_embed_options_with_various_values() -> None:
+ """Test embed_options with various configuration values."""
+ import altair as alt
+
+ data = pd.DataFrame({"x": [1, 2, 3], "y": [4, 5, 6]})
+ chart = alt.Chart(data).mark_point().encode(x="x", y="y")
+
+ # Test with actions object
+ alt.renderers.options["embed_options"] = {
+ "actions": {
+ "export": True,
+ "source": False,
+ "compiled": False,
+ "editor": False,
+ }
+ }
+ marimo_chart = altair_chart(chart)
+ assert isinstance(
+ marimo_chart._component_args["embed-options"]["actions"], dict
+ )
+ assert (
+ marimo_chart._component_args["embed-options"]["actions"]["export"]
+ is True
+ )
+
+ # Test with scaleFactor
+ alt.renderers.options["embed_options"] = {"scaleFactor": 2}
+ marimo_chart = altair_chart(chart)
+ assert marimo_chart._component_args["embed-options"]["scaleFactor"] == 2
+
+ # Test with downloadFileName
+ alt.renderers.options["embed_options"] = {"downloadFileName": "my-chart"}
+ marimo_chart = altair_chart(chart)
+ assert (
+ marimo_chart._component_args["embed-options"]["downloadFileName"]
+ == "my-chart"
+ )
+
+ # Test with multiple options
+ alt.renderers.options["embed_options"] = {
+ "actions": False,
+ "scaleFactor": 3,
+ "downloadFileName": "test",
+ "theme": "quartz",
+ }
+ marimo_chart = altair_chart(chart)
+ embed_opts = marimo_chart._component_args["embed-options"]
+ assert embed_opts["actions"] is False
+ assert embed_opts["scaleFactor"] == 3
+ assert embed_opts["downloadFileName"] == "test"
+ assert embed_opts["theme"] == "quartz"
+
+ # Clean up
+ del alt.renderers.options["embed_options"]
+
+
[email protected](not HAS_DEPS, reason="optional dependencies not installed")
+def test_embed_options_empty_dict() -> None:
+ """Test that setting embed_options to empty dict works correctly."""
+ import altair as alt
+
+ # Explicitly set to empty dict
+ alt.renderers.options["embed_options"] = {}
+
+ data = pd.DataFrame({"x": [1, 2, 3], "y": [4, 5, 6]})
+ chart = alt.Chart(data).mark_point().encode(x="x", y="y")
+
+ marimo_chart = altair_chart(chart)
+
+ # Should be empty dict
+ assert marimo_chart._component_args["embed-options"] == {}
+
+ # Clean up
+ del alt.renderers.options["embed_options"]