Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

Use request path to scope code-mode runtime behavior (#8702)

Trevor Manz4f131a821dfc
diff --git a/marimo/_code_mode/_context.py b/marimo/_code_mode/_context.py
index 817cde3ebf..9ab691f33e 100644
--- a/marimo/_code_mode/_context.py
+++ b/marimo/_code_mode/_context.py
@@ -86,6 +86,7 @@ class NotebookCellData:
LOGGER = _loggers.marimo_logger()
+
# Module-level store for cell names set via code_mode.
# Persists across context manager invocations within the same kernel.
_cell_names: dict[CellId_t, str] = {}
diff --git a/marimo/_messaging/context.py b/marimo/_messaging/context.py
index 0fbc78ce3d..ed97f865a5 100644
--- a/marimo/_messaging/context.py
+++ b/marimo/_messaging/context.py
@@ -46,15 +46,10 @@ class http_request_context:
HTTP_REQUEST_CTX.reset(self.token)
-def is_headless_request() -> bool:
- """True when the current request comes from a non-browser client.
-
- Returns False (not headless) when there is no request context
- (e.g. websocket/browser) or when the Accept header includes
- text/html. Returns True for programmatic clients like the
- ``/execute`` SSE endpoint.
- """
+def is_code_mode_request() -> bool:
+ """True when the current request originated from the /api/kernel/execute endpoint."""
request = HTTP_REQUEST_CTX.get(None)
if request is None:
return False
- return "text/html" not in request.headers.get("accept", "")
+ path: str = request.url.get("path", "")
+ return path.endswith("/api/kernel/execute")
diff --git a/marimo/_messaging/tracebacks.py b/marimo/_messaging/tracebacks.py
index bad201b5e6..5a86eeda78 100644
--- a/marimo/_messaging/tracebacks.py
+++ b/marimo/_messaging/tracebacks.py
@@ -3,7 +3,7 @@ from __future__ import annotations
import sys
-from marimo._messaging.context import is_headless_request
+from marimo._messaging.context import is_code_mode_request
from marimo._messaging.types import Stderr
@@ -23,7 +23,7 @@ def _highlight_traceback(traceback: str) -> str:
def write_traceback(traceback: str) -> None:
- if isinstance(sys.stderr, Stderr) and not is_headless_request():
+ if isinstance(sys.stderr, Stderr) and not is_code_mode_request():
# Strip marimo's internal executor.py frame and highlight for the UI
trimmed = _trim_traceback(traceback)
sys.stderr._write_with_mimetype(
diff --git a/marimo/_runtime/runtime.py b/marimo/_runtime/runtime.py
index 70154c502b..cda289b7b1 100644
--- a/marimo/_runtime/runtime.py
+++ b/marimo/_runtime/runtime.py
@@ -52,7 +52,7 @@ from marimo._lint.validate_graph import check_for_errors
from marimo._messaging.cell_output import CellChannel
from marimo._messaging.context import (
http_request_context,
- is_headless_request,
+ is_code_mode_request,
run_id_context,
)
from marimo._messaging.errors import (
@@ -3121,7 +3121,7 @@ class PackagesCallbacks:
)
)
else:
- if is_headless_request():
+ if is_code_mode_request():
return
broadcast_notification(
diff --git a/tests/_messaging/test_tracebacks.py b/tests/_messaging/test_tracebacks.py
index 48ec9ec7c2..8b72d0f7f8 100644
--- a/tests/_messaging/test_tracebacks.py
+++ b/tests/_messaging/test_tracebacks.py
@@ -3,7 +3,7 @@ from __future__ import annotations
from unittest.mock import MagicMock, patch
-from marimo._messaging.context import HTTP_REQUEST_CTX, is_headless_request
+from marimo._messaging.context import HTTP_REQUEST_CTX, is_code_mode_request
from marimo._messaging.tracebacks import (
_highlight_traceback,
_trim_traceback,
@@ -83,13 +83,13 @@ class TestTracebacks:
assert is_code_highlighting("") is False
assert is_code_highlighting('class="not-codehilite"') is False
- def test_write_traceback_plain_text_when_accept_not_html(self) -> None:
- """When HTTP request has Accept without text/html, use plain text."""
+ def test_write_traceback_plain_text_in_code_mode(self) -> None:
+ """When request is from /api/kernel/execute, use plain text."""
mock_stderr = MagicMock(spec=Stderr)
req = HTTPRequest(
- url={},
+ url={"path": "/api/kernel/execute"},
base_url={},
- headers={"accept": "text/event-stream"},
+ headers={},
query_params={},
path_params={},
cookies={},
@@ -106,13 +106,13 @@ class TestTracebacks:
finally:
HTTP_REQUEST_CTX.reset(token)
- def test_write_traceback_html_when_accept_includes_html(self) -> None:
- """When HTTP request has Accept with text/html, use HTML formatting."""
+ def test_write_traceback_html_for_regular_http_request(self) -> None:
+ """Regular HTTP requests (no code-mode header) get HTML tracebacks."""
mock_stderr = MagicMock(spec=Stderr)
req = HTTPRequest(
url={},
base_url={},
- headers={"accept": "text/html, application/json"},
+ headers={"accept": "application/json"},
query_params={},
path_params={},
cookies={},
@@ -130,32 +130,15 @@ class TestTracebacks:
HTTP_REQUEST_CTX.reset(token)
-class TestIsHeadlessRequest:
+class TestIsCodeModeRequest:
def test_no_request_context(self) -> None:
- assert is_headless_request() is False
-
- def test_accept_event_stream(self) -> None:
- req = HTTPRequest(
- url={},
- base_url={},
- headers={"accept": "text/event-stream"},
- query_params={},
- path_params={},
- cookies={},
- meta={},
- user=None,
- )
- token = HTTP_REQUEST_CTX.set(req)
- try:
- assert is_headless_request() is True
- finally:
- HTTP_REQUEST_CTX.reset(token)
+ assert is_code_mode_request() is False
- def test_accept_html(self) -> None:
+ def test_execute_endpoint(self) -> None:
req = HTTPRequest(
- url={},
+ url={"path": "/api/kernel/execute"},
base_url={},
- headers={"accept": "text/html"},
+ headers={},
query_params={},
path_params={},
cookies={},
@@ -164,15 +147,15 @@ class TestIsHeadlessRequest:
)
token = HTTP_REQUEST_CTX.set(req)
try:
- assert is_headless_request() is False
+ assert is_code_mode_request() is True
finally:
HTTP_REQUEST_CTX.reset(token)
- def test_accept_wildcard(self) -> None:
+ def test_run_endpoint(self) -> None:
req = HTTPRequest(
- url={},
+ url={"path": "/api/kernel/run"},
base_url={},
- headers={"accept": "*/*"},
+ headers={},
query_params={},
path_params={},
cookies={},
@@ -181,11 +164,11 @@ class TestIsHeadlessRequest:
)
token = HTTP_REQUEST_CTX.set(req)
try:
- assert is_headless_request() is True
+ assert is_code_mode_request() is False
finally:
HTTP_REQUEST_CTX.reset(token)
- def test_no_accept_header(self) -> None:
+ def test_empty_url(self) -> None:
req = HTTPRequest(
url={},
base_url={},
@@ -198,7 +181,7 @@ class TestIsHeadlessRequest:
)
token = HTTP_REQUEST_CTX.set(req)
try:
- assert is_headless_request() is True
+ assert is_code_mode_request() is False
finally:
HTTP_REQUEST_CTX.reset(token)