A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix popout columns logic for long strings (#7201)
Shahmir Varqha5773eadda557
diff --git a/frontend/src/components/data-table/columns.tsx b/frontend/src/components/data-table/columns.tsxindex 8898ebfeeb..1064329658 100644--- a/frontend/src/components/data-table/columns.tsx+++ b/frontend/src/components/data-table/columns.tsx@@ -332,7 +332,7 @@ const PopoutColumn = ({<EmotionCacheProvider container={null}><Popover><PopoverTrigger- className={cn(cellStyles, "w-fit outline-hidden")}+ className={cn(cellStyles, "max-w-fit outline-hidden")}onClick={selectCell}onMouseDown={(e) => {// Prevent cell underneath from being selected@@ -477,6 +477,8 @@ export function renderCellValue<TData, TValue>({const dataType = column.columnDef.meta?.dataType;const dtype = column.columnDef.meta?.dtype;+ const isWrapped = column.getColumnWrapping?.() === "wrap";+if (dataType === "datetime" && typeof value === "string") {try {const date = new Date(value);@@ -508,10 +510,13 @@ export function renderCellValue<TData, TValue>({: String(renderValue());const parts = parseContent(stringValue);- const hasMarkup = parts.some((part) => part.type !== "text");- if (hasMarkup || stringValue.length < MAX_STRING_LENGTH) {+ const allMarkup = parts.every((part) => part.type !== "text");+ if (allMarkup || stringValue.length < MAX_STRING_LENGTH || isWrapped) {return (- <div onClick={selectCell} className={cellStyles}>+ <div+ onClick={selectCell}+ className={cn(cellStyles, isWrapped && COLUMN_WRAPPING_STYLES)}+ ><UrlDetector parts={parts} /></div>);@@ -522,9 +527,9 @@ export function renderCellValue<TData, TValue>({cellStyles={cellStyles}selectCell={selectCell}rawStringValue={stringValue}- contentClassName="max-h-64 overflow-auto whitespace-pre-wrap break-words text-sm"+ contentClassName="max-h-64 overflow-auto whitespace-pre-wrap break-words text-sm w-96"buttonText="X"- wrapped={column.getColumnWrapping?.() === "wrap"}+ wrapped={isWrapped}><UrlDetector parts={parts} /></PopoutColumn>@@ -575,7 +580,7 @@ export function renderCellValue<TData, TValue>({cellStyles={cellStyles}selectCell={selectCell}rawStringValue={rawStringValue}- wrapped={column.getColumnWrapping?.() === "wrap"}+ wrapped={isWrapped}><JsonOutput data={value} format="tree" className="max-h-64" /></PopoutColumn>diff --git a/marimo/_smoke_tests/tables/rich_elements.py b/marimo/_smoke_tests/tables/rich_elements.pyindex 5a833c65c1..4740a54a5b 100644--- a/marimo/_smoke_tests/tables/rich_elements.py+++ b/marimo/_smoke_tests/tables/rich_elements.py@@ -1,6 +1,6 @@import marimo-__generated_with = "0.15.5"+__generated_with = "0.17.6"app = marimo.App(width="medium")@@ -15,7 +15,9 @@ def _():@app.celldef _(mo):- mo.md(r"""# Printing Rich Elements""")+ mo.md(r"""+ # Printing Rich Elements+ """)return@@ -112,6 +114,10 @@ def _(alt, mo, pd):"lorem_ipsum_dollar_sit" * 20,"lorem_ipsum_dollar_sit" * 20,],+ "long_text_with_markup": [+ "lorem link: https://www.google.com" * 4,+ "lorem link: https://www.google.com" * 4,+ ],"large_array": [[1] * 60,[2] * 60,@@ -171,7 +177,9 @@ def _(data, mo, pl):@app.celldef _(mo, password):- mo.md(f"""### Password value: {password.value}""")+ mo.md(f"""+ ### Password value: {password.value}+ """)return