Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

refactor: reset image errors with source changes (#11010)

Shahmir Varqha5913b0931c73
diff --git a/frontend/src/plugins/impl/image-comparison/ImageComparisonComponent.tsx b/frontend/src/plugins/impl/image-comparison/ImageComparisonComponent.tsx
index 968f626fbe..fece6b7c4e 100644
--- a/frontend/src/plugins/impl/image-comparison/ImageComparisonComponent.tsx
+++ b/frontend/src/plugins/impl/image-comparison/ImageComparisonComponent.tsx
@@ -19,7 +19,7 @@ function truncateSrc(src: string): string {
return src.length > MAX_LENGTH ? `${src.slice(0, MAX_LENGTH)}…` : src;
}
-const ImageComparisonComponent: React.FC<ImageComparisonData> = ({
+const ImageComparisonContent: React.FC<ImageComparisonData> = ({
beforeSrc,
afterSrc,
value,
@@ -31,12 +31,8 @@ const ImageComparisonComponent: React.FC<ImageComparisonData> = ({
() => new Set(),
);
- React.useEffect(() => {
- setFailedSrcs(new Set());
- }, [beforeSrc, afterSrc]);
-
const handleError = React.useCallback((src: string) => {
- setFailedSrcs((prev) => new Set(prev).add(src));
+ setFailedSrcs((previous) => new Set(previous).add(src));
}, []);
const containerStyle: React.CSSProperties = {
@@ -106,4 +102,9 @@ const ImageComparisonComponent: React.FC<ImageComparisonData> = ({
);
};
+const ImageComparisonComponent: React.FC<ImageComparisonData> = (props) => {
+ const sourceKey = JSON.stringify([props.beforeSrc, props.afterSrc]);
+ return <ImageComparisonContent key={sourceKey} {...props} />;
+};
+
export default ImageComparisonComponent;