Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

test: increase deadline for a performance test and mark flaky (#9346)

Akshay Agrawal59f49a58cd95
diff --git a/tests/_plugins/ui/_impl/tables/test_narwhals.py b/tests/_plugins/ui/_impl/tables/test_narwhals.py
index eab766605a..8ae25a4941 100644
--- a/tests/_plugins/ui/_impl/tables/test_narwhals.py
+++ b/tests/_plugins/ui/_impl/tables/test_narwhals.py
@@ -1794,6 +1794,7 @@ def test_get_sample_values_returns_primitives() -> None:
"df",
create_dataframes({f"col_{i}": [1, 2, 3] for i in range(2000)}),
)
def test_get_field_types_with_many_columns_is_performant(df: Any) -> None:
manager = get_table_manager(df)
@@ -1804,7 +1805,9 @@ def test_get_field_types_with_many_columns_is_performant(df: Any) -> None:
# This can be slow if get_field_types is not optimized.
# https://github.com/marimo-team/marimo/issues/3107
total_ms = (end_time - start_time) * 1000
- assert total_ms < 500, (
+ # A deadline of 500ms is sometimes exceeded on CI, we are guarding against
+ # an n^2 regression so 1s is still fine.
+ assert total_ms < 1000, (
f"Total time: {total_ms}ms for {df.shape[1]} columns with {type(df)}"
)