Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix eslint error by moving use memo up (#7241)

Shahmir Varqha5cfe517a2b2c
diff --git a/frontend/src/components/editor/file-tree/__tests__/file-expolorer.test.ts b/frontend/src/components/editor/file-tree/__tests__/file-expolorer.test.ts
index a68c0ee922..a59db6fb4d 100644
--- a/frontend/src/components/editor/file-tree/__tests__/file-expolorer.test.ts
+++ b/frontend/src/components/editor/file-tree/__tests__/file-expolorer.test.ts
@@ -1,3 +1,4 @@
+/* Copyright 2024 Marimo. All rights reserved. */
import { describe, expect, it } from "vitest";
import type { FileInfo } from "@/core/network/types";
import { filterHiddenTree, isDirectoryOrFileHidden } from "../file-explorer";
diff --git a/frontend/src/components/editor/file-tree/file-explorer.tsx b/frontend/src/components/editor/file-tree/file-explorer.tsx
index 7c0356ea4a..39b8594be6 100644
--- a/frontend/src/components/editor/file-tree/file-explorer.tsx
+++ b/frontend/src/components/editor/file-tree/file-explorer.tsx
@@ -130,6 +130,11 @@ export const FileExplorer: React.FC<{
setOpenState({});
});
+ const visibleData = React.useMemo(
+ () => filterHiddenTree(data, showHiddenFiles),
+ [data, showHiddenFiles],
+ );
+
if (isPending) {
return <Spinner size="medium" centered={true} />;
}
@@ -168,10 +173,6 @@ export const FileExplorer: React.FC<{
);
}
- const visibleData = React.useMemo(
- () => filterHiddenTree(data, showHiddenFiles),
- [data, showHiddenFiles],
- );
return (
<>
<Toolbar
@@ -729,7 +730,7 @@ export function filterHiddenTree(
continue;
}
let next = item;
- if (item.children && item.children.length) {
+ if (item.children) {
const kids = filterHiddenTree(item.children, showHidden);
if (kids !== item.children) {
next = { ...item, children: kids };
diff --git a/frontend/src/core/codemirror/copilot/copilot-config.tsx b/frontend/src/core/codemirror/copilot/copilot-config.tsx
index c0a8bf1fbb..0955ccc3be 100644
--- a/frontend/src/core/codemirror/copilot/copilot-config.tsx
+++ b/frontend/src/core/codemirror/copilot/copilot-config.tsx
@@ -27,7 +27,7 @@ export const CopilotConfig = memo(() => {
const result = await initiateSignIn();
// Validate the response has required fields
- if (!result || !result.verificationUri || !result.userCode) {
+ if (!result?.verificationUri || !result.userCode) {
Logger.error("Copilot#trySignIn: Invalid response from sign-in", {
result,
});