Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix: preserve literal text in context tooltips (#11577)

Myles Scolnick674c65955b8f
diff --git a/frontend/src/core/codemirror/ai/__tests__/resources.test.ts b/frontend/src/core/codemirror/ai/__tests__/resources.test.ts
new file mode 100644
index 0000000000..a9457a2798
--- /dev/null
+++ b/frontend/src/core/codemirror/ai/__tests__/resources.test.ts
@@ -0,0 +1,117 @@
+/* Copyright 2026 Marimo. All rights reserved. */
+
+import { markdownLanguage } from "@codemirror/lang-markdown";
+import { hoverResource, type Resource } from "@marimo-team/codemirror-mcp";
+import { createStore } from "jotai";
+import { assert, beforeEach, describe, expect, it, vi } from "vitest";
+import { MockNotebook } from "@/__mocks__/notebook";
+import { getAIContextRegistry } from "@/core/ai/context/context";
+import { ErrorContextProvider } from "@/core/ai/context/providers/error";
+import { AIContextRegistry } from "@/core/ai/context/registry";
+import { notebookAtom } from "@/core/cells/cells";
+import { CellId } from "@/core/cells/ids";
+import { resourceExtension } from "../resources";
+
+vi.mock("@marimo-team/codemirror-mcp", async (importOriginal) => ({
+ ...(await importOriginal<typeof import("@marimo-team/codemirror-mcp")>()),
+ hoverResource: vi.fn(() => []),
+}));
+
+vi.mock("@/core/ai/context/context", () => ({
+ getAIContextRegistry: vi.fn(),
+}));
+
+describe("resource tooltips", () => {
+ const message = '<b>Unexpected response</b> &amp; "details"';
+ let provider: ErrorContextProvider;
+ let resource: Resource;
+
+ beforeEach(() => {
+ vi.clearAllMocks();
+ const store = createStore();
+ store.set(
+ notebookAtom,
+ MockNotebook.notebookStateWithErrors([
+ {
+ cellId: CellId.create(),
+ cellName: "Cell 1",
+ errorData: [MockNotebook.errors.exception(message)],
+ },
+ ]),
+ );
+ provider = new ErrorContextProvider(store);
+ resource = provider.getItems()[1];
+ vi.mocked(getAIContextRegistry).mockReturnValue(
+ new AIContextRegistry().register(provider),
+ );
+ resourceExtension({ language: markdownLanguage, store });
+ });
+
+ function renderTooltip(item = resource) {
+ const options = vi.mocked(hoverResource).mock.calls[0][0];
+ assert(options.createTooltip);
+ return options.createTooltip(item).dom;
+ }
+
+ it("preserves literal text in cell error descriptions", () => {
+ const dom = renderTooltip();
+ expect(dom.textContent).toBe(message);
+ expect(dom.childElementCount).toBe(0);
+ });
+
+ it("preserves literal descriptions when a provider is unavailable", () => {
+ const dom = renderTooltip({ ...resource, type: "unknown" });
+ expect(dom.textContent).toBe(message);
+ expect(dom.childElementCount).toBe(0);
+ });
+
+ it("falls back to the literal resource name", () => {
+ const dom = renderTooltip({
+ ...resource,
+ description: undefined,
+ name: message,
+ });
+ expect(dom.textContent).toBe(message);
+ expect(dom.childElementCount).toBe(0);
+ });
+
+ it("preserves literal text in completion info strings", () => {
+ vi.spyOn(provider, "formatCompletion").mockReturnValue({
+ label: "Error",
+ info: message,
+ });
+ const dom = renderTooltip({ ...resource, description: "Fallback" });
+ expect(dom.textContent).toBe(message);
+ expect(dom.childElementCount).toBe(0);
+ });
+
+ it("preserves literal fallback text when an info renderer returns null", () => {
+ vi.spyOn(provider, "formatCompletion").mockReturnValue({
+ label: "Error",
+ info: () => null,
+ });
+ const dom = renderTooltip();
+ expect(dom.textContent).toBe(message);
+ expect(dom.childElementCount).toBe(0);
+ });
+
+ it("preserves literal fallback text for async info renderers", () => {
+ vi.spyOn(provider, "formatCompletion").mockReturnValue({
+ label: "Error",
+ info: async () => document.createElement("div"),
+ });
+ const dom = renderTooltip();
+ expect(dom.textContent).toBe(message);
+ expect(dom.childElementCount).toBe(0);
+ });
+
+ it.each(["element", "tooltip"])("preserves custom %s renderers", (kind) => {
+ const dom = document.createElement("strong");
+ dom.textContent = "Details";
+ vi.spyOn(provider, "formatCompletion").mockReturnValue({
+ label: "Error",
+ info: () => (kind === "element" ? dom : { dom }),
+ });
+ expect(renderTooltip()).toBe(dom);
+ });
+});
diff --git a/frontend/src/core/codemirror/ai/resources.ts b/frontend/src/core/codemirror/ai/resources.ts
index f955c99cc6..3473d63cff 100644
--- a/frontend/src/core/codemirror/ai/resources.ts
+++ b/frontend/src/core/codemirror/ai/resources.ts
@@ -142,7 +142,7 @@ export function resourceExtension(opts: {
function asDom(value: string): TooltipView {
const tooltip = document.createElement("div");
- tooltip.innerHTML = value;
+ tooltip.textContent = value;
return {
dom: tooltip,
};