A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
add accept & reject buttons for setup cell (#7667)
Shahmir Varqha68d742acccc7
diff --git a/frontend/src/components/editor/notebook-cell.tsx b/frontend/src/components/editor/notebook-cell.tsxindex 1b14735141..cc2564fb82 100644--- a/frontend/src/components/editor/notebook-cell.tsx+++ b/frontend/src/components/editor/notebook-cell.tsx@@ -498,7 +498,7 @@ const EditableCellComponent = ({}}tabIndex={0}>- <span className="text-[var(--slate-8)] text-sm">+ <span className="text-(--slate-8) text-sm">Double-click (or enter) to edit</span></div>@@ -1074,140 +1074,147 @@ const SetupCellComponent = ({return (<TooltipProvider><CellActionsContextMenu cellId={cellId} getEditorView={getEditorView}>- <div- data-status={cellRuntime.status}- ref={cellRef}- {...mergeProps(navigationProps, {- className: cn(- className,- "focus:ring-1 focus:ring-(--blue-7) focus:ring-offset-0",- ),- onBlur: closeCompletionHandler,- onKeyDown: resumeCompletionHandler,- })}- {...cellDomProps(cellId, cellData.name)}- title={renderCellTitle()}- tabIndex={-1}- data-setup-cell={true}- >- <div className={cn("tray")} data-hidden={!isCellCodeShown}>- <div className="absolute right-2 -top-4 z-10">- <CellToolbar- edited={cellData.edited}+ <div>+ <div+ data-status={cellRuntime.status}+ ref={cellRef}+ {...mergeProps(navigationProps, {+ className: cn(+ className,+ "focus:ring-1 focus:ring-(--blue-7) focus:ring-offset-0",+ ),+ onBlur: closeCompletionHandler,+ onKeyDown: resumeCompletionHandler,+ })}+ {...cellDomProps(cellId, cellData.name)}+ title={renderCellTitle()}+ tabIndex={-1}+ data-setup-cell={true}+ >+ <div className={cn("tray")} data-hidden={!isCellCodeShown}>+ <StagedAICellBackground+ cellId={cellId}+ className="mo-ai-setup-cell"+ />+ <div className="absolute right-2 -top-4 z-10">+ <CellToolbar+ edited={cellData.edited}+ status={cellRuntime.status}+ cellConfig={cellData.config}+ needsRun={needsRun}+ hasOutput={hasOutput}+ hasConsoleOutput={hasConsoleOutput}+ cellActionDropdownRef={cellActionDropdownRef}+ cellId={cellId}+ name={cellData.name}+ getEditorView={getEditorView}+ onRun={runCell}+ includeCellActions={true}+ />+ </div>+ <CellEditor+ theme={theme}+ showPlaceholder={showPlaceholder}+ id={cellId}+ code={cellData.code}+ config={cellData.config}status={cellRuntime.status}- cellConfig={cellData.config}- needsRun={needsRun}+ serializedEditorState={cellData.serializedEditorState}+ runCell={runCell}+ setEditorView={setEditorView}+ userConfig={userConfig}+ editorViewRef={editorView}+ editorViewParentRef={editorViewParentRef}+ hidden={!isCellCodeShown}hasOutput={hasOutput}- hasConsoleOutput={hasConsoleOutput}- cellActionDropdownRef={cellActionDropdownRef}- cellId={cellId}- name={cellData.name}- getEditorView={getEditorView}- onRun={runCell}- includeCellActions={true}+ showHiddenCode={showHiddenCode}+ languageAdapter={"python"}+ setLanguageAdapter={Functions.NOOP}+ showLanguageToggles={false}/>+ <CellRightSideActions+ edited={cellData.edited}+ status={cellRuntime.status}+ isCellStatusInline={false}+ uninstantiated={uninstantiated}+ disabled={cellData.config.disabled}+ runElapsedTimeMs={cellRuntime.runElapsedTimeMs}+ runStartTimestamp={cellRuntime.runStartTimestamp}+ lastRunStartTimestamp={cellRuntime.lastRunStartTimestamp}+ staleInputs={cellRuntime.staleInputs}+ interrupted={cellRuntime.interrupted}+ />+ <div className="shoulder-bottom hover-action">+ {canDelete && (+ <DeleteButton+ connectionState={connection.state}+ status={cellRuntime.status}+ onClick={() => {+ if (+ !loading &&+ !isAppInteractionDisabled(connection.state)+ ) {+ deleteCell({ cellId });+ }+ }}+ />+ )}+ </div></div>- <CellEditor- theme={theme}- showPlaceholder={showPlaceholder}- id={cellId}- code={cellData.code}- config={cellData.config}- status={cellRuntime.status}- serializedEditorState={cellData.serializedEditorState}- runCell={runCell}- setEditorView={setEditorView}- userConfig={userConfig}- editorViewRef={editorView}- editorViewParentRef={editorViewParentRef}- hidden={!isCellCodeShown}- hasOutput={hasOutput}- showHiddenCode={showHiddenCode}- languageAdapter={"python"}- setLanguageAdapter={Functions.NOOP}- showLanguageToggles={false}- />- <CellRightSideActions- edited={cellData.edited}- status={cellRuntime.status}- isCellStatusInline={false}- uninstantiated={uninstantiated}- disabled={cellData.config.disabled}- runElapsedTimeMs={cellRuntime.runElapsedTimeMs}- runStartTimestamp={cellRuntime.runStartTimestamp}- lastRunStartTimestamp={cellRuntime.lastRunStartTimestamp}- staleInputs={cellRuntime.staleInputs}- interrupted={cellRuntime.interrupted}- />- <div className="shoulder-bottom hover-action">- {canDelete && (- <DeleteButton- connectionState={connection.state}- status={cellRuntime.status}- onClick={() => {- if (- !loading &&- !isAppInteractionDisabled(connection.state)- ) {- deleteCell({ cellId });- }- }}+ <div className="py-1 px-2 flex justify-end gap-2 last:rounded-b">+ <span className="text-muted-foreground text-xs font-bold">+ setup cell+ </span>+ <Tooltip+ content={+ <span className="max-w-16">+ This <b>setup cell</b> is guaranteed to run before all other+ cells. Include <br />+ initialization or imports and constants required by+ top-level functions.+ </span>+ }+ >+ <HelpCircleIcon+ size={16}+ strokeWidth={1.5}+ className="rounded-lg text-muted-foreground"/>- )}+ </Tooltip></div>- </div>- <div className="py-1 px-2 flex justify-end gap-2 last:rounded-b">- <span className="text-muted-foreground text-xs font-bold">- setup cell- </span>- <Tooltip- content={- <span className="max-w-16">- This <b>setup cell</b> is guaranteed to run before all other- cells. Include <br />- initialization or imports and constants required by top-level- functions.- </span>- }- >- <HelpCircleIcon- size={16}- strokeWidth={1.5}- className="rounded-lg text-muted-foreground"+ {isErrorOutput && (+ <OutputArea+ allowExpand={true}+ forceExpand={true}+ className={CSSClasses.outputArea}+ cellId={cellId}+ output={cellRuntime.output}+ stale={false}+ loading={loading}/>- </Tooltip>- </div>- {isErrorOutput && (- <OutputArea- allowExpand={true}- forceExpand={true}- className={CSSClasses.outputArea}+ )}+ <ConsoleOutput+ consoleOutputs={cellRuntime.consoleOutputs}+ stale={consoleOutputStale}+ // Don't show name+ cellName={"_"}+ onRefactorWithAI={handleRefactorWithAI}+ onClear={() => {+ actions.clearCellConsoleOutput({ cellId });+ }}+ onSubmitDebugger={(text, index) => {+ actions.setStdinResponse({+ cellId,+ response: text,+ outputIndex: index,+ });+ requestClient.sendStdin({ text });+ }}cellId={cellId}- output={cellRuntime.output}- stale={false}- loading={loading}+ debuggerActive={cellRuntime.debuggerActive}/>- )}- <ConsoleOutput- consoleOutputs={cellRuntime.consoleOutputs}- stale={consoleOutputStale}- // Don't show name- cellName={"_"}- onRefactorWithAI={handleRefactorWithAI}- onClear={() => {- actions.clearCellConsoleOutput({ cellId });- }}- onSubmitDebugger={(text, index) => {- actions.setStdinResponse({- cellId,- response: text,- outputIndex: index,- });- requestClient.sendStdin({ text });- }}- cellId={cellId}- debuggerActive={cellRuntime.debuggerActive}- />+ </div>+ <StagedAICellFooter cellId={cellId} /></div></CellActionsContextMenu></TooltipProvider>diff --git a/frontend/src/css/app/Cell.css b/frontend/src/css/app/Cell.cssindex 663766b56b..542b42522f 100644--- a/frontend/src/css/app/Cell.css+++ b/frontend/src/css/app/Cell.css@@ -14,7 +14,7 @@width: 100%;border: 1px solid var(--gray-4);- @apply divide-y divide-[var(--gray-5)] shadow-sm-solid shadow-shade;+ @apply divide-y divide-(--gray-5) shadow-sm-solid shadow-shade;&:focus-visible {/* focus-visible outlines the entire cell body in black, but the cell's@@ -34,6 +34,10 @@z-index: 1;}+ &:has(.mo-ai-generated-cell.mo-ai-setup-cell)::before {+ border-radius: 2px;+ }+/* Styling for cells marked for deletion by AI */&:has(.mo-ai-deleted-cell) {opacity: 0.7;