Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

ci: add React Doctor and fix initial findings (#11372)

Myles Scolnick6c97a1235603
diff --git a/.github/workflows/react-doctor.yml b/.github/workflows/react-doctor.yml
new file mode 100644
index 0000000000..f7753fc3bd
--- /dev/null
+++ b/.github/workflows/react-doctor.yml
@@ -0,0 +1,31 @@
+# Docs: https://www.react.doctor/ci
+
+name: React Doctor
+
+on:
+ pull_request:
+ types: [opened, synchronize, reopened, ready_for_review]
+ push:
+ branches: ["main"]
+
+permissions:
+ contents: read
+ pull-requests: write
+ issues: write
+ statuses: write
+
+concurrency:
+ group: react-doctor-${{ github.event_name == 'pull_request' && github.ref || github.run_id }}
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+jobs:
+ react-doctor:
+ runs-on: ubuntu-latest
+ steps:
+ # Full history lets React Doctor compare PR changes with the merge base.
+ - uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5
+ with:
+ fetch-depth: 0
+
+ # Findings are advisory by default.
+ - uses: millionco/react-doctor@695e46eee203a5d1855020191aa7e9c010a1250e # v2
diff --git a/frontend/.storybook/preview.tsx b/frontend/.storybook/preview.tsx
index cc3dc06071..66230d8233 100644
--- a/frontend/.storybook/preview.tsx
+++ b/frontend/.storybook/preview.tsx
@@ -9,8 +9,13 @@ import { Toaster } from "../src/components/ui/toaster";
import { TooltipProvider } from "../src/components/ui/tooltip";
import { cn } from "../src/utils/cn";
-const withTheme: Decorator = (Story, context) => {
- const theme = context.globals.theme || "light";
+const ThemeProvider = ({
+ theme,
+ children,
+}: {
+ theme: string;
+ children: React.ReactNode;
+}) => {
useEffect(() => {
document.body.classList.add(theme, `${theme}-theme`);
return () => document.body.classList.remove(theme, `${theme}-theme`);
@@ -19,7 +24,7 @@ const withTheme: Decorator = (Story, context) => {
return (
<div className={cn(theme, "p-5")}>
<TooltipProvider>
- <Story />
+ {children}
<Toaster />
<TailwindIndicator />
</TooltipProvider>
@@ -27,6 +32,12 @@ const withTheme: Decorator = (Story, context) => {
);
};
+const withTheme: Decorator = (Story, context) => (
+ <ThemeProvider theme={context.globals.theme || "light"}>
+ <Story />
+ </ThemeProvider>
+);
+
const preview: Preview = {
parameters: {
actions: { argTypesRegex: "^on[A-Z].*" },
diff --git a/frontend/e2e-tests/global-setup.ts b/frontend/e2e-tests/global-setup.ts
index d70f585714..4732e62ed1 100644
--- a/frontend/e2e-tests/global-setup.ts
+++ b/frontend/e2e-tests/global-setup.ts
@@ -2,6 +2,7 @@
import { chromium, type FullConfig } from "@playwright/test";
import { type ApplicationNames, getAppUrl } from "../playwright.config";
+import { Logger } from "../src/utils/Logger";
async function globalSetup(_config: FullConfig) {
// Start a browser to test server connectivity
@@ -11,12 +12,12 @@ async function globalSetup(_config: FullConfig) {
// Test some apps to ensure they're ready
const criticalApps: ApplicationNames[] = ["components.py"];
- console.log("🔧 Testing server connectivity...");
+ Logger.log("🔧 Testing server connectivity...");
for (const app of criticalApps) {
try {
const url = getAppUrl(app);
- console.log(`Testing ${app} at ${url}`);
+ Logger.log(`Testing ${app} at ${url}`);
// Wait for server to be ready with retries
let retries = 3;
@@ -26,26 +27,26 @@ async function globalSetup(_config: FullConfig) {
waitUntil: "load",
timeout: 15_000,
});
- console.log(`✅ ${app} ready`);
+ Logger.log(`✅ ${app} ready`);
break;
} catch (error) {
retries--;
if (retries === 0) {
- console.error(`❌ ${app} failed to start:`, error);
+ Logger.error(`❌ ${app} failed to start:`, error);
throw error;
}
- console.log(`⏳ Retrying ${app} (${retries} attempts left)`);
+ Logger.log(`⏳ Retrying ${app} (${retries} attempts left)`);
await new Promise((resolve) => setTimeout(resolve, 2000));
}
}
} catch (error) {
- console.error(`Failed to connect to ${app}:`, error);
+ Logger.error(`Failed to connect to ${app}:`, error);
throw error;
}
}
await browser.close();
- console.log("🎉 All servers ready!");
+ Logger.log("🎉 All servers ready!");
}
export default globalSetup;
diff --git a/frontend/e2e-tests/test-utils.ts b/frontend/e2e-tests/test-utils.ts
index 5037d6c0e0..371024c820 100644
--- a/frontend/e2e-tests/test-utils.ts
+++ b/frontend/e2e-tests/test-utils.ts
@@ -1,6 +1,7 @@
/* Copyright 2026 Marimo. All rights reserved. */
import type { Locator, Page } from "@playwright/test";
+import { Logger } from "../src/utils/Logger";
/**
* Wait for a marimo app to be fully loaded and ready
@@ -53,7 +54,7 @@ export async function waitForServerReady(
);
}
- console.log(`Server not ready, retrying... (${retries}/${maxRetries})`);
+ Logger.log(`Server not ready, retrying... (${retries}/${maxRetries})`);
await new Promise((resolve) => setTimeout(resolve, 2000));
}
}
@@ -124,7 +125,7 @@ export async function safeGoto(
await page.goto(url, { waitUntil: "networkidle", timeout });
} catch (error) {
// Fallback to basic load
- console.log(`Network idle failed, trying basic load: ${error}`);
+ Logger.log(`Network idle failed, trying basic load: ${error}`);
await page.goto(url, { waitUntil: "load", timeout });
}
}
diff --git a/frontend/e2e-tests/visual-regression.spec.ts b/frontend/e2e-tests/visual-regression.spec.ts
index 2f9780376b..bbea06906d 100644
--- a/frontend/e2e-tests/visual-regression.spec.ts
+++ b/frontend/e2e-tests/visual-regression.spec.ts
@@ -69,11 +69,9 @@ async function prepareVisualCase(
await page.setViewportSize(DESKTOP_VIEWPORT);
await page.goto(getThemedUrl(visualCase.app, visualCase.theme));
- if (visualCase.view === "edit") {
- await maybeRestartKernel(page);
- } else {
- await waitForMarimoApp(page);
- }
+ await (visualCase.view === "edit"
+ ? maybeRestartKernel(page)
+ : waitForMarimoApp(page));
const heading = page.getByRole("heading", {
name: "Semantic token fixture",
@@ -95,11 +93,9 @@ async function prepareVisualCase(
);
const saveButton = page.locator("#save-button");
- if (visualCase.view === "edit") {
- await expect(saveButton).toBeVisible();
- } else {
- await expect(saveButton).toHaveCount(0);
- }
+ await (visualCase.view === "edit"
+ ? expect(saveButton).toBeVisible()
+ : expect(saveButton).toHaveCount(0));
await page.evaluate(async () => {
await document.fonts.ready;
diff --git a/frontend/package.json b/frontend/package.json
index 2d74ba01fd..c55e02e4ab 100644
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -186,7 +186,8 @@
"build-storybook": "storybook build",
"sync-katex-css": "node --experimental-strip-types scripts/sync-katex-css.ts",
"codegen": "node --experimental-strip-types scripts/generate-host-protocol.ts",
- "codegen:check": "node --experimental-strip-types scripts/generate-host-protocol.ts --check"
+ "codegen:check": "node --experimental-strip-types scripts/generate-host-protocol.ts --check",
+ "doctor": "npx react-doctor@latest"
},
"peerDependencies": {
"react": "^17 || ^18 || ^19",