Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix: add a has_warnings parse enum to indicate formatting errors (#8288)

Dylan Madisetti6eedabf7ae8c
diff --git a/marimo/_ast/load.py b/marimo/_ast/load.py
index 6eaafcfe28..f235368650 100644
--- a/marimo/_ast/load.py
+++ b/marimo/_ast/load.py
@@ -10,6 +10,7 @@ from marimo._ast.app import App, InternalApp
from marimo._ast.parse import (
MarimoFileError,
NonMarimoPythonScriptError,
+ all_violations_soft,
is_non_marimo_python_script,
)
from marimo._schemas.serialization import (
@@ -38,12 +39,15 @@ class LoadResult:
status can be one of:
- empty: No content, or only comments / a doc string
- - has_errors: Parsed, but has marimo-specific errors (**can load!!**)
+ - has_warnings: Parsed, but has soft issues auto-corrected on save
+ - has_errors: Parsed, but has errors that may lose data on save (**can load!!**)
- invalid: Could not be parsed as a marimo notebook (**cannot load**)
- valid: Parsed and valid marimo notebook
"""
- status: Literal["empty", "has_errors", "invalid", "valid"] = "empty"
+ status: Literal[
+ "empty", "has_warnings", "has_errors", "invalid", "valid"
+ ] = "empty"
notebook: Optional[NotebookSerialization] = None
contents: Optional[str] = None
@@ -125,6 +129,10 @@ def get_notebook_status(filename: str) -> LoadResult:
"Notebook has violations: \n%s",
"\n".join(map(repr, notebook.violations)),
)
+ if all_violations_soft(notebook.violations):
+ return LoadResult(
+ status="has_warnings", notebook=notebook, contents=contents
+ )
return LoadResult(
status="has_errors", notebook=notebook, contents=contents
)
diff --git a/marimo/_ast/parse.py b/marimo/_ast/parse.py
index f21836987a..9230999795 100644
--- a/marimo/_ast/parse.py
+++ b/marimo/_ast/parse.py
@@ -1158,6 +1158,21 @@ ONLY_HEADER_EXTRACTED_VIOLATION = "Only able to extract header."
NON_MARIMO_PYTHON_SCRIPT_VIOLATION = "non-marimo Python content beyond header"
EXPECTED_RUN_GUARD_VIOLATION = "Expected run guard statement"
+# Soft violations are auto-corrected on save with no data loss.
+# Any violation NOT in this set is considered "hard" (potential data loss).
+SOFT_VIOLATIONS: frozenset[str] = frozenset(
+ {
+ MARIMO_ALIAS_VIOLATION,
+ EXPECTED_GENERATED_WITH_VIOLATION,
+ EXPECTED_RUN_GUARD_VIOLATION,
+ }
+)
+
+
+def all_violations_soft(violations: list[Violation]) -> bool:
+ """Check if all violations are soft (auto-corrected on save)."""
+ return all(v.description in SOFT_VIOLATIONS for v in violations)
+
def is_non_marimo_python_script(notebook: NotebookSerialization) -> bool:
return any(
diff --git a/marimo/_cli/utils.py b/marimo/_cli/utils.py
index b9c7ae7b4b..e4f6732468 100644
--- a/marimo/_cli/utils.py
+++ b/marimo/_cli/utils.py
@@ -182,6 +182,10 @@ def check_app_correctness(filename: str, noninteractive: bool = True) -> None:
_loggers.marimo_logger().warning(
"This notebook has errors, saving may lose data. Continuing anyway."
)
+ elif status == "has_warnings":
+ _loggers.marimo_logger().info(
+ "This notebook has minor issues that will be auto-corrected on save."
+ )
def check_app_correctness_or_convert(filename: str) -> None:
diff --git a/marimo/_utils/variable_name.py b/marimo/_utils/variable_name.py
index 70cf17d68b..4e9e3e8a6b 100644
--- a/marimo/_utils/variable_name.py
+++ b/marimo/_utils/variable_name.py
@@ -1,3 +1,4 @@
+# Copyright 2026 Marimo. All rights reserved.
from __future__ import annotations
import inspect
diff --git a/tests/_ast/test_load.py b/tests/_ast/test_load.py
index b19ba81f5f..f091f4975b 100644
--- a/tests/_ast/test_load.py
+++ b/tests/_ast/test_load.py
@@ -385,25 +385,28 @@ class TestGetStatus:
("test_app_with_only_comments", "invalid"),
# Invalid (not marimo apps)
("test_invalid", "invalid"),
- # Has errors
+ # Has errors (hard violations — potential data loss)
("test_get_codes_messy_toplevel", "has_errors"),
("test_get_header_comments_invalid", "has_errors"),
- ("test_get_bad_kwargs", "has_errors"),
# Unparsable
(
"test_get_codes_non_marimo_python_script",
"invalid",
), # not marimo
- # Potentially confusing and has_errors
- ("test_get_alias_import", "has_errors"), # not official format
- ("test_get_app_kwargs", "has_errors"), # Intentionally bad kwargs
+ # Soft violations only (auto-corrected on save)
+ ("test_get_bad_kwargs", "has_warnings"),
+ ("test_get_alias_import", "has_warnings"), # alias import
+ ("test_get_app_kwargs", "has_warnings"), # missing version/guard
+ (
+ "test_app_with_no_cells",
+ "has_warnings",
+ ), # missing version/guard
# Empty files can still be opened.
(
"test_generate_filecontents_empty_with_config",
"has_errors",
), # no body
("test_generate_filecontents_empty", "has_errors"), # no body
- ("test_app_with_no_cells", "has_errors"), # No body is an error
# Invalid decorator order creates an error.
("test_decorators", "has_errors"),
# Syntax errors in code