A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix: save content when creating a new file via filename input (#8009)
Myles Scolnick718f80320a3b
diff --git a/frontend/src/components/editor/header/filename-form.tsx b/frontend/src/components/editor/header/filename-form.tsxindex 011003a41b..6e25e6e876 100644--- a/frontend/src/components/editor/header/filename-form.tsx+++ b/frontend/src/components/editor/header/filename-form.tsx@@ -3,6 +3,7 @@import type { JSX } from "react";import { FilenameInput } from "@/components/editor/header/filename-input";import { useUpdateFilename } from "@/core/saving/filename";+import { useSaveNotebook } from "@/core/saving/save-component";import { Paths } from "@/utils/paths";export const FilenameForm = ({@@ -10,14 +11,26 @@ export const FilenameForm = ({}: {filename: string | null;}): JSX.Element => {- const setFilename = useUpdateFilename();+ const updateFilename = useUpdateFilename();+ const { saveNotebook } = useSaveNotebook();++ const handleNameChange = (newFilename: string) => {+ const wasUnnamed = filename === null;+ updateFilename(newFilename).then((name) => {+ // When creating a new file (was unnamed), also save the content+ if (name !== null && wasUnnamed) {+ saveNotebook(name, true);+ }+ });+ };+return (<FilenameInputplaceholderText={filename ? Paths.basename(filename) : "untitled marimo notebook"}initialValue={filename}- onNameChange={setFilename}+ onNameChange={handleNameChange}flexibleWidth={true}resetOnBlur={true}data-testid="filename-input"diff --git a/frontend/src/components/editor/navigation/__tests__/navigation.test.ts b/frontend/src/components/editor/navigation/__tests__/navigation.test.tsindex 0daa55104c..9b892ad9d8 100644--- a/frontend/src/components/editor/navigation/__tests__/navigation.test.ts+++ b/frontend/src/components/editor/navigation/__tests__/navigation.test.ts@@ -109,6 +109,7 @@ const renderWithProvider = <T>(hook: () => T) => {// Shared mock setupconst mockSaveOrNameNotebook = vi.fn();const mockSaveIfNotebookIsPersistent = vi.fn();+const mockSaveNotebook = vi.fn();const mockRunCell = vi.fn();const mockCopyCell = vi.fn();const mockPasteCell = vi.fn();@@ -156,6 +157,7 @@ describe("useCellNavigationProps", () => {mockUseSaveNotebook.mockReturnValue({saveOrNameNotebook: mockSaveOrNameNotebook,saveIfNotebookIsPersistent: mockSaveIfNotebookIsPersistent,+ saveNotebook: mockSaveNotebook,});mockUseCellActions.mockReturnValue(mockCellActions as unknown as CellActions,diff --git a/frontend/src/core/saving/save-component.tsx b/frontend/src/core/saving/save-component.tsxindex 2d0e85ffcb..f2f151f6a1 100644--- a/frontend/src/core/saving/save-component.tsx+++ b/frontend/src/core/saving/save-component.tsx@@ -190,6 +190,7 @@ export function useSaveNotebook() {return {saveOrNameNotebook,saveIfNotebookIsPersistent,+ saveNotebook,};}