Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

feat(vim): zz/zt/zb scroll for notebook viewport (#9701) (#9728)

Lionel Sergent739276de7212
diff --git a/frontend/src/core/codemirror/keymaps/vim.ts b/frontend/src/core/codemirror/keymaps/vim.ts
index b6563abca1..77e7a7b615 100644
--- a/frontend/src/core/codemirror/keymaps/vim.ts
+++ b/frontend/src/core/codemirror/keymaps/vim.ts
@@ -112,6 +112,35 @@ export function vimKeymapExtension(): Extension[] {
];
}
+function scrollCursorTo(cm: CodeMirror, position: "center" | "start" | "end") {
+ const view = cm.cm6;
+ if (!view) {
+ return;
+ }
+ const coords = view.coordsAtPos(view.state.selection.main.head);
+ if (!coords) {
+ return;
+ }
+ const appEl = document.getElementById("App");
+ if (!appEl) {
+ return;
+ }
+ const viewportHeight = appEl.clientHeight;
+ let delta: number;
+ switch (position) {
+ case "center":
+ delta = (coords.top + coords.bottom) / 2 - viewportHeight / 2;
+ break;
+ case "start":
+ delta = coords.top;
+ break;
+ case "end":
+ delta = coords.bottom - viewportHeight;
+ break;
+ }
+ appEl.scrollBy({ top: delta, behavior: "smooth" });
+}
+
const addCustomVimCommandsOnce = once(() => {
// Go to definition
Vim.defineAction("goToDefinition", (cm: CodeMirror) => {
@@ -120,6 +149,40 @@ const addCustomVimCommandsOnce = once(() => {
});
Vim.mapCommand("gd", "action", "goToDefinition", {}, { context: "normal" });
+ // Scroll cursor to center/top/bottom of viewport (mirrors zz/zt/zb in classic vim)
+ Vim.defineAction("scrollCursorToCenter", (cm: CodeMirror) =>
+ scrollCursorTo(cm, "center"),
+ );
+ Vim.mapCommand(
+ "zz",
+ "action",
+ "scrollCursorToCenter",
+ {},
+ { context: "normal" },
+ );
+
+ Vim.defineAction("scrollCursorToTop", (cm: CodeMirror) =>
+ scrollCursorTo(cm, "start"),
+ );
+ Vim.mapCommand(
+ "zt",
+ "action",
+ "scrollCursorToTop",
+ {},
+ { context: "normal" },
+ );
+
+ Vim.defineAction("scrollCursorToBottom", (cm: CodeMirror) =>
+ scrollCursorTo(cm, "end"),
+ );
+ Vim.mapCommand(
+ "zb",
+ "action",
+ "scrollCursorToBottom",
+ {},
+ { context: "normal" },
+ );
+
// Save command
Vim.defineEx("write", "w", (cm: CodeMirror) => {
const view = cm.cm6;