A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
improvement: add data-testids to file-explorer dropdown menu items (#9427)
Myles Scolnick76509cea573b
diff --git a/frontend/src/components/editor/file-tree/file-explorer.tsx b/frontend/src/components/editor/file-tree/file-explorer.tsxindex f98936a5d0..ddaae0380d 100644--- a/frontend/src/components/editor/file-tree/file-explorer.tsx+++ b/frontend/src/components/editor/file-tree/file-explorer.tsx@@ -523,7 +523,10 @@ const Node = ({ node, style, dragHandle }: NodeRendererProps<FileInfo>) => {iconClassName="w-5 h-5">{!node.data.isDirectory && (- <DropdownMenuItem onSelect={() => node.select()}>+ <DropdownMenuItem+ onSelect={() => node.select()}+ data-testid="file-explorer-open-file-menu-item"+ ><ViewIcon className={MENU_ITEM_ICON_CLASS} />Open file</DropdownMenuItem>@@ -533,6 +536,7 @@ const Node = ({ node, style, dragHandle }: NodeRendererProps<FileInfo>) => {onSelect={() => {openFile({ path: node.data.path });}}+ data-testid="file-explorer-open-external-menu-item"><ExternalLinkIcon className={MENU_ITEM_ICON_CLASS} />Open file in external editor@@ -540,28 +544,44 @@ const Node = ({ node, style, dragHandle }: NodeRendererProps<FileInfo>) => {)}{node.data.isDirectory && (<>- <DropdownMenuItem onSelect={() => handleCreateNotebook()}>+ <DropdownMenuItem+ onSelect={() => handleCreateNotebook()}+ data-testid="file-explorer-create-notebook-menu-item"+ ><MarimoPlusIcon className={MENU_ITEM_ICON_CLASS} />Create notebook</DropdownMenuItem>- <DropdownMenuItem onSelect={() => handleCreateFile()}>+ <DropdownMenuItem+ onSelect={() => handleCreateFile()}+ data-testid="file-explorer-create-file-menu-item"+ ><FilePlus2Icon className={MENU_ITEM_ICON_CLASS} />Create file</DropdownMenuItem>- <DropdownMenuItem onSelect={() => handleCreateFolder()}>+ <DropdownMenuItem+ onSelect={() => handleCreateFolder()}+ data-testid="file-explorer-create-folder-menu-item"+ ><FolderPlusIcon className={MENU_ITEM_ICON_CLASS} />Create folder</DropdownMenuItem><DropdownMenuSeparator /></>)}- <RenameMenuItem onSelect={() => node.edit()} />- <DuplicateMenuItem onSelect={handleDuplicate} />+ <RenameMenuItem+ onSelect={() => node.edit()}+ testId="file-explorer-rename-menu-item"+ />+ <DuplicateMenuItem+ onSelect={handleDuplicate}+ testId="file-explorer-duplicate-menu-item"+ /><DropdownMenuItemonSelect={async () => {await copyToClipboard(node.data.path);toast({ title: "Copied to clipboard" });}}+ data-testid="file-explorer-copy-path-menu-item"><ListTreeIcon className={MENU_ITEM_ICON_CLASS} />Copy path@@ -574,6 +594,7 @@ const Node = ({ node, style, dragHandle }: NodeRendererProps<FileInfo>) => {);toast({ title: "Copied to clipboard" });}}+ data-testid="file-explorer-copy-relative-path-menu-item"><ListTreeIcon className={MENU_ITEM_ICON_CLASS} />Copy relative path@@ -586,6 +607,7 @@ const Node = ({ node, style, dragHandle }: NodeRendererProps<FileInfo>) => {const pythonCode = PYTHON_CODE_FOR_FILE_TYPE[fileType](path);handleInsertCode(pythonCode);}}+ data-testid="file-explorer-insert-snippet-menu-item"><BetweenHorizontalStartIcon className={MENU_ITEM_ICON_CLASS} />Insert snippet for reading file@@ -601,6 +623,7 @@ const Node = ({ node, style, dragHandle }: NodeRendererProps<FileInfo>) => {const pythonCode = PYTHON_CODE_FOR_FILE_TYPE[fileType](path);await copyToClipboard(pythonCode);}}+ data-testid="file-explorer-copy-snippet-menu-item"><BracesIcon className={MENU_ITEM_ICON_CLASS} />Copy snippet for reading file@@ -608,7 +631,10 @@ const Node = ({ node, style, dragHandle }: NodeRendererProps<FileInfo>) => {{node.data.isMarimoFile && !isWasm() && (<><DropdownMenuSeparator />- <DropdownMenuItem onSelect={handleOpenMarimoFile}>+ <DropdownMenuItem+ onSelect={handleOpenMarimoFile}+ data-testid="file-explorer-open-notebook-menu-item"+ ><PlaySquareIcon className={MENU_ITEM_ICON_CLASS} />Open notebook</DropdownMenuItem>@@ -637,6 +663,7 @@ const Node = ({ node, style, dragHandle }: NodeRendererProps<FileInfo>) => {);}}}+ data-testid="file-explorer-download-menu-item"><DownloadIcon className={MENU_ITEM_ICON_CLASS} />Download@@ -644,7 +671,10 @@ const Node = ({ node, style, dragHandle }: NodeRendererProps<FileInfo>) => {<DropdownMenuSeparator /></>)}- <DeleteMenuItem onSelect={handleDeleteFile} />+ <DeleteMenuItem+ onSelect={handleDeleteFile}+ testId="file-explorer-delete-menu-item"+ /></FileActionsDropdown></span></div>diff --git a/frontend/src/components/editor/file-tree/file-operations.tsx b/frontend/src/components/editor/file-tree/file-operations.tsxindex 0b2f7df052..ab9292aa8f 100644--- a/frontend/src/components/editor/file-tree/file-operations.tsx+++ b/frontend/src/components/editor/file-tree/file-operations.tsx@@ -219,12 +219,19 @@ export const RenameMenuItem = ({onSelect,disabled,title,+ testId,}: {onSelect: (evt: Event) => void;disabled?: boolean;title?: string;+ testId?: string;}) => (- <DropdownMenuItem onSelect={onSelect} disabled={disabled} title={title}>+ <DropdownMenuItem+ onSelect={onSelect}+ disabled={disabled}+ title={title}+ data-testid={testId}+ ><Edit3Icon className={MENU_ITEM_ICON_CLASS} />Rename</DropdownMenuItem>@@ -234,12 +241,19 @@ export const DuplicateMenuItem = ({onSelect,disabled,title,+ testId,}: {onSelect: (evt: Event) => void;disabled?: boolean;title?: string;+ testId?: string;}) => (- <DropdownMenuItem onSelect={onSelect} disabled={disabled} title={title}>+ <DropdownMenuItem+ onSelect={onSelect}+ disabled={disabled}+ title={title}+ data-testid={testId}+ ><CopyIcon className={MENU_ITEM_ICON_CLASS} />Duplicate</DropdownMenuItem>@@ -249,16 +263,19 @@ export const DeleteMenuItem = ({onSelect,disabled,title,+ testId,}: {onSelect: (evt: Event) => void;disabled?: boolean;title?: string;+ testId?: string;}) => (<DropdownMenuItemonSelect={onSelect}variant="danger"disabled={disabled}title={title}+ data-testid={testId}><Trash2Icon className={MENU_ITEM_ICON_CLASS} />Delete