A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
refactor(server): scope skew-protection exemption to login form (#10164)
Myles Scolnick7758fc1287c5
diff --git a/marimo/_server/api/middleware.py b/marimo/_server/api/middleware.pyindex bfe3199226..50c0f8e6b5 100644--- a/marimo/_server/api/middleware.py+++ b/marimo/_server/api/middleware.py@@ -130,10 +130,9 @@ class SkewProtectionMiddleware:# If not POST request, then skipif request.method != "POST":return await self.app(scope, receive, send)- # If is a form, then skip- if request.headers.get("Content-Type", "").startswith(- "application/x-www-form-urlencoded"- ):+ # Skip the login form submission. The login page is a server-rendered+ # plain HTML form and does not attach the server token header.+ if request.url.path.rstrip("/").endswith("/auth/login"):return await self.app(scope, receive, send)# If /api/kernel/execute, skip (agent-only endpoint)if request.url.path.rstrip("/").endswith("/api/kernel/execute"):diff --git a/tests/_server/api/test_middleware.py b/tests/_server/api/test_middleware.pyindex 58534c03e1..71bbe983e4 100644--- a/tests/_server/api/test_middleware.py+++ b/tests/_server/api/test_middleware.py@@ -161,6 +161,46 @@ def test_skew_protection_skips_execute(edit_app: Starlette) -> None:)+def test_skew_protection_enforced_for_form_content_type(+ edit_app: Starlette,+) -> None:+ """The skew protection token is enforced regardless of Content-Type."""+ client = TestClient(edit_app)++ # An invalid skew token with a form-urlencoded Content-Type is rejected.+ # `data=` sends an application/x-www-form-urlencoded body.+ response = client.post(+ "/api/home/running_notebooks",+ headers=token_header("fake-token", "old-skew-id"),+ data={"foo": "bar"},+ )+ assert response.status_code == 401, response.text++ # And a valid skew token still passes.+ response = client.post(+ "/api/home/running_notebooks",+ headers=token_header("fake-token"),+ data={"foo": "bar"},+ )+ assert response.status_code == 200, response.text+++def test_skew_protection_skips_login(edit_app: Starlette) -> None:+ """The login form is a plain HTML form and cannot attach the server+ token, so it must be exempt from skew protection."""+ client = TestClient(edit_app, follow_redirects=False)++ # A login POST without any skew token reaches the handler instead of+ # being blocked (401) by skew protection. The login itself fails+ # (bad password), which re-renders the login page with an error.+ response = client.post(+ "/auth/login",+ data={"password": "wrong-password"},+ )+ assert response.status_code == 200, response.text+ assert "Invalid password" in response.text++def test_skew_protection_disabled() -> None:"""Test that skew protection can be disabled via CLI flag"""app = create_starlette_app(base_url="", skew_protection=False)