A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix: align column headers with text_justify_columns setting (#8236)
Max Koretskyi7a56f86ccd83
diff --git a/frontend/src/components/data-table/__tests__/columns.test.tsx b/frontend/src/components/data-table/__tests__/columns.test.tsxindex 7599840706..06cdea38cf 100644--- a/frontend/src/components/data-table/__tests__/columns.test.tsx+++ b/frontend/src/components/data-table/__tests__/columns.test.tsx@@ -243,6 +243,53 @@ describe("generateColumns", () => {expect(cell?.props.className).toContain("center");});+ it("should apply text justification to column header parents", () => {+ const columns = generateColumns({+ rowHeaders: [],+ selection: null,+ fieldTypes,+ textJustifyColumns: { name: "right", age: "center" },+ });++ const mockColumn = (col: (typeof columns)[number]) => ({+ id: col.id,+ getCanSort: () => true,+ getCanFilter: () => false,+ getIsSorted: () => false,+ getSortIndex: () => -1,+ getFilterValue: () => undefined,+ columnDef: { meta: col.meta },+ });++ // Right-justified: parent wrapper should have items-end, sort/filter icons should flip to the left+ const { container: rightContainer } = render(+ <TooltipProvider>+ {/* eslint-disable-next-line @typescript-eslint/no-explicit-any */}+ {(columns[0].header as any)({ column: mockColumn(columns[0]) })}+ </TooltipProvider>,+ );+ const rightWrapper = rightContainer.firstElementChild;+ expect(rightWrapper?.className).toContain("items-end");+ const rightHeader = rightContainer.querySelector(+ "[data-testid='data-table-sort-button']",+ );+ expect(rightHeader?.className).toContain("flex-row-reverse");++ // Center-justified: parent wrapper should have items-center, no flex-row-reverse+ const { container: centerContainer } = render(+ <TooltipProvider>+ {/* eslint-disable-next-line @typescript-eslint/no-explicit-any */}+ {(columns[1].header as any)({ column: mockColumn(columns[1]) })}+ </TooltipProvider>,+ );+ const centerWrapper = centerContainer.firstElementChild;+ expect(centerWrapper?.className).toContain("items-center");+ const centerHeader = centerContainer.querySelector(+ "[data-testid='data-table-sort-button']",+ );+ expect(centerHeader?.className).not.toContain("flex-row-reverse");+ });+it("should not include index column if it exists", () => {const columns = generateColumns({rowHeaders: [],diff --git a/frontend/src/components/data-table/column-header.tsx b/frontend/src/components/data-table/column-header.tsxindex 315bc4860d..044c0f2238 100644--- a/frontend/src/components/data-table/column-header.tsx+++ b/frontend/src/components/data-table/column-header.tsx@@ -67,6 +67,7 @@ interface DataTableColumnHeaderProps<TData, TValue>extends React.HTMLAttributes<HTMLDivElement> {column: Column<TData, TValue>;header: React.ReactNode;+ justify?: "left" | "center" | "right";calculateTopKRows?: CalculateTopKRows;table?: Table<TData>;}@@ -74,6 +75,7 @@ interface DataTableColumnHeaderProps<TData, TValue>export const DataTableColumnHeader = <TData, TValue>({column,header,+ justify,className,calculateTopKRows,table,@@ -101,6 +103,7 @@ export const DataTableColumnHeader = <TData, TValue>({<divclassName={cn("group flex items-center my-1 space-between w-full select-none gap-2 border hover:border-border border-transparent hover:bg-(--slate-3) data-[state=open]:bg-(--slate-3) data-[state=open]:border-border rounded px-1 -mx-1",+ justify === "right" && "flex-row-reverse",className,)}data-testid="data-table-sort-button"diff --git a/frontend/src/components/data-table/columns.tsx b/frontend/src/components/data-table/columns.tsxindex 429acacdbb..ba70117313 100644--- a/frontend/src/components/data-table/columns.tsx+++ b/frontend/src/components/data-table/columns.tsx@@ -186,8 +186,16 @@ export function generateColumns<T>({</div>) : null;+ const justify = textJustifyColumns?.[key];+const headerWithType = (- <div className="flex flex-col">+ <div+ className={cn(+ "flex flex-col",+ justify === "center" && "items-center",+ justify === "right" && "items-end",+ )}+ ><spanclassName={cn("font-bold",@@ -212,6 +220,7 @@ export function generateColumns<T>({<DataTableColumnHeaderheader={headerWithTooltip}column={column}+ justify={justify}calculateTopKRows={calculateTopKRows}table={table}/>@@ -223,7 +232,13 @@ export function generateColumns<T>({}return (- <div className="flex flex-col h-full pt-0.5 pb-3 justify-between items-start">+ <div+ className={cn(+ "flex flex-col h-full pt-0.5 pb-3 justify-between items-start",+ justify === "center" && "items-center",+ justify === "right" && "items-end",+ )}+ >{dataTableColumnHeader}<TableColumnSummary columnId={key} /></div>