Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

Add proxy_path support for ClickHouse Connections (#8128)

Maruth Goyal7b293667444e
diff --git a/frontend/src/components/editor/database/__tests__/__snapshots__/as-code.test.ts.snap b/frontend/src/components/editor/database/__tests__/__snapshots__/as-code.test.ts.snap
index 097c4b94ae..d33b1aa7be 100644
--- a/frontend/src/components/editor/database/__tests__/__snapshots__/as-code.test.ts.snap
+++ b/frontend/src/components/editor/database/__tests__/__snapshots__/as-code.test.ts.snap
@@ -461,6 +461,21 @@ engine = clickhouse_connect.get_client(
)"
`;
+exports[`generateDatabaseCode > edge cases > clickhouse with proxy_path 1`] = `
+"import clickhouse_connect
+import os
+
+_password = os.environ.get("CLICKHOUSE_PASSWORD", "pass")
+engine = clickhouse_connect.get_client(
+ host="localhost",
+ user="user",
+ secure=False,
+ port=8123,
+ password=_password,
+ proxy_path="/clickhouse",
+)"
+`;
+
exports[`generateDatabaseCode > edge cases > duckdb with relative path 1`] = `
"import sqlmodel
diff --git a/frontend/src/components/editor/database/__tests__/as-code.test.ts b/frontend/src/components/editor/database/__tests__/as-code.test.ts
index 9801489cb0..b8a549d68f 100644
--- a/frontend/src/components/editor/database/__tests__/as-code.test.ts
+++ b/frontend/src/components/editor/database/__tests__/as-code.test.ts
@@ -532,6 +532,14 @@ describe("generateDatabaseCode", () => {
},
"clickhouse_connect",
],
+ [
+ "clickhouse with proxy_path",
+ {
+ ...clickhouseConnection,
+ proxy_path: "/clickhouse",
+ },
+ "clickhouse_connect",
+ ],
[
"timeplus with no port",
{
diff --git a/frontend/src/components/editor/database/as-code.ts b/frontend/src/components/editor/database/as-code.ts
index b78439fe64..3226e880a8 100644
--- a/frontend/src/components/editor/database/as-code.ts
+++ b/frontend/src/components/editor/database/as-code.ts
@@ -412,6 +412,9 @@ class ClickHouseGenerator extends CodeGenerator<"clickhouse_connect"> {
? this.secrets.print("port", this.connection.port)
: undefined,
password: this.connection.password ? password : undefined,
+ proxy_path: this.connection.proxy_path
+ ? this.secrets.print("proxy_path", this.connection.proxy_path)
+ : undefined,
};
return dedent(`
diff --git a/frontend/src/components/editor/database/schemas.ts b/frontend/src/components/editor/database/schemas.ts
index cdbdf7f940..c6ed59b2a7 100644
--- a/frontend/src/components/editor/database/schemas.ts
+++ b/frontend/src/components/editor/database/schemas.ts
@@ -267,6 +267,15 @@ export const ClickhouseConnectionSchema = z
.boolean()
.default(false)
.describe(FieldOptions.of({ label: "Use HTTPs" })),
+ proxy_path: z
+ .string()
+ .optional()
+ .describe(
+ FieldOptions.of({
+ label: "Proxy Path",
+ placeholder: "/clickhouse",
+ }),
+ ),
})
.describe(FieldOptions.of({ direction: "two-columns" }));