Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix: use UTF-8 encoding for subprocess calls in package managers (#6729)

Myles Scolnick7cb023912cac
diff --git a/marimo/_runtime/packages/conda_package_manager.py b/marimo/_runtime/packages/conda_package_manager.py
index d1f426c657..d53155edc0 100644
--- a/marimo/_runtime/packages/conda_package_manager.py
+++ b/marimo/_runtime/packages/conda_package_manager.py
@@ -46,6 +46,7 @@ class PixiPackageManager(CondaPackageManager):
["pixi", "list", "--json"],
capture_output=True,
text=True,
+ encoding="utf-8",
check=True,
)
packages = json.loads(proc.stdout)
diff --git a/marimo/_runtime/packages/pypi_package_manager.py b/marimo/_runtime/packages/pypi_package_manager.py
index 96af6c2c96..a53ef1a537 100644
--- a/marimo/_runtime/packages/pypi_package_manager.py
+++ b/marimo/_runtime/packages/pypi_package_manager.py
@@ -39,7 +39,9 @@ class PypiPackageManager(CanonicalizingPackageManager):
) -> list[PackageDescription]:
if not self.is_manager_installed():
return []
- proc = subprocess.run(cmd, capture_output=True, text=True)
+ proc = subprocess.run(
+ cmd, capture_output=True, text=True, encoding="utf-8"
+ )
if proc.returncode != 0:
return []
try:
@@ -459,6 +461,7 @@ class UvPackageManager(PypiPackageManager):
tree_cmd,
capture_output=True,
text=True,
+ encoding="utf-8",
check=True,
)
tree = parse_uv_tree(result.stdout)
@@ -519,7 +522,9 @@ class PoetryPackageManager(PypiPackageManager):
) -> list[PackageDescription]:
if not self.is_manager_installed():
return []
- proc = subprocess.run(cmd, capture_output=True, text=True)
+ proc = subprocess.run(
+ cmd, capture_output=True, text=True, encoding="utf-8"
+ )
if proc.returncode != 0:
return []
diff --git a/tests/_runtime/packages/test_package_managers.py b/tests/_runtime/packages/test_package_managers.py
index 5436b64808..887007c70f 100644
--- a/tests/_runtime/packages/test_package_managers.py
+++ b/tests/_runtime/packages/test_package_managers.py
@@ -6,6 +6,7 @@ from unittest.mock import AsyncMock, MagicMock, patch
import pytest
+from marimo._dependencies.dependencies import DependencyManager
from marimo._runtime.packages.package_manager import LogCallback
from marimo._runtime.packages.package_managers import create_package_manager
from marimo._runtime.packages.pypi_package_manager import (
@@ -531,3 +532,59 @@ def test_package_manager_run_manager_not_installed() -> None:
# Should also return False with log callback
result = pm.run(["test", "command"], log_callback=lambda _: None)
assert result is False
+
+
+# Encoding tests for Windows compatibility
+
+
+ not DependencyManager.which("poetry"), reason="poetry not installed"
+)
+@patch("subprocess.run")
+def test_poetry_list_packages_uses_utf8_encoding(mock_run: MagicMock):
+ """Test that poetry list uses UTF-8 encoding to handle non-ASCII characters"""
+ from marimo._runtime.packages.pypi_package_manager import (
+ PoetryPackageManager,
+ )
+
+ mock_output = "package-中文 1.0.0\npакет 2.0.0\n"
+ mock_run.return_value = MagicMock(returncode=0, stdout=mock_output)
+ mgr = PoetryPackageManager()
+
+ packages = mgr.list_packages()
+
+ # Verify encoding='utf-8' is passed
+ mock_run.assert_called_once()
+ call_kwargs = mock_run.call_args[1]
+ assert call_kwargs.get("encoding") == "utf-8"
+ assert call_kwargs.get("text") is True
+
+
+ not DependencyManager.which("pixi"), reason="pixi not installed"
+)
+@patch("subprocess.run")
+def test_pixi_list_packages_uses_utf8_encoding(mock_run: MagicMock):
+ """Test that pixi list uses UTF-8 encoding to handle non-ASCII characters"""
+ import json
+
+ from marimo._runtime.packages.conda_package_manager import (
+ PixiPackageManager,
+ )
+
+ mock_output = json.dumps(
+ [
+ {"name": "package-中文", "version": "1.0.0"},
+ {"name": "пакет", "version": "2.0.0"},
+ ]
+ )
+ mock_run.return_value = MagicMock(returncode=0, stdout=mock_output)
+ mgr = PixiPackageManager()
+
+ packages = mgr.list_packages()
+
+ # Verify encoding='utf-8' is passed
+ mock_run.assert_called_once()
+ call_kwargs = mock_run.call_args[1]
+ assert call_kwargs.get("encoding") == "utf-8"
+ assert call_kwargs.get("text") is True
diff --git a/tests/_runtime/packages/test_pypi_package_manager.py b/tests/_runtime/packages/test_pypi_package_manager.py
index e63b46bf6b..5a296dbb0e 100644
--- a/tests/_runtime/packages/test_pypi_package_manager.py
+++ b/tests/_runtime/packages/test_pypi_package_manager.py
@@ -44,7 +44,8 @@ manager = PipPackageManager()
async def test_install(mock_run: MagicMock):
mock_run.return_value = MagicMock(returncode=0)
- result = await manager._install("package1 package2", upgrade=False)
+ with patch.object(manager, "is_manager_installed", return_value=True):
+ result = await manager._install("package1 package2", upgrade=False)
mock_run.assert_called_once_with(
["pip", "--python", PY_EXE, "install", "package1", "package2"],
@@ -65,7 +66,8 @@ async def test_install_failure(mock_run: MagicMock):
async def test_uninstall(mock_run: MagicMock):
mock_run.return_value = MagicMock(returncode=0)
- result = await manager.uninstall("package1 package2")
+ with patch.object(manager, "is_manager_installed", return_value=True):
+ result = await manager.uninstall("package1 package2")
mock_run.assert_called_once_with(
[
@@ -91,12 +93,14 @@ def test_list_packages(mock_run: MagicMock):
)
mock_run.return_value = MagicMock(returncode=0, stdout=mock_output)
- packages = manager.list_packages()
+ with patch.object(manager, "is_manager_installed", return_value=True):
+ packages = manager.list_packages()
mock_run.assert_called_once_with(
["pip", "--python", PY_EXE, "list", "--format=json"],
capture_output=True,
text=True,
+ encoding="utf-8",
)
assert len(packages) == 2
assert packages[0] == PackageDescription(name="package1", version="1.0.0")
@@ -310,6 +314,7 @@ def test_uv_list_packages(mock_run: MagicMock):
["uv", "pip", "list", "--format=json", "-p", PY_EXE],
capture_output=True,
text=True,
+ encoding="utf-8",
)
assert len(packages) == 2
assert packages[0] == PackageDescription(name="package1", version="1.0.0")
@@ -402,6 +407,7 @@ def test_uv_list_packages_tree_fallback_to_pip_list(
["uv", "pip", "list", "--format=json", "-p", PY_EXE],
capture_output=True,
text=True,
+ encoding="utf-8",
)
# Should return packages from fallback method
@@ -458,3 +464,64 @@ def test_uv_is_in_uv_project_uv_project_environment_mismatch():
"""Test is_in_uv_project returns False when UV_PROJECT_ENVIRONMENT doesn't match VIRTUAL_ENV"""
mgr = UvPackageManager()
assert mgr.is_in_uv_project is False
+
+
+# Encoding tests for Windows compatibility
+
+
+@patch("subprocess.run")
+def test_pip_list_packages_uses_utf8_encoding(mock_run: MagicMock):
+ """Test that pip list uses UTF-8 encoding to handle non-ASCII characters"""
+ mock_output = json.dumps(
+ [
+ {"name": "package-中文", "version": "1.0.0"},
+ {"name": "пакет", "version": "2.0.0"},
+ ]
+ )
+ mock_run.return_value = MagicMock(returncode=0, stdout=mock_output)
+ mgr = PipPackageManager()
+
+ with patch.object(mgr, "is_manager_installed", return_value=True):
+ packages = mgr.list_packages()
+
+ # Verify encoding='utf-8' is passed
+ mock_run.assert_called_once()
+ call_kwargs = mock_run.call_args[1]
+ assert call_kwargs.get("encoding") == "utf-8"
+ assert call_kwargs.get("text") is True
+
+
+@patch("subprocess.run")
+def test_uv_dependency_tree_uses_utf8_encoding(mock_run: MagicMock):
+ """Test that uv tree uses UTF-8 encoding"""
+ mock_output = "test-package v1.0.0\n"
+ mock_run.return_value = MagicMock(
+ returncode=0, stdout=mock_output, stderr=""
+ )
+ mgr = UvPackageManager()
+
+ mgr.dependency_tree(filename="test.py")
+
+ # Verify encoding='utf-8' is passed
+ mock_run.assert_called_once()
+ call_kwargs = mock_run.call_args[1]
+ assert call_kwargs.get("encoding") == "utf-8"
+ assert call_kwargs.get("text") is True
+
+
+@patch("subprocess.run")
+def test_uv_pip_list_uses_utf8_encoding(mock_run: MagicMock):
+ """Test that uv pip list uses UTF-8 encoding"""
+ mock_output = json.dumps([{"name": "test-pkg", "version": "1.0.0"}])
+ mock_run.return_value = MagicMock(returncode=0, stdout=mock_output)
+ mgr = UvPackageManager()
+
+ # Mock dependency_tree to return None so it falls back to pip list
+ with patch.object(mgr, "dependency_tree", return_value=None):
+ mgr.list_packages()
+
+ # Verify encoding='utf-8' is passed
+ mock_run.assert_called_once()
+ call_kwargs = mock_run.call_args[1]
+ assert call_kwargs.get("encoding") == "utf-8"
+ assert call_kwargs.get("text") is True