Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix: normalize dev version in static notebook asset URL (#9592)

Myles Scolnick7fb4b9b85220
diff --git a/marimo/_server/templates/templates.py b/marimo/_server/templates/templates.py
index daca9c3b62..30473bef21 100644
--- a/marimo/_server/templates/templates.py
+++ b/marimo/_server/templates/templates.py
@@ -395,7 +395,8 @@ def static_notebook_template(
asset_url: str | None = None,
) -> str:
if asset_url is None:
- asset_url = f"https://cdn.jsdelivr.net/npm/@marimo-team/frontend@{__version__}/dist"
+ version = str(__version__).replace(".dev", "-dev")
+ asset_url = f"https://cdn.jsdelivr.net/npm/@marimo-team/frontend@{version}/dist"
html = html.replace("{{ base_url }}", "")
filename = os.path.basename(filepath or "")
diff --git a/tests/_server/templates/test_templates.py b/tests/_server/templates/test_templates.py
index 1be832348f..14d65157bd 100644
--- a/tests/_server/templates/test_templates.py
+++ b/tests/_server/templates/test_templates.py
@@ -6,6 +6,7 @@ import tempfile
import unittest
from pathlib import Path
from typing import Literal
+from unittest.mock import patch
from marimo._ast.app_config import _AppConfig
from marimo._config.config import (
@@ -1115,6 +1116,56 @@ mo.md("<img src=x onerror=alert(1)>")
_assert_no_leftover_replacements(result)
+ def test_static_notebook_template_dev_version_in_asset_url(self) -> None:
+ # jsdelivr treats `.dev` as a separate path segment, so dev versions
+ # like "0.16.5.dev6+gabc" must be normalized to "0.16.5-dev6+gabc"
+ # for the CDN URL to resolve.
+ with patch.object(templates, "__version__", "0.16.5.dev6+gabc"):
+ result = templates.static_notebook_template(
+ self.html,
+ self.user_config,
+ self.config_overrides,
+ self.server_token,
+ self.app_config,
+ self.filepath,
+ self.code,
+ hash_code(self.code),
+ self.session_snapshot,
+ self.notebook_snapshot,
+ self.files,
+ )
+
+ assert (
+ "https://cdn.jsdelivr.net/npm/@marimo-team/[email protected]+gabc/dist"
+ in result
+ )
+ assert "@0.16.5.dev6" not in result
+ _assert_no_leftover_replacements(result)
+
+ def test_static_notebook_template_release_version_in_asset_url(
+ self,
+ ) -> None:
+ with patch.object(templates, "__version__", "0.16.5"):
+ result = templates.static_notebook_template(
+ self.html,
+ self.user_config,
+ self.config_overrides,
+ self.server_token,
+ self.app_config,
+ self.filepath,
+ self.code,
+ hash_code(self.code),
+ self.session_snapshot,
+ self.notebook_snapshot,
+ self.files,
+ )
+
+ assert (
+ "https://cdn.jsdelivr.net/npm/@marimo-team/[email protected]/dist"
+ in result
+ )
+ _assert_no_leftover_replacements(result)
+
class TestWasmNotebookTemplate(unittest.TestCase):
def setUp(self) -> None: