Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

Hide redundant notebook download submenu (#10607)

Akshay Agrawal81e0e61d6658
diff --git a/frontend/src/components/editor/actions/types.ts b/frontend/src/components/editor/actions/types.ts
index 74725b5773..e7dd960c25 100644
--- a/frontend/src/components/editor/actions/types.ts
+++ b/frontend/src/components/editor/actions/types.ts
@@ -45,8 +45,7 @@ export function flattenActions(
prevLabel = "",
): ActionButton[] {
return actions.flatMap((action) => {
- // If label is empty, hide
- if (!action.label) {
+ if (!action.label || action.hidden) {
return [];
}
if (isParentAction(action)) {
diff --git a/frontend/src/components/editor/actions/useNotebookActions.tsx b/frontend/src/components/editor/actions/useNotebookActions.tsx
index 81170add34..37488560b9 100644
--- a/frontend/src/components/editor/actions/useNotebookActions.tsx
+++ b/frontend/src/components/editor/actions/useNotebookActions.tsx
@@ -195,6 +195,7 @@ export function useNotebookActions({
{
icon: <DownloadIcon size={14} strokeWidth={1.5} />,
label: "Download",
+ redundant: true,
handle: NOOP_HANDLER,
dropdown: [
{
diff --git a/frontend/src/components/editor/controls/__tests__/notebook-menu-dropdown.test.tsx b/frontend/src/components/editor/controls/__tests__/notebook-menu-dropdown.test.tsx
index 5d8639614a..6976b2aa48 100644
--- a/frontend/src/components/editor/controls/__tests__/notebook-menu-dropdown.test.tsx
+++ b/frontend/src/components/editor/controls/__tests__/notebook-menu-dropdown.test.tsx
@@ -31,7 +31,9 @@ import {
exportOptionsAtom,
lastExportFormatAtom,
} from "../../actions/export-dialog/state";
+import CommandPalette from "../command-palette";
import { NotebookMenuDropdown } from "../notebook-menu-dropdown";
+import { commandPaletteAtom } from "../state";
const POSTGRES_SOURCE: DetectedDataSource = {
id: "postgres-libpq-environment",
@@ -66,6 +68,10 @@ vi.mock("@/core/wasm/utils", async (importOriginal) => {
return { ...actual, isWasm: vi.fn(() => false) };
});
+global.HTMLElement.prototype.scrollIntoView = () => {
+ // jsdom does not implement scrollIntoView; cmdk calls it on selection.
+};
+
function wrapper({ children }: { children: React.ReactNode }) {
return (
<Provider store={store}>
@@ -83,14 +89,19 @@ function openNotebookMenu() {
});
}
-async function openDownloadMenu() {
- openNotebookMenu();
- fireEvent.click(await screen.findByRole("menuitem", { name: "Download" }));
+function renderNotebookControls() {
+ return render(
+ <>
+ <NotebookMenuDropdown />
+ <CommandPalette />
+ </>,
+ { wrapper },
+ );
}
-async function selectDownload(name: string | RegExp) {
- await openDownloadMenu();
- fireEvent.click(await screen.findByRole("menuitem", { name }));
+async function selectDownloadCommand(name: string) {
+ act(() => store.set(commandPaletteAtom, true));
+ fireEvent.click(await screen.findByText(`Download > ${name}`));
}
describe("NotebookMenuDropdown", () => {
@@ -108,6 +119,7 @@ describe("NotebookMenuDropdown", () => {
});
store.set(exportOptionsAtom, DEFAULT_EXPORT_OPTIONS);
store.set(lastExportFormatAtom, "html");
+ store.set(commandPaletteAtom, false);
vi.mocked(isWasm).mockReturnValue(false);
vi.stubGlobal("PointerEvent", MouseEvent);
vi.stubGlobal("matchMedia", () => ({
@@ -203,10 +215,22 @@ describe("NotebookMenuDropdown", () => {
await waitFor(() => expect(menuButton).toHaveFocus());
});
+ it("hides the download menu but keeps its command palette actions", async () => {
+ renderNotebookControls();
+
+ openNotebookMenu();
+ expect(
+ screen.queryByRole("menuitem", { name: "Download" }),
+ ).not.toBeInTheDocument();
+
+ act(() => store.set(commandPaletteAtom, true));
+ expect(await screen.findByText("Download > Download as PNG")).toBeVisible();
+ });
+
it("opens the HTML shortcut with code excluded", async () => {
- render(<NotebookMenuDropdown />, { wrapper });
+ renderNotebookControls();
- await selectDownload("Download as HTML (exclude code)");
+ await selectDownloadCommand("Download as HTML (exclude code)");
expect(await screen.findByTestId("export-dialog")).toBeVisible();
expect(screen.getByTestId("export-format-html")).toHaveAttribute(
@@ -223,19 +247,9 @@ describe("NotebookMenuDropdown", () => {
selectedLayout: "slides",
layoutData: {},
});
- render(<NotebookMenuDropdown />, { wrapper });
+ renderNotebookControls();
- await openDownloadMenu();
- fireEvent.click(
- await screen.findByRole("menuitem", {
- name: "Download as PDF",
- }),
- );
- fireEvent.click(
- await screen.findByRole("menuitem", {
- name: /Slides Layout/,
- }),
- );
+ await selectDownloadCommand("Download as PDF > Slides Layout");
expect(await screen.findByTestId("export-dialog")).toBeVisible();
expect(screen.getByTestId("export-format-pdf")).toHaveAttribute(
@@ -251,27 +265,22 @@ describe("NotebookMenuDropdown", () => {
selectedLayout: "slides",
layoutData: {},
});
- render(<NotebookMenuDropdown />, { wrapper });
+ renderNotebookControls();
- await openDownloadMenu();
- fireEvent.click(
- await screen.findByRole("menuitem", {
- name: "Download as PDF",
- }),
- );
+ act(() => store.set(commandPaletteAtom, true));
expect(
- screen.getByRole("menuitem", { name: "Document Layout" }),
+ await screen.findByText("Download > Download as PDF > Document Layout"),
).toBeVisible();
expect(
- screen.queryByRole("menuitem", { name: /Slides Layout/ }),
+ screen.queryByText("Download > Download as PDF > Slides Layout"),
).not.toBeInTheDocument();
});
it("preselects each Python format from its download shortcut", async () => {
- render(<NotebookMenuDropdown />, { wrapper });
+ renderNotebookControls();
- await selectDownload("Download notebook source");
+ await selectDownloadCommand("Download notebook source");
expect(await screen.findByTestId("export-dialog")).toBeVisible();
expect(screen.getByTestId("export-format-script")).toHaveAttribute(
@@ -287,7 +296,7 @@ describe("NotebookMenuDropdown", () => {
expect(screen.queryByTestId("export-dialog")).not.toBeInTheDocument(),
);
- await selectDownload("Download flat script");
+ await selectDownloadCommand("Download flat script");
expect(await screen.findByTestId("export-dialog")).toBeVisible();
expect(screen.getByRole("radio", { name: "Flat script" })).toBeChecked();