A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix: update error source from 'kernel' to 'server' in handle_error function (#8714)
Myles Scolnick8dde4f486b5d
diff --git a/marimo/_server/errors.py b/marimo/_server/errors.pyindex 66a6b6398b..33f6de096c 100644--- a/marimo/_server/errors.py+++ b/marimo/_server/errors.py@@ -95,7 +95,7 @@ async def handle_error(request: Request, response: Any) -> Any:{"detail": str(response)}, status_code=500)packages = [response.name]- source = "kernel"+ source = "server"# TODO(dmadisetti): Consider checking if the server is in a virtual environment# and if so, set isolated to False.isolated = True if source == "server" else is_python_isolated()diff --git a/tests/_server/test_errors.py b/tests/_server/test_errors.pyindex 98c383a90a..0e8d6fd189 100644--- a/tests/_server/test_errors.py+++ b/tests/_server/test_errors.py@@ -383,6 +383,40 @@ async def test_http_exception_various_status_codes(assert response.body == f'{{"detail":"{detail}"}}'.encode()+async def test_module_not_found_error_source_is_server():+ """ModuleNotFoundError should use source='server' and isolated=True"""+ mock_app_state = MagicMock()+ mock_app_state.mode = SessionMode.EDIT+ mock_app_state.get_current_session_id.return_value = "test_session"+ mock_app_state.get_current_session.return_value = MagicMock()++ with (+ patch("marimo._server.errors.AppState", return_value=mock_app_state),+ patch(+ "marimo._server.errors.send_message_to_consumer"+ ) as mock_send_message,+ # is_python_isolated should NOT be consulted for server-sourced errors+ patch(+ "marimo._server.errors.is_python_isolated", return_value=False+ ) as mock_is_isolated,+ ):+ exc = ModuleNotFoundError(+ "No module named 'missing_package'", name="missing_package"+ )+ response = await handle_error(Request({"type": "http"}), exc)++ assert response.status_code == 500+ mock_send_message.assert_called_once()+ call_args = mock_send_message.call_args+ notification = call_args.kwargs["operation"]+ assert notification.packages == ["missing_package"]+ assert notification.source == "server"+ # Server-sourced errors are always isolated+ assert notification.isolated is True+ # is_python_isolated should not be called when source is "server"+ mock_is_isolated.assert_not_called()++async def test_appstate_initialization_failure():"""Test graceful handling when AppState initialization fails"""with patch(