A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix(download): trigger downloads programmatically to work inside cross-origin iframes (#9649)
Myles Scolnick8f99cc77d881
diff --git a/frontend/src/plugins/layout/DownloadPlugin.tsx b/frontend/src/plugins/layout/DownloadPlugin.tsxindex 5f1747a174..2e585e719c 100644--- a/frontend/src/plugins/layout/DownloadPlugin.tsx+++ b/frontend/src/plugins/layout/DownloadPlugin.tsx@@ -80,22 +80,26 @@ const DownloadButton = ({const [isLoading, setIsLoading] = useState(false);const handleClick = async (e: React.MouseEvent) => {- if (!data.lazy) {+ if (data.disabled) {+ e.preventDefault();+ e.stopPropagation();return;}- if (data.disabled) {+ e.preventDefault();++ if (!data.lazy) {+ downloadByURL(data.data, data.filename ?? undefined);return;}- e.preventDefault();setIsLoading(true);try {const loadedData = await load({});downloadByURL(loadedData.data,- loadedData.filename || data.filename || "download",+ loadedData.filename ?? data.filename ?? undefined,);} catch (error) {toast({@@ -114,9 +118,7 @@ const DownloadButton = ({return (<ahref={data.data}- download={data.filename || true}- target="_blank"- rel="noopener noreferrer"+ download={data.filename ?? ""}onClick={handleClick}className={buttonVariants({variant: "secondary",diff --git a/frontend/src/utils/download.ts b/frontend/src/utils/download.tsindex c232b9948b..7aeb7fd8cf 100644--- a/frontend/src/utils/download.ts+++ b/frontend/src/utils/download.ts@@ -175,10 +175,12 @@ export async function downloadHTMLAsImage(opts: {}}-export function downloadByURL(url: string, filename: string) {+export function downloadByURL(url: string, filename?: string) {const a = document.createElement("a");a.href = url;- a.download = filename;+ if (filename) {+ a.download = filename;+ }a.click();a.remove();}