Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix(audio): resolve Safari audio controls blur in scroll containers (… (#11216)

Rajveer Singh9f313fccf324
diff --git a/frontend/e2e-tests/output.spec.ts b/frontend/e2e-tests/output.spec.ts
index 23f6bc3682..4cb1c0444a 100644
--- a/frontend/e2e-tests/output.spec.ts
+++ b/frontend/e2e-tests/output.spec.ts
@@ -32,3 +32,43 @@ test("it can clear and append output", async ({ page }) => {
await takeScreenshot(page, _filename);
});
+
+test("audio output respects narrow containers and explicit width", async ({
+ page,
+}) => {
+ const appUrl = getAppUrl("output.py//run");
+ await page.goto(appUrl);
+
+ const dimensions = await page.evaluate(() => {
+ const container = document.createElement("div");
+ container.className = "output";
+ container.style.width = "200px";
+
+ const explicitAudio = document.createElement("audio");
+ explicitAudio.controls = true;
+ explicitAudio.style.width = "150px";
+
+ const unstyledAudio = document.createElement("audio");
+ unstyledAudio.controls = true;
+
+ container.appendChild(explicitAudio);
+ container.appendChild(unstyledAudio);
+ document.body.appendChild(container);
+
+ const explicitRect = explicitAudio.getBoundingClientRect();
+ const unstyledRect = unstyledAudio.getBoundingClientRect();
+ const containerRect = container.getBoundingClientRect();
+
+ container.remove();
+ return {
+ explicitWidth: explicitRect.width,
+ unstyledWidth: unstyledRect.width,
+ containerWidth: containerRect.width,
+ };
+ });
+
+ // Explicit width below 280px is respected and does not force min-width: 280px
+ expect(dimensions.explicitWidth).toBe(150);
+ // Unstyled audio inside narrow container is constrained and does not overflow
+ expect(dimensions.unstyledWidth).toBeLessThanOrEqual(dimensions.containerWidth);
+});
diff --git a/frontend/src/components/editor/output/Outputs.css b/frontend/src/components/editor/output/Outputs.css
index 6a46767eac..48beac62ae 100644
--- a/frontend/src/components/editor/output/Outputs.css
+++ b/frontend/src/components/editor/output/Outputs.css
@@ -24,6 +24,14 @@
max-width: 100%;
}
+.output audio,
+.output-area audio,
+.media audio {
+ width: 100%;
+ max-width: 100%;
+ transform: translateZ(0);
+}
+
.output {
position: relative;
diff --git a/frontend/src/css/globals.css b/frontend/src/css/globals.css
index 1399618eea..258fd03691 100644
--- a/frontend/src/css/globals.css
+++ b/frontend/src/css/globals.css
@@ -206,6 +206,11 @@
[role="button"]:not(:disabled) {
cursor: pointer;
}
+
+ audio {
+ max-width: 100%;
+ transform: translateZ(0);
+ }
}
@theme {
diff --git a/marimo/_output/builder.py b/marimo/_output/builder.py
index 354f65c461..6033b63f93 100644
--- a/marimo/_output/builder.py
+++ b/marimo/_output/builder.py
@@ -74,12 +74,15 @@ class _HTMLBuilder:
*,
src: str | None = None,
controls: bool = True,
+ style: str | None = None,
) -> str:
params: list[tuple[str, str | None]] = []
if src:
params.append(("src", src))
if controls:
params.append(("controls", ""))
+ if style:
+ params.append(("style", style))
if len(params) == 0:
return "<audio></audio>"
diff --git a/marimo/_plugins/stateless/audio.py b/marimo/_plugins/stateless/audio.py
index d0f32c51fd..c79ef84de6 100644
--- a/marimo/_plugins/stateless/audio.py
+++ b/marimo/_plugins/stateless/audio.py
@@ -12,6 +12,7 @@ from marimo._dependencies.dependencies import DependencyManager
from marimo._output.builder import h
from marimo._output.hypertext import Html
from marimo._output.rich_help import mddoc
+from marimo._output.utils import create_style, normalize_dimension
from marimo._plugins.core.media import io_to_data_url
if TYPE_CHECKING:
@@ -105,6 +106,9 @@ def audio(
src: str | bytes | io.BytesIO | io.BufferedReader | Path | NDArray[Any],
rate: int | None = None,
normalize: bool = True,
+ *,
+ width: int | str | None = None,
+ style: dict[str, Any] | None = None,
) -> Html:
"""Render an audio file as HTML.
@@ -118,6 +122,8 @@ def audio(
normalize: Whether to rescale NumPy array audio to its max range (`True` by default).
If `False`, values must be in `[-1, 1]`, or an error is raised.
Does not apply to non-array audio sources.
+ width: Optional width of the audio element (e.g. `300` or `"100%"`).
+ style: Optional dictionary of CSS styles to apply to the audio element.
Returns:
An audio player as an `Html` object.
@@ -132,4 +138,13 @@ def audio(
```
"""
resolved_src = get_resolved_src(src, rate, normalize)
- return Html(h.audio(src=resolved_src, controls=True))
+ styles = (
+ create_style(
+ {
+ "width": normalize_dimension(width),
+ **(style or {}),
+ }
+ )
+ or None
+ )
+ return Html(h.audio(src=resolved_src, controls=True, style=styles))
diff --git a/tests/_plugins/stateless/test_audio.py b/tests/_plugins/stateless/test_audio.py
index 7ef2d493a7..9d27e46606 100644
--- a/tests/_plugins/stateless/test_audio.py
+++ b/tests/_plugins/stateless/test_audio.py
@@ -320,3 +320,23 @@ async def test_audio_local_file(k: Kernel, exec_req: ExecReqProvider) -> None:
]
)
assert len(get_context().virtual_file_registry.registry) == 1
+
+
+async def test_audio_width() -> None:
+ result = audio("https://example.com/test.wav", width=300)
+ assert (
+ result.text
+ == "<audio src='https://example.com/test.wav' controls style='width: 300px'></audio>"
+ )
+
+
+async def test_audio_style() -> None:
+ result = audio(
+ "https://example.com/test.wav",
+ width="100%",
+ style={"margin-top": "10px"},
+ )
+ assert (
+ result.text
+ == "<audio src='https://example.com/test.wav' controls style='width: 100%;margin-top: 10px'></audio>"
+ )