Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

remove unecesary comments, code style changes (#9842)

Shahmir Varqhaa67b27890384
diff --git a/frontend/src/components/editor/file-tree/tree-actions.tsx b/frontend/src/components/editor/file-tree/tree-actions.tsx
index dbbbcb6c7b..d37a1b778a 100644
--- a/frontend/src/components/editor/file-tree/tree-actions.tsx
+++ b/frontend/src/components/editor/file-tree/tree-actions.tsx
@@ -84,9 +84,7 @@ export const VisibilityToggleButton: React.FC<{
/** Whether the optional items are currently visible. */
isVisible: boolean;
onToggle: () => void;
- /** Tooltip shown while items are hidden (clicking will show them). */
showTooltip: string;
- /** Tooltip shown while items are visible (clicking will hide them). */
hideTooltip: string;
size?: ButtonProps["size"];
className?: string;
diff --git a/frontend/src/components/storage/__tests__/storage-inspector.test.ts b/frontend/src/components/storage/__tests__/storage-inspector.test.ts
index 0749733674..32c04ec897 100644
--- a/frontend/src/components/storage/__tests__/storage-inspector.test.ts
+++ b/frontend/src/components/storage/__tests__/storage-inspector.test.ts
@@ -1,9 +1,7 @@
/* Copyright 2026 Marimo. All rights reserved. */
import { describe, expect, it } from "vitest";
import type { StorageEntry } from "@/core/storage/types";
-import { exportedForTesting } from "../storage-inspector";
-
-const { storageEntryKey } = exportedForTesting;
+import { storageEntryKey } from "../storage-inspector";
function makeEntry(
overrides: Partial<StorageEntry> & { path: string },
diff --git a/frontend/src/components/storage/storage-inspector.tsx b/frontend/src/components/storage/storage-inspector.tsx
index baaee53599..c40ccd04e1 100644
--- a/frontend/src/components/storage/storage-inspector.tsx
+++ b/frontend/src/components/storage/storage-inspector.tsx
@@ -98,7 +98,7 @@ function displayName(path: string): string {
* Stable, unique identity for an entry row. Prefer the
* backend's stable id when present and fall back to the list index
*/
-function storageEntryKey(entry: StorageEntry, index: number): string {
+export function storageEntryKey(entry: StorageEntry, index: number): string {
const id = entry.metadata?.id;
if (typeof id === "string" && id.length > 0) {
return id;
@@ -106,15 +106,19 @@ function storageEntryKey(entry: StorageEntry, index: number): string {
return `${entry.path}::${index}`;
}
+interface SearchContext {
+ namespace: string;
+ searchValue: string;
+ entriesByPath: ReadonlyMap<StoragePathKey, StorageEntry[]>;
+}
+
/**
* Recursively check whether an entry (or any of its loaded descendants)
* matches the search query.
*/
function entryMatchesSearch(
entry: StorageEntry,
- namespace: string,
- searchValue: string,
- entriesByPath: ReadonlyMap<StoragePathKey, StorageEntry[]>,
+ { namespace, searchValue, entriesByPath }: SearchContext,
): boolean {
const query = searchValue.toLowerCase();
@@ -127,7 +131,7 @@ function entryMatchesSearch(
const children = entriesByPath.get(storagePathKey(namespace, entry.path));
if (children) {
return children.some((child) =>
- entryMatchesSearch(child, namespace, searchValue, entriesByPath),
+ entryMatchesSearch(child, { namespace, searchValue, entriesByPath }),
);
}
}
@@ -141,16 +145,12 @@ function entryMatchesSearch(
*/
function filterEntries(
entries: StorageEntry[],
- namespace: string,
- searchValue: string,
- entriesByPath: ReadonlyMap<StoragePathKey, StorageEntry[]>,
+ context: SearchContext,
): StorageEntry[] {
- if (!searchValue.trim()) {
+ if (!context.searchValue.trim()) {
return entries;
}
- return entries.filter((entry) =>
- entryMatchesSearch(entry, namespace, searchValue, entriesByPath),
- );
+ return entries.filter((entry) => entryMatchesSearch(entry, context));
}
/**
@@ -216,12 +216,11 @@ const StorageEntryChildren: React.FC<{
);
}
- const filtered = filterEntries(
- children,
+ const filtered = filterEntries(children, {
namespace,
searchValue,
entriesByPath,
- );
+ });
return (
<>
@@ -289,7 +288,7 @@ const StorageEntryRow: React.FC<{
!!entriesByPath
.get(storagePathKey(namespace, entry.path))
?.some((child) =>
- entryMatchesSearch(child, namespace, searchValue, entriesByPath),
+ entryMatchesSearch(child, { namespace, searchValue, entriesByPath }),
);
// Folder is shown expanded by manual toggle OR by search auto-expand
@@ -476,12 +475,11 @@ const StorageNamespaceSection: React.FC<{
// While loading, fall back to initial entries from the namespace notification
const entries = isPending ? namespace.storageEntries : fetchedEntries;
- const filtered = filterEntries(
- entries,
- namespaceName,
+ const filtered = filterEntries(entries, {
+ namespace: namespaceName,
searchValue,
entriesByPath,
- );
+ });
return (
<>
@@ -674,7 +672,3 @@ export const StorageInspector: React.FC = () => {
</div>
);
};
-
-export const exportedForTesting = {
- storageEntryKey,
-};