A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix: center slides better for iframed content (#6465)
Myles Scolnickab06c4715feb
diff --git a/frontend/src/components/editor/renderers/slides-layout/slides-layout.tsx b/frontend/src/components/editor/renderers/slides-layout/slides-layout.tsxindex 0bee1a3e34..07a461fc0c 100644--- a/frontend/src/components/editor/renderers/slides-layout/slides-layout.tsx+++ b/frontend/src/components/editor/renderers/slides-layout/slides-layout.tsx@@ -24,7 +24,7 @@ export const SlidesLayoutRenderer: React.FC<Props> = ({const isReading = mode === "read";const slides = (- <LazySlidesComponent forceKeyboardNavigation={true}>+ <LazySlidesComponent forceKeyboardNavigation={true} className="flex-1">{cells.map((cell) => {const isOutputEmpty = cell.output == null || cell.output.data === "";if (isOutputEmpty) {@@ -45,10 +45,10 @@ export const SlidesLayoutRenderer: React.FC<Props> = ({);if (isReading) {- return <div className="p-4">{slides}</div>;+ return <div className="p-4 flex flex-col flex-1 max-h-[95%]">{slides}</div>;}- return <div className="pr-9">{slides}</div>;+ return <div className="pr-18 pb-5 flex-1 flex flex-col">{slides}</div>;};interface SlideProps extends Pick<CellRuntimeState, "output" | "status"> {diff --git a/frontend/src/components/slides/slides-component.tsx b/frontend/src/components/slides/slides-component.tsxindex a74c4dd9f4..79ebec4c54 100644--- a/frontend/src/components/slides/slides-component.tsx+++ b/frontend/src/components/slides/slides-component.tsx@@ -95,7 +95,7 @@ const SlidesComponent = ({}}className={cn("h-full w-full flex box-border overflow-y-auto overflow-x-hidden",- isFullscreen ? "p-20" : "p-6",+ isFullscreen ? "p-20" : "p-6 pb-12",)}><div className="mo-slide-content">{child}</div>diff --git a/frontend/src/components/slides/slides.css b/frontend/src/components/slides/slides.cssindex 87deb96dcc..76a9828759 100644--- a/frontend/src/components/slides/slides.css+++ b/frontend/src/components/slides/slides.css@@ -68,6 +68,7 @@ so we are resetting this back to initial. */width: 100%;display: flex;justify-content: center;+ min-height: fit-content;/* width is normally set to 100%, but we want the content to be centered aroundthe width needed. */@@ -79,6 +80,11 @@ so we are resetting this back to initial. */width: unset;}+ /* If the first output is the only child, make it flex 1 */+ > *:only-child > .output:only-child {+ flex: 1;+ }+/* Components that should be full width when in slides mode */div:has(> marimo-ui-element > marimo-vega) {display: block !important;diff --git a/marimo/_smoke_tests/slides_examples/centered_slides.py b/marimo/_smoke_tests/slides_examples/centered_slides.pynew file mode 100644index 0000000000..6c3556faa1--- /dev/null+++ b/marimo/_smoke_tests/slides_examples/centered_slides.py@@ -0,0 +1,71 @@+import marimo++__generated_with = "0.16.0"+app = marimo.App(+ width="medium",+ layout_file="layouts/centered_slides.slides.json",+)+++def _():+ import marimo as mo++ mo.iframe("https://marimo.io/")+ return (mo,)+++def _(mo):+ mo.iframe("https://marimo.io/", height="600px")+ return+++def _(mo):+ mo.hstack(+ [mo.iframe("https://marimo.io/"), mo.iframe("https://marimo.io/")],+ widths="equal",+ )+ return+++def _(mo):+ mo.vstack([mo.iframe("https://marimo.io/"), mo.iframe("https://marimo.io/")])+ return+++def _():+ import altair as alt+ import polars as pl++ df = pl.read_parquet(+ "https://github.com/uwdata/mosaic/raw/main/data/athletes.parquet"+ )+ df++ df.plot.bar("sport", "count()", color="sex").properties(height=400)+ return+++def _(mo):+ import plotly.express as px++ _df = px.data.gapminder().query("country=='Germany'")+ fig = px.line(_df, x="year", y="lifeExp", title="Life expectancy in Germany")++ mo.ui.plotly(fig)+ return (fig,)+++def _(fig, mo):+ mo.vstack([mo.md("## Chart with a title"), mo.ui.plotly(fig)])+ return+++if __name__ == "__main__":+ app.run()diff --git a/marimo/_smoke_tests/slides_examples/layouts/centered_slides.slides.json b/marimo/_smoke_tests/slides_examples/layouts/centered_slides.slides.jsonnew file mode 100644index 0000000000..af4970a3d7--- /dev/null+++ b/marimo/_smoke_tests/slides_examples/layouts/centered_slides.slides.json@@ -0,0 +1,4 @@+{+ "type": "slides",+ "data": {}+}\ No newline at end of file