A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix(charts): respect user-configured marimo data transformer (#9887)
Myles Scolnickadb46236091e
diff --git a/marimo/_plugins/ui/_impl/altair_chart.py b/marimo/_plugins/ui/_impl/altair_chart.pyindex 5e9af95ded..af627ae1c6 100644--- a/marimo/_plugins/ui/_impl/altair_chart.py+++ b/marimo/_plugins/ui/_impl/altair_chart.py@@ -460,6 +460,13 @@ def _parse_spec(spec: altair.TopLevelMixin) -> VegaSpec:with alt.data_transformers.enable("default"):return spec.to_dict() # type: ignore+ # Respect a user-configured marimo transformer (e.g. marimo_csv,+ # marimo_json) — all marimo transformers produce frontend-renderable+ # output. Non-marimo transformers may not be supported by our frontend,+ # so we default to marimo_arrow.+ if alt.data_transformers.active.startswith("marimo"):+ return spec.to_dict(validate=False) # type: ignore+with alt.data_transformers.enable("marimo_arrow"):return spec.to_dict(validate=False) # type: ignorediff --git a/tests/_plugins/ui/_impl/test_altair_chart.py b/tests/_plugins/ui/_impl/test_altair_chart.pyindex 9cc42be6ef..e1b774ee02 100644--- a/tests/_plugins/ui/_impl/test_altair_chart.py+++ b/tests/_plugins/ui/_impl/test_altair_chart.py@@ -842,6 +842,61 @@ def test_parse_spec_polars() -> None:snapshot("parse_spec_polars.txt", json.dumps(spec, indent=2))[email protected](not HAS_DEPS, reason="optional dependencies not installed")+ ("transformer", "expected_format"),+ [+ ("marimo_csv", "csv"),+ ("marimo_json", "json"),+ ("marimo_arrow", "arrow"),+ ("marimo", "csv"),+ ],+)+def test_parse_spec_respects_active_marimo_transformer(+ transformer: str, expected_format: str+) -> None:+ import altair as alt+ import pandas as pd++ from marimo._plugins.ui._impl.charts.altair_transformer import (+ register_transformers,+ )++ register_transformers()+ previous = alt.data_transformers.active+ try:+ alt.data_transformers.enable(transformer)+ data = pd.DataFrame({"values": [1, 2, 3]})+ chart = alt.Chart(data).mark_point().encode(x="values:Q")+ spec = _parse_spec(chart)+ assert spec["data"]["format"]["type"] == expected_format+ finally:+ alt.data_transformers.enable(previous)++[email protected](not HAS_DEPS, reason="optional dependencies not installed")+def test_parse_spec_defaults_to_arrow() -> None:+ import altair as alt+ import pandas as pd++ from marimo._plugins.ui._impl.charts.altair_transformer import (+ register_transformers,+ )++ register_transformers()+ previous = alt.data_transformers.active+ try:+ # A non-marimo transformer should not be respected; we default to+ # marimo_arrow so the frontend can render the chart.+ alt.data_transformers.enable("default")+ data = pd.DataFrame({"values": [1, 2, 3]})+ chart = alt.Chart(data).mark_point().encode(x="values:Q")+ spec = _parse_spec(chart)+ assert spec["data"]["format"]["type"] == "arrow"+ finally:+ alt.data_transformers.enable(previous)++@pytest.mark.skipif(not HAS_DEPS or not DependencyManager.duckdb.has(),reason="optional dependencies not installed",