Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

Always collapse runtime settings into a single dropdown (#7461)

Trevor Manzb3abd35ea2f6
diff --git a/frontend/src/components/editor/chrome/wrapper/footer-items/runtime-settings.tsx b/frontend/src/components/editor/chrome/wrapper/footer-items/runtime-settings.tsx
index b4928b84aa..fa39d7f969 100644
--- a/frontend/src/components/editor/chrome/wrapper/footer-items/runtime-settings.tsx
+++ b/frontend/src/components/editor/chrome/wrapper/footer-items/runtime-settings.tsx
@@ -7,12 +7,10 @@ import {
ZapOffIcon,
} from "lucide-react";
import type React from "react";
-import { useEffect, useState } from "react";
import { DisableIfOverridden } from "@/components/app-config/is-overridden";
import {
DropdownMenu,
DropdownMenuContent,
- DropdownMenuItem,
DropdownMenuLabel,
DropdownMenuSeparator,
DropdownMenuTrigger,
@@ -33,22 +31,6 @@ export const RuntimeSettings: React.FC<RuntimeSettingsProps> = ({
}) => {
const { saveUserConfig } = useRequestClient();
const [config, setUserConfig] = useResolvedMarimoConfig();
- const [dropdownOpen, setDropdownOpen] = useState(false);
-
- // Close dropdown when screen size crosses the md breakpoint
- useEffect(() => {
- // 768px matches Tailwind's 'md' breakpoint used in hidden md:flex
- // TODO: When upgrading to Tailwind v4, use var(--breakpoint-md)
- const mediaQuery = window.matchMedia("(min-width: 768px)");
- const handleChange = () => {
- if (mediaQuery.matches) {
- setDropdownOpen(false);
- }
- };
-
- mediaQuery.addEventListener("change", handleChange);
- return () => mediaQuery.removeEventListener("change", handleChange);
- }, []);
const handleStartupToggle = async (checked: boolean) => {
// Send only the changed portion to avoid overwriting other config values
@@ -100,130 +82,8 @@ export const RuntimeSettings: React.FC<RuntimeSettingsProps> = ({
return (
<div className={cn("flex items-center", className)}>
- {/* Shown on larger screens */}
- <div className="hidden md:flex md:items-center">
- <DisableIfOverridden name="runtime.auto_instantiate">
- <FooterItem
- tooltip={
- config.runtime.auto_instantiate
- ? "Disable autorun on startup"
- : "Enable autorun on startup"
- }
- selected={false}
- onClick={() =>
- handleStartupToggle(!config.runtime.auto_instantiate)
- }
- data-testid="footer-autorun-startup"
- >
- <div className="font-prose text-sm flex items-center gap-1 whitespace-nowrap">
- <span>on startup: </span>
- {config.runtime.auto_instantiate ? (
- <ZapIcon size={14} />
- ) : (
- <ZapOffIcon size={14} />
- )}
- <span>
- {config.runtime.auto_instantiate ? "autorun" : "lazy"}
- </span>
- </div>
- </FooterItem>
- </DisableIfOverridden>
-
- <div className="border-r border-border h-6 mx-1" />
-
- <DisableIfOverridden name="runtime.on_cell_change">
- <FooterItem
- tooltip={
- config.runtime.on_cell_change === "autorun"
- ? "Disable autorun"
- : "Enable autorun"
- }
- selected={false}
- onClick={() =>
- handleCellChangeToggle(
- config.runtime.on_cell_change !== "autorun",
- )
- }
- data-testid="footer-autorun-cell-change"
- >
- <div className="font-prose text-sm flex items-center gap-1 whitespace-nowrap">
- <span>on cell change: </span>
- {config.runtime.on_cell_change === "autorun" ? (
- <ZapIcon size={14} />
- ) : (
- <ZapOffIcon size={14} />
- )}
- <span>{config.runtime.on_cell_change}</span>
- </div>
- </FooterItem>
- </DisableIfOverridden>
-
- {!isWasm() && (
- <>
- <div className="border-r border-border h-6 mx-1" />
- <DisableIfOverridden name="runtime.auto_reload">
- <FooterItem
- tooltip={null}
- selected={false}
- data-testid="footer-module-reload"
- >
- <DropdownMenu>
- <DropdownMenuTrigger className="font-prose text-sm flex items-center gap-1 whitespace-nowrap">
- <span>on module change: </span>
- {config.runtime.auto_reload === "off" && (
- <PowerOffIcon size={14} />
- )}
- {config.runtime.auto_reload === "lazy" && (
- <ZapOffIcon size={14} />
- )}
- {config.runtime.auto_reload === "autorun" && (
- <ZapIcon size={14} />
- )}
- <span>{config.runtime.auto_reload}</span>
- <ChevronDownIcon size={14} />
- </DropdownMenuTrigger>
- <DropdownMenuContent>
- {["off", "lazy", "autorun"].map((option) => (
- <DropdownMenuItem
- key={option}
- onClick={() =>
- handleModuleReloadChange(
- option as "off" | "lazy" | "autorun",
- )
- }
- >
- {option === "off" && (
- <PowerOffIcon
- size={14}
- className="mr-2 text-muted-foreground"
- />
- )}
- {option === "lazy" && (
- <ZapOffIcon
- size={14}
- className="mr-2 text-muted-foreground"
- />
- )}
- {option === "autorun" && (
- <ZapIcon
- size={14}
- className="mr-2 text-muted-foreground"
- />
- )}
- {option}
- </DropdownMenuItem>
- ))}
- </DropdownMenuContent>
- </DropdownMenu>
- </FooterItem>
- </DisableIfOverridden>
- </>
- )}
- </div>
-
- {/* Shown on small screens */}
- <div className="flex md:hidden">
- <DropdownMenu open={dropdownOpen} onOpenChange={setDropdownOpen}>
+ <div className="flex">
+ <DropdownMenu>
<DropdownMenuTrigger asChild={true}>
<FooterItem
tooltip="Runtime reactivity"