Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix: restore retina rendering for matplotlib figures (#10246)

Kiran Gadhaveb54c5b09f8e3
diff --git a/marimo/_output/mpl.py b/marimo/_output/mpl.py
index d186d19e99..4a488f9044 100644
--- a/marimo/_output/mpl.py
+++ b/marimo/_output/mpl.py
@@ -83,8 +83,10 @@ def _render_figure_mimebundle(
data_url = build_data_url(mimetype="image/svg+xml", data=plot_bytes)
return "image/svg+xml", data_url
- dpi = fig.figure.dpi
- fig.figure.savefig(buf, format="png", bbox_inches="tight", dpi=dpi) # type: ignore[attr-defined]
+ render_dpi = fig.figure.dpi * 2
+ fig.figure.savefig( # type: ignore[attr-defined]
+ buf, format="png", bbox_inches="tight", dpi=render_dpi
+ )
png_bytes = buf.getvalue()
plot_bytes = base64.b64encode(png_bytes)
@@ -97,13 +99,13 @@ def _render_figure_mimebundle(
width, height = _extract_png_dimensions(png_bytes)
# Normalize to a fixed 100 DPI reference for consistent display size
# https://matplotlib.org/stable/api/_as_gen/matplotlib.figure.Figure.html
- factor = dpi / 100
+ display_factor = render_dpi / 100
mimebundle = {
"image/png": data_url,
METADATA_KEY: {
"image/png": {
- "width": round(width / factor),
- "height": round(height / factor),
+ "width": round(width / display_factor),
+ "height": round(height / display_factor),
}
},
}
diff --git a/tests/_output/formatters/test_matplotlib.py b/tests/_output/formatters/test_matplotlib.py
index 9c506fe37c..6f3aef8071 100644
--- a/tests/_output/formatters/test_matplotlib.py
+++ b/tests/_output/formatters/test_matplotlib.py
@@ -85,12 +85,12 @@ def _extract_png_dimensions(data_url: str) -> tuple[int, int]:
@pytest.mark.skipif(not HAS_MPL, reason="optional dependencies not installed")
@pytest.mark.parametrize("dpi", [72, 300])
-async def test_matplotlib_image_resolution_respects_dpi(
+async def test_matplotlib_image_resolution_uses_retina_scale(
executing_kernel: Kernel,
exec_req: ExecReqProvider,
dpi: int,
) -> None:
- """Test that the actual image resolution (pixels) scales with DPI."""
+ """Test that PNG output uses retina scaling without mutating DPI."""
from marimo._output.formatters.formatters import register_formatters
register_formatters(theme="light")
@@ -103,9 +103,11 @@ async def test_matplotlib_image_resolution_respects_dpi(
# Create an empty figure (no content) to isolate DPI effects
fig = plt.figure(figsize=(4, 3), dpi={dpi})
+ original_dpi = fig.dpi
# Get the formatted output
result = fig._mime_()
+ rendered_dpi = fig.dpi
"""
)
]
@@ -128,11 +130,14 @@ async def test_matplotlib_image_resolution_respects_dpi(
# https://matplotlib.org/stable/api/_as_gen/matplotlib.figure.Figure.savefig.html
pad_inches = 0.1
- calc_width = round((4 + 2 * pad_inches) * dpi)
- calc_height = round((3 + 2 * pad_inches) * dpi)
+ render_dpi = dpi * 2
+ calc_width = round((4 + 2 * pad_inches) * render_dpi)
+ calc_height = round((3 + 2 * pad_inches) * render_dpi)
assert calc_width - 5 < width < calc_width + 5
assert calc_height - 5 < height < calc_height + 5
+ assert executing_kernel.globals["original_dpi"] == dpi
+ assert executing_kernel.globals["rendered_dpi"] == dpi
# Verify aspect ratio is preserved (4:3 ratio)
aspect_ratio = width / height