Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

add no-print and debug logs for export to pdf (#8031)

Shahmir Varqhab79a3cb5ea4b
diff --git a/frontend/src/components/data-table/TableActions.tsx b/frontend/src/components/data-table/TableActions.tsx
index 6b60ce5d19..436e05bd6a 100644
--- a/frontend/src/components/data-table/TableActions.tsx
+++ b/frontend/src/components/data-table/TableActions.tsx
@@ -107,7 +107,7 @@ export const TableActions = <TData,>({
};
return (
- <div className="flex items-center shrink-0 pt-1">
+ <div className="flex items-center shrink-0 pt-1 no-print">
{onSearchQueryChange && enableSearch && (
<Tooltip content="Search">
<Button
diff --git a/frontend/src/utils/download.ts b/frontend/src/utils/download.ts
index 612e2c4ae8..bbec2c7bfa 100644
--- a/frontend/src/utils/download.ts
+++ b/frontend/src/utils/download.ts
@@ -94,6 +94,8 @@ function prepareCellElementForScreenshot(
};
}
+const THRESHOLD_TIME_MS = 500;
+
/**
* Capture a cell output as a PNG data URL.
*
@@ -119,7 +121,17 @@ export async function getImageDataUrlForCell(
const cleanup = prepareCellElementForScreenshot(element, enablePrintMode);
try {
- return await toPng(element);
+ const startTime = Date.now();
+ const dataUrl = await toPng(element);
+ const timeTaken = Date.now() - startTime;
+ if (timeTaken > THRESHOLD_TIME_MS) {
+ Logger.debug(
+ "toPng operation for element",
+ element,
+ `took ${timeTaken} ms (exceeds threshold)`,
+ );
+ }
+ return dataUrl;
} finally {
cleanup();
}
diff --git a/frontend/src/utils/html-to-image.ts b/frontend/src/utils/html-to-image.ts
index 2911102092..8f57df6601 100644
--- a/frontend/src/utils/html-to-image.ts
+++ b/frontend/src/utils/html-to-image.ts
@@ -13,7 +13,13 @@ export const defaultHtmlToImageOptions: HtmlToImageOptions = {
try {
if ("classList" in node) {
// Filter out matplotlib toolbars
- return !node.classList.contains("mpl-toolbar");
+ if (node.classList.contains("mpl-toolbar")) {
+ return false;
+ }
+
+ if (node.classList.contains("no-print")) {
+ return false;
+ }
}
return true;
} catch (error) {
@@ -30,7 +36,7 @@ export const defaultHtmlToImageOptions: HtmlToImageOptions = {
* Convert an HTML element to a PNG data URL.
* This is a wrapper around html-to-image's toPng with default options applied.
*/
-export function toPng(
+export async function toPng(
element: HTMLElement,
options?: HtmlToImageOptions,
): Promise<string> {