Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix(datasources): correct fully-qualified table name in column previews (#9954)

Shahmir Varqhab98993282779
diff --git a/frontend/src/components/datasources/__tests__/column-preview.test.tsx b/frontend/src/components/datasources/__tests__/column-preview.test.tsx
new file mode 100644
index 0000000000..16d62871c6
--- /dev/null
+++ b/frontend/src/components/datasources/__tests__/column-preview.test.tsx
@@ -0,0 +1,97 @@
+/* Copyright 2026 Marimo. All rights reserved. */
+
+import { render } from "@testing-library/react";
+import { Provider } from "jotai";
+import type React from "react";
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import { MockRequestClient } from "@/__mocks__/requests";
+import type { SQLTableContext } from "@/core/datasets/data-source-connections";
+import type { DataTable, DataTableColumn } from "@/core/kernel/messages";
+import { requestClientAtom } from "@/core/network/requests";
+import { store } from "@/core/state/jotai";
+import { DatasetColumnPreview } from "../column-preview";
+
+const wrapper = ({ children }: { children: React.ReactNode }) => (
+ <Provider store={store}>{children}</Provider>
+);
+
+const table: DataTable = {
+ name: "users",
+ columns: [],
+ source: "my_engine",
+ // Not "connection"/"catalog", so a preview is requested on mount.
+ source_type: "duckdb",
+ type: "table",
+ engine: "my_engine" as DataTable["engine"],
+ indexes: null,
+ num_columns: null,
+ num_rows: null,
+ variable_name: null,
+ primary_keys: null,
+};
+
+const column = { name: "email" } as DataTableColumn;
+
+function renderPreview(sqlTableContext?: SQLTableContext) {
+ const client = MockRequestClient.create();
+ store.set(requestClientAtom, client);
+ render(
+ <DatasetColumnPreview
+ table={table}
+ column={column}
+ preview={undefined}
+ onAddColumnChart={vi.fn()}
+ sqlTableContext={sqlTableContext}
+ />,
+ { wrapper },
+ );
+ return client;
+}
+
+const ctx = (
+ overrides: Partial<SQLTableContext> & { database: string; schema: string },
+): SQLTableContext => ({
+ engine: "my_engine",
+ dialect: "duckdb",
+ ...overrides,
+});
+
+describe("DatasetColumnPreview fullyQualifiedTableName", () => {
+ beforeEach(() => {
+ vi.clearAllMocks();
+ });
+
+ it("uses just the table name without a SQL context", () => {
+ const client = renderPreview(undefined);
+ expect(client.previewDatasetColumn).toHaveBeenCalledWith(
+ expect.objectContaining({ fullyQualifiedTableName: "users" }),
+ );
+ });
+
+ it("qualifies with database and schema for flat engines", () => {
+ const client = renderPreview(ctx({ database: "db", schema: "public" }));
+ expect(client.previewDatasetColumn).toHaveBeenCalledWith(
+ expect.objectContaining({ fullyQualifiedTableName: "db.public.users" }),
+ );
+ });
+
+ it("does not emit a double dot for schemaless tables", () => {
+ // Regression: previously produced "db..users".
+ const client = renderPreview(ctx({ database: "db", schema: "" }));
+ expect(client.previewDatasetColumn).toHaveBeenCalledWith(
+ expect.objectContaining({ fullyQualifiedTableName: "db.users" }),
+ );
+ });
+
+ it("includes the full schema path for nested namespaces", () => {
+ // Regression: previously dropped schemaPath and emitted "top.deep.users".
+ const client = renderPreview(
+ ctx({ database: "top", schema: "deep", schemaPath: ["nested", "deep"] }),
+ );
+ expect(client.previewDatasetColumn).toHaveBeenCalledWith(
+ expect.objectContaining({
+ fullyQualifiedTableName: "top.nested.deep.users",
+ }),
+ );
+ });
+});
diff --git a/frontend/src/components/datasources/column-preview.tsx b/frontend/src/components/datasources/column-preview.tsx
index 65cdc7dd12..34176faf16 100644
--- a/frontend/src/components/datasources/column-preview.tsx
+++ b/frontend/src/components/datasources/column-preview.tsx
@@ -29,7 +29,7 @@ import { Button } from "../ui/button";
import { Tooltip } from "../ui/tooltip";
import { ColumnPreviewContainer } from "./components";
import { InstallPackageButton } from "./install-package-button";
-import { convertStatsName, sqlCode } from "./utils";
+import { convertStatsName, sqlCode, tableUniqueId } from "./utils";
export const DatasetColumnPreview: React.FC<{
table: DataTable;
@@ -48,9 +48,7 @@ export const DatasetColumnPreview: React.FC<{
tableName: table.name,
columnName: column.name,
sourceType: table.source_type,
- fullyQualifiedTableName: sqlTableContext
- ? `${sqlTableContext.database}.${sqlTableContext.schema}.${table.name}`
- : table.name,
+ fullyQualifiedTableName: tableUniqueId(sqlTableContext, table.name),
});
};