Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

chore: enforce accessible headings and roles (#10998)

Shahmir Varqhac69b4da99c15
diff --git a/frontend/.oxlintrc.json b/frontend/.oxlintrc.json
index a0e19a5b82..a42e9b30b0 100644
--- a/frontend/.oxlintrc.json
+++ b/frontend/.oxlintrc.json
@@ -133,14 +133,12 @@
// === JSX A11y ===
// TODO: re-enable the remaining rules as error
"jsx-a11y/click-events-have-key-events": "off",
- "jsx-a11y/heading-has-content": "off",
"jsx-a11y/iframe-has-title": "error",
"jsx-a11y/media-has-caption": "off",
"jsx-a11y/no-autofocus": "off",
"jsx-a11y/no-noninteractive-tabindex": "warn",
"jsx-a11y/no-static-element-interactions": "off",
"jsx-a11y/prefer-tag-over-role": "warn",
- "jsx-a11y/role-has-required-aria-props": "warn",
"react/no-danger": "off",
diff --git a/frontend/src/components/static-html/static-banner.tsx b/frontend/src/components/static-html/static-banner.tsx
index 1c1d975b46..bf31ced0e6 100644
--- a/frontend/src/components/static-html/static-banner.tsx
+++ b/frontend/src/components/static-html/static-banner.tsx
@@ -1,5 +1,4 @@
/* Copyright 2026 Marimo. All rights reserved. */
-/* oxlint-disable react/jsx-no-comment-textnodes */
import { useAtomValue } from "jotai";
import { CopyIcon, DownloadIcon } from "lucide-react";
diff --git a/frontend/src/components/ui/typography.tsx b/frontend/src/components/ui/typography.tsx
index 6ec3e3f8d9..0a9bb16436 100644
--- a/frontend/src/components/ui/typography.tsx
+++ b/frontend/src/components/ui/typography.tsx
@@ -5,7 +5,7 @@ import { cn } from "@/utils/cn";
const H1 = React.forwardRef<
HTMLHeadingElement,
React.ComponentPropsWithoutRef<"h1">
->(({ className, ...props }, ref) => {
+>(({ className, children, ...props }, ref) => {
return (
<h1
className={cn(
@@ -14,7 +14,9 @@ const H1 = React.forwardRef<
)}
ref={ref}
{...props}
- />
+ >
+ {children}
+ </h1>
);
});
H1.displayName = "H1";
@@ -22,7 +24,7 @@ H1.displayName = "H1";
const H2 = React.forwardRef<
HTMLHeadingElement,
React.ComponentPropsWithoutRef<"h2">
->(({ className, ...props }, ref) => {
+>(({ className, children, ...props }, ref) => {
return (
<h2
className={cn(
@@ -31,7 +33,9 @@ const H2 = React.forwardRef<
)}
ref={ref}
{...props}
- />
+ >
+ {children}
+ </h2>
);
});
H2.displayName = "H2";
@@ -39,7 +43,7 @@ H2.displayName = "H2";
const H3 = React.forwardRef<
HTMLHeadingElement,
React.ComponentPropsWithoutRef<"h3">
->(({ className, ...props }, ref) => {
+>(({ className, children, ...props }, ref) => {
return (
<h3
className={cn(
@@ -48,7 +52,9 @@ const H3 = React.forwardRef<
)}
ref={ref}
{...props}
- />
+ >
+ {children}
+ </h3>
);
});
H3.displayName = "H3";
@@ -56,7 +62,7 @@ H3.displayName = "H3";
const H4 = React.forwardRef<
HTMLHeadingElement,
React.ComponentPropsWithoutRef<"h4">
->(({ className, ...props }, ref) => {
+>(({ className, children, ...props }, ref) => {
return (
<h4
className={cn(
@@ -65,7 +71,9 @@ const H4 = React.forwardRef<
)}
ref={ref}
{...props}
- />
+ >
+ {children}
+ </h4>
);
});
H4.displayName = "H4";