A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
test: make session resume E2E retries reliable (#10588)
Shahmir Varqhacad0f45d8e69
diff --git a/frontend/e2e-tests/shutdown.spec.ts b/frontend/e2e-tests/shutdown.spec.tsindex 97e70add89..481c2dd4ac 100644--- a/frontend/e2e-tests/shutdown.spec.ts+++ b/frontend/e2e-tests/shutdown.spec.ts@@ -3,24 +3,26 @@import { fileURLToPath } from "node:url";import { expect, test } from "@playwright/test";import { getAppUrl, startServer } from "../playwright.config";-import { takeScreenshot } from "./helper";+import { maybeRestartKernel, takeScreenshot } from "./helper";const _filename = fileURLToPath(import.meta.url);test("can resume a session", async ({ page }) => {const appUrl = getAppUrl("shutdown.py");await page.goto(appUrl);+ await maybeRestartKernel(page);await expect(page.getByText("'None'", { exact: true })).toBeVisible();- // type in the form- await page.locator("#output-Hbol").getByRole("textbox").fill("12345");- // shift enter to run the form- await page.keyboard.press("Meta+Enter");+ await page.getByTestId("marimo-plugin-text-input").fill("12345");+ await page.getByTestId("marimo-plugin-form-submit-button").click();- // wait for the output to appear- let secondCell = await page.locator(".marimo-cell").nth(1);- await expect(secondCell.getByText("12345")).toBeVisible();- await expect(secondCell.getByText("54321")).toBeVisible();+ const secondCell = page.locator(".marimo-cell").nth(1);+ await expect(+ secondCell.getByText("'12345'", { exact: true }),+ ).toBeVisible({ timeout: 15_000 });+ await expect(+ secondCell.getByText("54321", { exact: true }),+ ).toBeVisible({ timeout: 15_000 });// Refresh the pageawait page.reload();@@ -28,9 +30,12 @@ test("can resume a session", async ({ page }) => {await expect(page.getByText("You have reconnected to an existing session."),).toBeVisible();- secondCell = await page.locator(".marimo-cell").nth(1);- await expect(page.getByText("12345")).toBeVisible();- await expect(page.getByText("54321")).toBeVisible();+ await expect(+ secondCell.getByText("'12345'", { exact: true }),+ ).toBeVisible({ timeout: 15_000 });+ await expect(+ secondCell.getByText("54321", { exact: true }),+ ).toBeVisible({ timeout: 15_000 });});test("restart kernel", async ({ page }) => {diff --git a/frontend/playwright.config.ts b/frontend/playwright.config.tsindex 5c99dda2fa..0db92c843a 100644--- a/frontend/playwright.config.ts+++ b/frontend/playwright.config.ts@@ -78,6 +78,9 @@ export function getAppUrl(app: ApplicationNames): string {throw new Error(`No server options for app: ${app}`);}if (options.command === "edit") {+ if (options.port !== undefined) {+ return getUrl({ port: options.port });+ }const pathToApp = path.join(pydir, app);return getUrl({ port: EDIT_PORT, queryParams: `?file=${pathToApp}` });}