Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

remove feat flag for storage inspector (#8987)

Shahmir Varqhacc265db2c897
diff --git a/docs/guides/working_with_data/remote_storage.md b/docs/guides/working_with_data/remote_storage.md
index ba67e13b20..b0c291fcef 100644
--- a/docs/guides/working_with_data/remote_storage.md
+++ b/docs/guides/working_with_data/remote_storage.md
@@ -2,10 +2,6 @@
marimo makes it easy to work with cloud storage and remote filesystems by automatically detecting [obstore](https://developmentseed.org/obstore/) and [fsspec](https://filesystem-spec.readthedocs.io/) storage connections in your notebook. From the Files panel, you can browse directories, search entries, copy URLs, and download files—all without leaving the editor.
-!!! example "Experimental"
-
- Remote storage is an experimental feature. It is enabled by default; you can turn it off in **Settings > Experimental > Storage Inspector** if needed.
-
<div align="center">
<video autoplay muted loop playsinline width="100%" height="100%" align="center">
<source src="/_static/docs-remote-storage.mp4" type="video/mp4">
diff --git a/frontend/src/components/app-config/user-config-form.tsx b/frontend/src/components/app-config/user-config-form.tsx
index 29db77abda..d075685428 100644
--- a/frontend/src/components/app-config/user-config-form.tsx
+++ b/frontend/src/components/app-config/user-config-form.tsx
@@ -1276,33 +1276,6 @@ export const UserConfigForm: React.FC = () => {
</div>
)}
/>
- <FormField
- control={form.control}
- name="experimental.storage_inspector"
- render={({ field }) => (
- <div className="flex flex-col gap-y-1">
- <FormItem className={formItemClasses}>
- <FormLabel className="font-normal">
- Storage Inspector
- </FormLabel>
- <FormControl>
- <Checkbox
- data-testid="storage-inspector-checkbox"
- checked={field.value === true}
- onCheckedChange={field.onChange}
- />
- </FormControl>
- </FormItem>
- <IsOverridden
- userConfig={config}
- name="experimental.storage_inspector"
- />
- <FormDescription>
- Enable experimental storage inspector.
- </FormDescription>
- </div>
- )}
- />
</SettingGroup>
);
}
diff --git a/frontend/src/components/editor/chrome/panels/file-explorer-panel.tsx b/frontend/src/components/editor/chrome/panels/file-explorer-panel.tsx
index 094c24826f..5b55fa39e2 100644
--- a/frontend/src/components/editor/chrome/panels/file-explorer-panel.tsx
+++ b/frontend/src/components/editor/chrome/panels/file-explorer-panel.tsx
@@ -7,7 +7,6 @@ import React, { useCallback, useMemo } from "react";
import useResizeObserver from "use-resize-observer";
import { StorageInspector } from "@/components/storage/storage-inspector";
import { Accordion } from "@/components/ui/accordion";
-import { getFeatureFlag } from "@/core/config/feature-flag";
import { storageNamespacesAtom } from "@/core/storage/state";
import { cn } from "@/utils/cn";
import { jotaiJsonStorage } from "@/utils/storage/jotai";
@@ -103,15 +102,6 @@ const FileExplorerPanel: React.FC = () => {
bothOpen ? availableContent - storageMaxHeight : availableContent,
);
- const storageInspectorEnabled = getFeatureFlag("storage_inspector");
- if (!storageInspectorEnabled) {
- return (
- <div ref={panelRef} className="h-full overflow-auto">
- <FileExplorerComponent height={panelHeight} />
- </div>
- );
- }
-
return (
<div ref={panelRef} className="h-full overflow-auto">
<Accordion
diff --git a/frontend/src/core/config/__tests__/config-schema.test.ts b/frontend/src/core/config/__tests__/config-schema.test.ts
index 4e2d6d48ff..3109bd4a0a 100644
--- a/frontend/src/core/config/__tests__/config-schema.test.ts
+++ b/frontend/src/core/config/__tests__/config-schema.test.ts
@@ -70,9 +70,7 @@ test("default UserConfig - empty", () => {
"reference_highlighting": true,
"theme": "light",
},
- "experimental": {
- "storage_inspector": true,
- },
+ "experimental": {},
"formatting": {
"line_length": 79,
},
@@ -142,9 +140,7 @@ test("default UserConfig - one level", () => {
"reference_highlighting": true,
"theme": "light",
},
- "experimental": {
- "storage_inspector": true,
- },
+ "experimental": {},
"formatting": {
"line_length": 79,
},
diff --git a/frontend/src/core/config/config-schema.ts b/frontend/src/core/config/config-schema.ts
index 4a0ddd6049..956d627c85 100644
--- a/frontend/src/core/config/config-schema.ts
+++ b/frontend/src/core/config/config-schema.ts
@@ -186,7 +186,6 @@ export const UserConfigSchema = z
.looseObject({
markdown: z.boolean().optional(),
rtc: z.boolean().optional(),
- storage_inspector: z.boolean().prefault(true),
// Add new experimental features here
})
// Pass through so that we don't remove any extra keys that the user has added.
diff --git a/frontend/src/core/config/feature-flag.tsx b/frontend/src/core/config/feature-flag.tsx
index b107bf460b..8e48abdc2d 100644
--- a/frontend/src/core/config/feature-flag.tsx
+++ b/frontend/src/core/config/feature-flag.tsx
@@ -11,7 +11,6 @@ export interface ExperimentalFeatures {
rtc_v2: boolean;
cache_panel: boolean;
external_agents: boolean;
- storage_inspector: boolean;
// Add new feature flags here
}
@@ -21,7 +20,6 @@ const defaultValues: ExperimentalFeatures = {
rtc_v2: false,
cache_panel: false,
external_agents: import.meta.env.DEV,
- storage_inspector: true,
};
export function getFeatureFlag<T extends keyof ExperimentalFeatures>(
diff --git a/marimo/_config/config.py b/marimo/_config/config.py
index 4b8f11d955..03d8b327c7 100644
--- a/marimo/_config/config.py
+++ b/marimo/_config/config.py
@@ -599,10 +599,6 @@ class ExperimentalConfig(TypedDict, total=False):
# But maintain type safety for known flags
ExperimentalConfigType = dict[str, Any]
-# Default for experimental.storage_inspector when not set by user.
-# Must match frontend default in feature-flag.tsx.
-STORAGE_INSPECTOR_DEFAULT = True
-
@mddoc
@dataclass
diff --git a/marimo/_pyodide/pyodide_session.py b/marimo/_pyodide/pyodide_session.py
index ead95cfd97..d646fbc60f 100644
--- a/marimo/_pyodide/pyodide_session.py
+++ b/marimo/_pyodide/pyodide_session.py
@@ -11,7 +11,6 @@ from typing import TYPE_CHECKING, Any, Callable, TypeVar, cast
from marimo import _loggers
from marimo._config.config import (
- STORAGE_INSPECTOR_DEFAULT,
MarimoConfig,
PartialMarimoConfig,
merge_default_config,
@@ -467,9 +466,6 @@ def _launch_pyodide_kernel(
hooks.add_post_execution(attempt_pytest, Priority.LATE)
if is_edit_mode:
hooks.add_post_execution(render_toplevel_defs, Priority.LATE)
- if user_config.get("experimental", {}).get(
- "storage_inspector", STORAGE_INSPECTOR_DEFAULT
- ):
hooks.add_post_execution(broadcast_storage_backends, Priority.LATE)
kernel = Kernel(
diff --git a/marimo/_runtime/runtime.py b/marimo/_runtime/runtime.py
index 27b92a7d0f..1b2093c13d 100644
--- a/marimo/_runtime/runtime.py
+++ b/marimo/_runtime/runtime.py
@@ -34,7 +34,6 @@ from marimo._ast.names import SETUP_CELL_NAME
from marimo._ast.variables import BUILTINS, is_local
from marimo._ast.visitor import ImportData, Name, VariableData
from marimo._config.config import (
- STORAGE_INSPECTOR_DEFAULT,
ExecutionType,
MarimoConfig,
OnCellChangeType,
@@ -3592,9 +3591,6 @@ def launch_kernel(
hooks.add_post_execution(attempt_pytest, Priority.LATE)
if is_edit_mode:
hooks.add_post_execution(render_toplevel_defs, Priority.LATE)
- if user_config.get("experimental", {}).get(
- "storage_inspector", STORAGE_INSPECTOR_DEFAULT
- ):
hooks.add_post_execution(broadcast_storage_backends, Priority.LATE)
kernel = Kernel(
diff --git a/marimo/_server/print.py b/marimo/_server/print.py
index 51a6a2f914..54e5a871e8 100644
--- a/marimo/_server/print.py
+++ b/marimo/_server/print.py
@@ -185,6 +185,7 @@ def print_experimental_features(config: MarimoConfig) -> None:
"performant_table_charts",
"chat_modes",
"server_side_pdf_export",
+ "storage_inspector",
}
keys = keys - finished_experiments