A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix: improve parameter validation error messages for list[NewType] fields (#9442)
Wallycdb4b0700776
diff --git a/marimo/_utils/parse_dataclass.py b/marimo/_utils/parse_dataclass.pyindex 94eb396c61..d8471bf72c 100644--- a/marimo/_utils/parse_dataclass.py+++ b/marimo/_utils/parse_dataclass.py@@ -152,12 +152,12 @@ class _DataclassParser:f"Value '{value}' does not fit any type of the literal")return value # type: ignore[no-any-return]- elif type(cls) is type(Enum) and issubclass(cls, Enum):+ elif isinstance(cls, type) and issubclass(cls, Enum):return cls(value) # type: ignore[return-value]elif dataclasses.is_dataclass(cls):return self.build_dataclass(value, cls) # type: ignore[return-value]- if issubclass(cls, msgspec.Struct):+ if isinstance(cls, type) and issubclass(cls, msgspec.Struct):return _parse_msgspec(value, strict=not self.allow_unknown_keys, cls=cls) # type: ignore[return-value]diff --git a/tests/_utils/test_parse_dataclass.py b/tests/_utils/test_parse_dataclass.pyindex 9476c230dd..01dbf034a9 100644--- a/tests/_utils/test_parse_dataclass.py+++ b/tests/_utils/test_parse_dataclass.py@@ -944,3 +944,30 @@ def test_dataclass_with_nested_msgspec_struct() -> None:# Test as dictparsed = parse_raw(data, Nested, allow_unknown_keys=True)assert parsed == Nested(config=StructClass(limit=10))+++def test_wrong_container_type_error_message() -> None:+ """Test that wrong container types produce clear error messages, not TypeError."""++ @dataclass+ class ArgsWithList:+ session_id: CellId_t+ cell_ids: list[CellId_t]++ # Test wrong type for list field (string instead of list)+ with pytest.raises(ValueError) as exc_info:+ parse_raw(+ {"session_id": "test", "cell_ids": "not_a_list"}, ArgsWithList+ )+ assert "does not fit" in str(exc_info.value)++ # Test wrong type for list field (dict instead of list)+ with pytest.raises(ValueError) as exc_info:+ parse_raw({"session_id": "test", "cell_ids": {"a": 1}}, ArgsWithList)+ assert "does not fit" in str(exc_info.value)++ # Test valid list+ result = parse_raw(+ {"session_id": "test", "cell_ids": ["c1", "c2"]}, ArgsWithList+ )+ assert result.cell_ids == ["c1", "c2"]