Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix: update NavigationMenu for correct popover positioning (#7403)

Myles Scolnickd7f0ccea4189
diff --git a/frontend/src/plugins/layout/NavigationMenuPlugin.tsx b/frontend/src/plugins/layout/NavigationMenuPlugin.tsx
index 8b11a18f2f..de19c67cc8 100644
--- a/frontend/src/plugins/layout/NavigationMenuPlugin.tsx
+++ b/frontend/src/plugins/layout/NavigationMenuPlugin.tsx
@@ -113,28 +113,30 @@ const NavMenuComponent = ({
const renderMenuItem = (item: MenuItem | MenuItemGroup) => {
if ("items" in item) {
return orientation === "horizontal" ? (
- <NavigationMenuItem key={item.label}>
- <NavigationMenuTrigger>
- {renderHTML({ html: item.label })}
- </NavigationMenuTrigger>
- <NavigationMenuContent>
- <NavigationMenuList>
- <ul className="grid w-[400px] gap-3 p-4 md:w-[500px] md:grid-cols-2 lg:w-[600px] ">
- {item.items.map((subItem) => (
- <ListItem
- key={subItem.label}
- label={subItem.label}
- href={preserveQueryParams(subItem.href)}
- target={target(subItem.href)}
- >
- {subItem.description &&
- renderHTML({ html: subItem.description })}
- </ListItem>
- ))}
- </ul>
- </NavigationMenuList>
- </NavigationMenuContent>
- </NavigationMenuItem>
+ <NavigationMenu orientation="horizontal" key={item.label}>
+ <NavigationMenuList>
+ <NavigationMenuItem>
+ <NavigationMenuTrigger>
+ {renderHTML({ html: item.label })}
+ </NavigationMenuTrigger>
+ <NavigationMenuContent>
+ <ul className="grid w-[400px] gap-3 p-4 md:w-[500px] md:grid-cols-2 lg:w-[600px] ">
+ {item.items.map((subItem) => (
+ <ListItem
+ key={subItem.label}
+ label={subItem.label}
+ href={preserveQueryParams(subItem.href)}
+ target={target(subItem.href)}
+ >
+ {subItem.description &&
+ renderHTML({ html: subItem.description })}
+ </ListItem>
+ ))}
+ </ul>
+ </NavigationMenuContent>
+ </NavigationMenuItem>
+ </NavigationMenuList>
+ </NavigationMenu>
) : (
<NavigationMenuItem key={item.label}>
<div
diff --git a/marimo/_smoke_tests/nav_menu_submenu_positioning.py b/marimo/_smoke_tests/nav_menu_submenu_positioning.py
new file mode 100644
index 0000000000..c208ebabc6
--- /dev/null
+++ b/marimo/_smoke_tests/nav_menu_submenu_positioning.py
@@ -0,0 +1,125 @@
+import marimo
+
+__generated_with = "0.18.2"
+app = marimo.App(width="full")
+
+
+def _():
+ import marimo as mo
+ return (mo,)
+
+
+def _(mo):
+ orientation = mo.ui.dropdown(["vertical", "horizontal"], value="horizontal")
+ orientation
+ return (orientation,)
+
+
[email protected](hide_code=True)
+def _(mo):
+ mo.md("""
+ # Nav Menu Submenu Positioning Test (Issue #7398)
+
+ **Expected behavior:** Submenus should position themselves intelligently
+ relative to their parent menu item, especially when the parent is on the
+ right side of the menu.
+ """)
+ return
+
+
+def _(mo, orientation):
+ # Reproduce the exact example from the issue
+ mo.nav_menu(
+ menu={
+ "Menu Item 1": {"/": "Subitem 1"},
+ "Menu Item 2": {"/": "Subitem 2"},
+ "Menu Item 3": {"/": "Subitem 3"},
+ "Menu Item 4": {"/": "Subitem 4"},
+ "Menu Item 5": {"/": "Subitem 5"},
+ "Menu Item 6": {"/": "Subitem 6"},
+ "Menu Item 7": {"/": "Subitem 7"},
+ },
+ orientation=orientation.value,
+ )
+ return
+
+
+def _(mo):
+ mo.md("""
+ ---
+ """)
+ return
+
+
+def _(mo):
+ mo.md("""
+ ## More Complex Example
+
+ This example shows multiple submenu items to better demonstrate the issue.
+ Try hovering over items on the right side.
+ """)
+ return
+
+
+def _(mo, orientation):
+ mo.nav_menu(
+ {
+ "Item 1": {
+ "#item1-sub1": "Subitem 1.1",
+ "#item1-sub2": "Subitem 1.2",
+ "#item1-sub3": "Subitem 1.3",
+ },
+ "Item 2": {
+ "#item2-sub1": "Subitem 2.1",
+ "#item2-sub2": "Subitem 2.2",
+ },
+ "Item 3": {
+ "#item3-sub1": "Subitem 3.1",
+ "#item3-sub2": "Subitem 3.2",
+ },
+ "Item 4": {
+ "#item4-sub1": "Subitem 4.1",
+ "#item4-sub2": "Subitem 4.2",
+ },
+ "Item 5": {
+ "#item5-sub1": "Subitem 5.1",
+ "#item5-sub2": "Subitem 5.2",
+ },
+ "Item 6": {
+ "#item6-sub1": "Subitem 6.1",
+ "#item6-sub2": "Subitem 6.2",
+ "#item6-sub3": {
+ "label": "Subitem 6.3",
+ "description": "This submenu is especially hard to reach!",
+ },
+ },
+ "Item 7": {
+ "#item7-sub1": "Subitem 7.1",
+ "#item7-sub2": "Subitem 7.2",
+ "#item7-sub3": {
+ "label": "Subitem 7.3",
+ "description": "Nearly impossible to access this one",
+ },
+ },
+ },
+ orientation=orientation.value,
+ )
+ return
+
+
+def _(mo):
+ mo.md("""
+ ---
+ """)
+ return
+
+
+if __name__ == "__main__":
+ app.run()