Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

test: add data-testid to top-level chrome elements (#9566)

Myles Scolnickd81ef681e0a6
diff --git a/frontend/src/components/editor/chrome/panels/context-aware-panel/context-aware-panel.tsx b/frontend/src/components/editor/chrome/panels/context-aware-panel/context-aware-panel.tsx
index 1aac027641..b5d65f5587 100644
--- a/frontend/src/components/editor/chrome/panels/context-aware-panel/context-aware-panel.tsx
+++ b/frontend/src/components/editor/chrome/panels/context-aware-panel/context-aware-panel.tsx
@@ -133,7 +133,12 @@ export const ContextAwarePanel: React.FC = () => {
onDragging={handleDragging}
className="resize-handle border-border z-20 print:hidden border-l"
/>
- <Panel defaultSize={25} minSize={25} maxSize={80}>
+ <Panel
+ data-testid="chrome-context-aware-panel"
+ defaultSize={25}
+ minSize={25}
+ maxSize={80}
+ >
{renderBody()}
</Panel>
</>
@@ -167,7 +172,10 @@ const ResizableComponent = ({ children }: ResizableComponentProps) => {
});
return (
- <div className="absolute z-40 right-0 h-full bg-background flex flex-row">
+ <div
+ data-testid="chrome-context-aware-panel"
+ className="absolute z-40 right-0 h-full bg-background flex flex-row"
+ >
<div
ref={handleRefs.left}
className="w-1 h-full cursor-col-resize border-l"
diff --git a/frontend/src/components/editor/chrome/wrapper/app-chrome.tsx b/frontend/src/components/editor/chrome/wrapper/app-chrome.tsx
index 27fccff540..aa4555502d 100644
--- a/frontend/src/components/editor/chrome/wrapper/app-chrome.tsx
+++ b/frontend/src/components/editor/chrome/wrapper/app-chrome.tsx
@@ -537,6 +537,7 @@ export const AppChrome: React.FC<PropsWithChildren> = ({ children }) => {
{helperPanel}
<Panel
id="app-chrome-body"
+ data-testid="chrome-body"
className={cn(isDeveloperPanelOpen && !isSidebarOpen && "border-l")}
>
<PanelGroup autoSaveId="marimo:chrome:v1:l1" direction="vertical">
diff --git a/frontend/src/components/editor/chrome/wrapper/footer.tsx b/frontend/src/components/editor/chrome/wrapper/footer.tsx
index 5214460459..846d6e7da6 100644
--- a/frontend/src/components/editor/chrome/wrapper/footer.tsx
+++ b/frontend/src/components/editor/chrome/wrapper/footer.tsx
@@ -58,7 +58,10 @@ export const Footer: React.FC = () => {
});
return (
- <footer className="h-10 py-1 gap-1 bg-background flex items-center text-muted-foreground text-md pl-2 pr-1 border-t border-border select-none print:hidden text-sm z-50 hide-on-fullscreen overflow-x-auto overflow-y-hidden scrollbar-thin">
+ <footer
+ data-testid="chrome-footer"
+ className="h-10 py-1 gap-1 bg-background flex items-center text-muted-foreground text-md pl-2 pr-1 border-t border-border select-none print:hidden text-sm z-50 hide-on-fullscreen overflow-x-auto overflow-y-hidden scrollbar-thin"
+ >
<FooterItem
className="h-full"
tooltip={
diff --git a/frontend/src/components/editor/chrome/wrapper/panels.tsx b/frontend/src/components/editor/chrome/wrapper/panels.tsx
index b71c75d957..c9fc631482 100644
--- a/frontend/src/components/editor/chrome/wrapper/panels.tsx
+++ b/frontend/src/components/editor/chrome/wrapper/panels.tsx
@@ -3,7 +3,10 @@ import type { PropsWithChildren } from "react";
export const PanelsWrapper: React.FC<PropsWithChildren> = ({ children }) => {
return (
- <div className="flex flex-col flex-1 overflow-hidden absolute inset-0 print:relative">
+ <div
+ data-testid="chrome-wrapper"
+ className="flex flex-col flex-1 overflow-hidden absolute inset-0 print:relative"
+ >
{children}
</div>
);
diff --git a/frontend/src/components/editor/chrome/wrapper/sidebar.tsx b/frontend/src/components/editor/chrome/wrapper/sidebar.tsx
index a6b1af1669..ae80e0a4f8 100644
--- a/frontend/src/components/editor/chrome/wrapper/sidebar.tsx
+++ b/frontend/src/components/editor/chrome/wrapper/sidebar.tsx
@@ -115,7 +115,10 @@ export const Sidebar: React.FC = () => {
]);
return (
- <div className="h-full pt-4 pb-1 px-1 flex flex-col items-start text-muted-foreground text-md select-none text-sm z-50 dark:bg-background print:hidden hide-on-fullscreen">
+ <div
+ data-testid="chrome-sidebar"
+ className="h-full pt-4 pb-1 px-1 flex flex-col items-start text-muted-foreground text-md select-none text-sm z-50 dark:bg-background print:hidden hide-on-fullscreen"
+ >
<ReorderableList<PanelDescriptor>
value={sidebarItems}
setValue={handleSetSidebarItems}
diff --git a/frontend/src/components/editor/controls/Controls.tsx b/frontend/src/components/editor/controls/Controls.tsx
index 023146bdc2..fff83e0e43 100644
--- a/frontend/src/components/editor/controls/Controls.tsx
+++ b/frontend/src/components/editor/controls/Controls.tsx
@@ -88,7 +88,10 @@ export const Controls = ({
{!presenting && <FindReplace />}
{!closed && (
- <div className={topRightControls}>
+ <div
+ data-testid="chrome-controls-top-right"
+ className={topRightControls}
+ >
{presenting && <LayoutSelect />}
<NotebookMenuDropdown
disabled={disabled}
@@ -103,7 +106,10 @@ export const Controls = ({
</div>
)}
- <div className={cn(bottomRightControls)}>
+ <div
+ data-testid="chrome-controls-bottom-right"
+ className={cn(bottomRightControls)}
+ >
<HideInKioskMode>
<SaveComponent kioskMode={false} />
</HideInKioskMode>