A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
Enable TypeScript `erasableSyntaxOnly` (#6447)
Trevor Manzd8580cfd1f7b
diff --git a/frontend/src/components/data-table/column-summary/chart-spec-model.tsx b/frontend/src/components/data-table/column-summary/chart-spec-model.tsxindex 596fa40a0f..78b1075b16 100644--- a/frontend/src/components/data-table/column-summary/chart-spec-model.tsx+++ b/frontend/src/components/data-table/column-summary/chart-spec-model.tsx@@ -64,17 +64,34 @@ export class ColumnChartSpecModel<T> {private dataSpec: TopLevelSpec["data"];private sourceName: "data_0" | "source_0";+ private readonly data: T[] | string;+ private readonly fieldTypes: FieldTypes;+ readonly stats: Record<ColumnName, Partial<ColumnHeaderStats>>;+ readonly binValues: Record<ColumnName, BinValues>;+ readonly valueCounts: Record<ColumnName, ValueCounts>;+ private readonly opts: {+ includeCharts: boolean;+ usePreComputedValues?: boolean;+ };+constructor(- private readonly data: T[] | string,- private readonly fieldTypes: FieldTypes,- readonly stats: Record<ColumnName, Partial<ColumnHeaderStats>>,- readonly binValues: Record<ColumnName, BinValues>,- readonly valueCounts: Record<ColumnName, ValueCounts>,- private readonly opts: {+ data: T[] | string,+ fieldTypes: FieldTypes,+ stats: Record<ColumnName, Partial<ColumnHeaderStats>>,+ binValues: Record<ColumnName, BinValues>,+ valueCounts: Record<ColumnName, ValueCounts>,+ opts: {includeCharts: boolean;usePreComputedValues?: boolean;},) {+ this.data = data;+ this.fieldTypes = fieldTypes;+ this.stats = stats;+ this.binValues = binValues;+ this.valueCounts = valueCounts;+ this.opts = opts;+// Data may come in from a few different sources:// - A URL// - A CSV data URI (e.g. "data:text/csv;base64,...")diff --git a/frontend/src/components/editor/ai/transport/chat-transport.tsx b/frontend/src/components/editor/ai/transport/chat-transport.tsxindex 9bd22f9e34..ed3370e405 100644--- a/frontend/src/components/editor/ai/transport/chat-transport.tsx+++ b/frontend/src/components/editor/ai/transport/chat-transport.tsx@@ -13,11 +13,14 @@ import {export class StreamingChunkTransport<UI_MESSAGE extends UIMessage,> extends DefaultChatTransport<UI_MESSAGE> {+ private onChunkReceived: (chunk: UIMessageChunk) => void;+constructor(options: HttpChatTransportInitOptions<UI_MESSAGE> = {},- private onChunkReceived: (chunk: UIMessageChunk) => void,+ onChunkReceived: (chunk: UIMessageChunk) => void,) {super(options);+ this.onChunkReceived = onChunkReceived;}protected override processResponseStream(diff --git a/frontend/src/components/editor/file-tree/requesting-tree.tsx b/frontend/src/components/editor/file-tree/requesting-tree.tsxindex 59283d18f6..62bb117981 100644--- a/frontend/src/components/editor/file-tree/requesting-tree.tsx+++ b/frontend/src/components/editor/file-tree/requesting-tree.tsx@@ -13,15 +13,21 @@ import { type FilePath, PathBuilder } from "@/utils/paths";export class RequestingTree {private delegate = new SimpleTree<FileInfo>([]);+ private callbacks: {+ listFiles: EditRequests["sendListFiles"];+ createFileOrFolder: EditRequests["sendCreateFileOrFolder"];+ deleteFileOrFolder: EditRequests["sendDeleteFileOrFolder"];+ renameFileOrFolder: EditRequests["sendRenameFileOrFolder"];+ };- constructor(- private callbacks: {- listFiles: EditRequests["sendListFiles"];- createFileOrFolder: EditRequests["sendCreateFileOrFolder"];- deleteFileOrFolder: EditRequests["sendDeleteFileOrFolder"];- renameFileOrFolder: EditRequests["sendRenameFileOrFolder"];- },- ) {}+ constructor(callbacks: {+ listFiles: EditRequests["sendListFiles"];+ createFileOrFolder: EditRequests["sendCreateFileOrFolder"];+ deleteFileOrFolder: EditRequests["sendDeleteFileOrFolder"];+ renameFileOrFolder: EditRequests["sendRenameFileOrFolder"];+ }) {+ this.callbacks = callbacks;+ }private rootPath: FilePath = "" as FilePath;private onChange: (data: FileInfo[]) => void = Functions.NOOP;diff --git a/frontend/src/core/ai/context/__tests__/registry.test.ts b/frontend/src/core/ai/context/__tests__/registry.test.tsindex da854a6854..ce24096002 100644--- a/frontend/src/core/ai/context/__tests__/registry.test.ts+++ b/frontend/src/core/ai/context/__tests__/registry.test.ts@@ -101,11 +101,13 @@ class AttachmentContextProvider extends AIContextProvider<MockContextItem> {readonly mentionPrefix = "@";readonly contextType = "attachment";- constructor(- private items: MockContextItem[] = [],- private attachments: FileUIPart[] = [],- ) {+ private items: MockContextItem[];+ private attachments: FileUIPart[];++ constructor(items: MockContextItem[] = [], attachments: FileUIPart[] = []) {super();+ this.items = items;+ this.attachments = attachments;}getItems(): MockContextItem[] {diff --git a/frontend/src/core/ai/context/providers/cell-output.ts b/frontend/src/core/ai/context/providers/cell-output.tsindex 373f943624..728fab924c 100644--- a/frontend/src/core/ai/context/providers/cell-output.ts+++ b/frontend/src/core/ai/context/providers/cell-output.ts@@ -86,9 +86,10 @@ export class CellOutputContextProvider extends AIContextProvider<CellOutputContereadonly title = "Cell Outputs";readonly mentionPrefix = "@";readonly contextType = "cell-output";-- constructor(private store: JotaiStore) {+ private store: JotaiStore;+ constructor(store: JotaiStore) {super();+ this.store = store;}getItems(): CellOutputContextItem[] {diff --git a/frontend/src/core/ai/context/providers/error.ts b/frontend/src/core/ai/context/providers/error.tsindex 74720e4c05..0a07568f41 100644--- a/frontend/src/core/ai/context/providers/error.ts+++ b/frontend/src/core/ai/context/providers/error.ts@@ -64,9 +64,11 @@ export class ErrorContextProvider extends AIContextProvider<ErrorContextItem> {readonly title = "Errors";readonly mentionPrefix = "@";readonly contextType = "error";+ private store: JotaiStore;- constructor(private store: JotaiStore) {+ constructor(store: JotaiStore) {super();+ this.store = store;}getItems(): ErrorContextItem[] {diff --git a/frontend/src/core/ai/context/providers/file.ts b/frontend/src/core/ai/context/providers/file.tsindex 007c4c4d66..e8cf20e4c7 100644--- a/frontend/src/core/ai/context/providers/file.ts+++ b/frontend/src/core/ai/context/providers/file.ts@@ -43,11 +43,16 @@ export class FileContextProvider extends AIContextProvider<FileContextItem> {readonly mentionPrefix = "#";readonly contextType = "file";+ private apiRequests: EditRequests & RunRequests;+ private config: FileSearchConfig;+constructor(- private apiRequests: EditRequests & RunRequests,- private config: FileSearchConfig = DEFAULT_FILE_SEARCH_CONFIG,+ apiRequests: EditRequests & RunRequests,+ config: FileSearchConfig = DEFAULT_FILE_SEARCH_CONFIG,) {super();+ this.apiRequests = apiRequests;+ this.config = config;}/**diff --git a/frontend/src/core/ai/context/providers/tables.ts b/frontend/src/core/ai/context/providers/tables.tsindex 6a072cf55c..c6b74f8c78 100644--- a/frontend/src/core/ai/context/providers/tables.ts+++ b/frontend/src/core/ai/context/providers/tables.ts@@ -17,9 +17,10 @@ export class TableContextProvider extends AIContextProvider<TableContextItem> {readonly title = "Tables";readonly mentionPrefix = "@";readonly contextType = "data";-- constructor(private tablesMap: DatasetTablesMap) {+ private tablesMap: DatasetTablesMap;+ constructor(tablesMap: DatasetTablesMap) {super();+ this.tablesMap = tablesMap;}getItems(): TableContextItem[] {diff --git a/frontend/src/core/ai/context/providers/variable.ts b/frontend/src/core/ai/context/providers/variable.tsindex eb6bce8baa..da7de1c1f7 100644--- a/frontend/src/core/ai/context/providers/variable.ts+++ b/frontend/src/core/ai/context/providers/variable.ts@@ -20,11 +20,13 @@ export class VariableContextProvider extends AIContextProvider<VariableContextItreadonly mentionPrefix = "@";readonly contextType = "variable";- constructor(- private variables: Variables,- private tablesMap: DatasetTablesMap,- ) {+ private variables: Variables;+ private tablesMap: DatasetTablesMap;++ constructor(variables: Variables, tablesMap: DatasetTablesMap) {super();+ this.variables = variables;+ this.tablesMap = tablesMap;}getItems(): VariableContextItem[] {diff --git a/frontend/src/core/codemirror/find-replace/search-highlight.ts b/frontend/src/core/codemirror/find-replace/search-highlight.tsindex ae307188a9..4d309b2931 100644--- a/frontend/src/core/codemirror/find-replace/search-highlight.ts+++ b/frontend/src/core/codemirror/find-replace/search-highlight.ts@@ -91,8 +91,10 @@ const HighlightMargin = 250;export const searchHighlighter = ViewPlugin.fromClass(class {decorations: DecorationSet;+ readonly view: EditorView;- constructor(readonly view: EditorView) {+ constructor(view: EditorView) {+ this.view = view;this.decorations = this.highlight(view.state.field(searchState));}diff --git a/frontend/src/core/codemirror/lsp/notebook-lsp.ts b/frontend/src/core/codemirror/lsp/notebook-lsp.tsindex 8508881d30..4be8efc609 100644--- a/frontend/src/core/codemirror/lsp/notebook-lsp.ts+++ b/frontend/src/core/codemirror/lsp/notebook-lsp.ts@@ -18,13 +18,19 @@ import { getLSPDocument } from "./utils";class Snapshotter {private documentVersion = 0;+ private readonly getNotebookCode: () => {+ cellIds: CellId[];+ codes: Record<CellId, string>;+ };constructor(- private readonly getNotebookCode: () => {+ getNotebookCode: () => {cellIds: CellId[];codes: Record<CellId, string>;},- ) {}+ ) {+ this.getNotebookCode = getNotebookCode;+ }/*** Map from the global document version to the cell id and version.diff --git a/frontend/src/core/codemirror/readonly/__tests__/extension.test.ts b/frontend/src/core/codemirror/readonly/__tests__/extension.test.tsindex a4d7d7b9b7..a0287a1971 100644--- a/frontend/src/core/codemirror/readonly/__tests__/extension.test.ts+++ b/frontend/src/core/codemirror/readonly/__tests__/extension.test.ts@@ -9,7 +9,7 @@ import { connectionAtom } from "../../../network/connection";import { dynamicReadonly, isEditorReadonly } from "../extension";function makeStoreWithConnection(- state: WebSocketState.CONNECTING | WebSocketState.OPEN,+ state: typeof WebSocketState.CONNECTING | typeof WebSocketState.OPEN,) {const store = createStore();store.set(connectionAtom, { state });diff --git a/frontend/src/core/codemirror/rtc/loro/awareness.ts b/frontend/src/core/codemirror/rtc/loro/awareness.tsindex 78651d7555..bc8f803338 100644--- a/frontend/src/core/codemirror/rtc/loro/awareness.ts+++ b/frontend/src/core/codemirror/rtc/loro/awareness.ts@@ -202,13 +202,25 @@ export const createSelectionLayer = (): Extension =>* Renders a blinking cursor to indicate the cursor of another user.*/export class RemoteCursorMarker implements LayerMarker {+ private left: number;+ private top: number;+ private height: number;+ private name: string;+ private colorClassName: string;+constructor(- private left: number,- private top: number,- private height: number,- private name: string,- private colorClassName: string,- ) {}+ left: number,+ top: number,+ height: number,+ name: string,+ colorClassName: string,+ ) {+ this.left = left;+ this.top = top;+ this.height = height;+ this.name = name;+ this.colorClassName = colorClassName;+ }draw(): HTMLElement {const elt = document.createElement("div");@@ -353,16 +365,30 @@ export interface CursorPosition {export class AwarenessPlugin implements PluginValue {sub: Subscription;+ public view: EditorView;+ public doc: LoroDoc;+ public user: UserState;+ public awareness: Awareness<AwarenessState>;+ private getTextFromDoc: (doc: LoroDoc) => LoroText;+ private scopeId: ScopeId;+ private getUserId?: () => Uid;constructor(- public view: EditorView,- public doc: LoroDoc,- public user: UserState,- public awareness: Awareness<AwarenessState>,- private getTextFromDoc: (doc: LoroDoc) => LoroText,- private scopeId: ScopeId,- private getUserId?: () => Uid,+ view: EditorView,+ doc: LoroDoc,+ user: UserState,+ awareness: Awareness<AwarenessState>,+ getTextFromDoc: (doc: LoroDoc) => LoroText,+ scopeId: ScopeId,+ getUserId?: () => Uid,) {+ this.view = view;+ this.doc = doc;+ this.user = user;+ this.awareness = awareness;+ this.getTextFromDoc = getTextFromDoc;+ this.scopeId = scopeId;+ this.getUserId = getUserId;this.sub = this.doc.subscribe((e) => {if (e.by === "local") {// update remote cursor position@@ -435,12 +461,21 @@ export class AwarenessPlugin implements PluginValue {}export class RemoteAwarenessPlugin implements PluginValue {_awarenessListener?: AwarenessListener;+ public view: EditorView;+ public doc: LoroDoc;+ public awareness: Awareness<AwarenessState>;+ private scopeId: ScopeId;+constructor(- public view: EditorView,- public doc: LoroDoc,- public awareness: Awareness<AwarenessState>,- private scopeId: ScopeId,+ view: EditorView,+ doc: LoroDoc,+ awareness: Awareness<AwarenessState>,+ scopeId: ScopeId,) {+ this.view = view;+ this.doc = doc;+ this.awareness = awareness;+ this.scopeId = scopeId;const listener: AwarenessListener = async (arg, origin) => {if (origin === "local") {return;diff --git a/frontend/src/core/codemirror/rtc/loro/sync.ts b/frontend/src/core/codemirror/rtc/loro/sync.tsindex 43f8258fa7..2e4e581d24 100644--- a/frontend/src/core/codemirror/rtc/loro/sync.ts+++ b/frontend/src/core/codemirror/rtc/loro/sync.ts@@ -40,13 +40,21 @@ export const loroSyncAnnotation = Annotation.define();export class LoroSyncPluginValue implements PluginValue {sub?: Subscription;private isInitDispatch = false;+ private view: EditorView;+ private doc: LoroDoc;+ private docPath: string[];+ private getTextFromDoc: (doc: LoroDoc) => LoroText;constructor(- private view: EditorView,- private doc: LoroDoc,- private docPath: string[],- private getTextFromDoc: (doc: LoroDoc) => LoroText,+ view: EditorView,+ doc: LoroDoc,+ docPath: string[],+ getTextFromDoc: (doc: LoroDoc) => LoroText,) {+ this.view = view;+ this.doc = doc;+ this.docPath = docPath;+ this.getTextFromDoc = getTextFromDoc;this.sub = doc.subscribe(this.onRemoteUpdate);Promise.resolve().then(() => {this.isInitDispatch = true;diff --git a/frontend/src/core/hotkeys/hotkeys.ts b/frontend/src/core/hotkeys/hotkeys.tsindex 23151814a6..8ea908f5a5 100644--- a/frontend/src/core/hotkeys/hotkeys.ts+++ b/frontend/src/core/hotkeys/hotkeys.ts@@ -452,10 +452,13 @@ export class HotkeyProvider implements IHotkeyProvider {return new HotkeyProvider(DEFAULT_HOT_KEY, { platform });}+ private hotkeys: Record<HotkeyAction, Hotkey>;+constructor(- private hotkeys: Record<HotkeyAction, Hotkey>,+ hotkeys: Record<HotkeyAction, Hotkey>,options: HotkeyProviderOptions = {},) {+ this.hotkeys = hotkeys;this.platform = options.platform ?? resolvePlatform();this.mod = this.platform === "mac" ? "Cmd" : "Ctrl";}@@ -503,13 +506,14 @@ export class HotkeyProvider implements IHotkeyProvider {}export class OverridingHotkeyProvider extends HotkeyProvider {+ private readonly overrides: Partial<Record<HotkeyAction, string | undefined>>;+constructor(- private readonly overrides: Partial<- Record<HotkeyAction, string | undefined>- >,+ overrides: Partial<Record<HotkeyAction, string | undefined>>,options: HotkeyProviderOptions = {},) {super(DEFAULT_HOT_KEY, options);+ this.overrides = overrides;}override getHotkey(action: HotkeyAction): ResolvedHotkey {diff --git a/frontend/src/core/kernel/RuntimeState.ts b/frontend/src/core/kernel/RuntimeState.tsindex 18cc2a0168..59baaaa4e1 100644--- a/frontend/src/core/kernel/RuntimeState.ts+++ b/frontend/src/core/kernel/RuntimeState.ts@@ -29,8 +29,11 @@ export class RuntimeState {* ObjectIds of UIElements whose values need to be updated in the kernel*/private _sendComponentValues: RunRequests["sendComponentValues"] | undefined;+ private uiElementRegistry: UIElementRegistry;- constructor(private uiElementRegistry: UIElementRegistry) {}+ constructor(uiElementRegistry: UIElementRegistry) {+ this.uiElementRegistry = uiElementRegistry;+ }private get sendComponentValues(): RunRequests["sendComponentValues"] {if (!this._sendComponentValues) {diff --git a/frontend/src/core/network/DeferredRequestRegistry.ts b/frontend/src/core/network/DeferredRequestRegistry.tsindex 11ae12c03f..a83b9888d7 100644--- a/frontend/src/core/network/DeferredRequestRegistry.ts+++ b/frontend/src/core/network/DeferredRequestRegistry.ts@@ -18,17 +18,29 @@ export const RequestId = {*/export class DeferredRequestRegistry<REQ, RES> {public requests = new Map<RequestId, Deferred<RES>>();+ public operation: string;+ private makeRequest: (id: RequestId, req: REQ) => Promise<void>;+ private opts: {+ /**+ * Resolve existing requests with an empty response.+ */+ resolveExistingRequests?: () => RES;+ };constructor(- public operation: string,- private makeRequest: (id: RequestId, req: REQ) => Promise<void>,- private opts: {+ operation: string,+ makeRequest: (id: RequestId, req: REQ) => Promise<void>,+ opts: {/*** Resolve existing requests with an empty response.*/resolveExistingRequests?: () => RES;} = {},- ) {}+ ) {+ this.operation = operation;+ this.makeRequest = makeRequest;+ this.opts = opts;+ }async request(opts: REQ): Promise<RES> {if (this.opts.resolveExistingRequests) {diff --git a/frontend/src/core/runtime/runtime.ts b/frontend/src/core/runtime/runtime.tsindex 01216b6fd5..344c5c71d5 100644--- a/frontend/src/core/runtime/runtime.ts+++ b/frontend/src/core/runtime/runtime.ts@@ -10,11 +10,12 @@ import type { RuntimeConfig } from "./types";export class RuntimeManager {private initialHealthyCheck = new Deferred<void>();+ private config: RuntimeConfig;+ private lazy: boolean;- constructor(- private config: RuntimeConfig,- private lazy = false,- ) {+ constructor(config: RuntimeConfig, lazy = false) {+ this.config = config;+ this.lazy = lazy;// Validate the URL on constructiontry {new URL(this.config.url);diff --git a/frontend/src/core/wasm/bridge.ts b/frontend/src/core/wasm/bridge.tsindex 5273acf0bd..3b2eb8f6fb 100644--- a/frontend/src/core/wasm/bridge.ts+++ b/frontend/src/core/wasm/bridge.ts@@ -576,7 +576,11 @@ export class PyodideWebsocket implements IReconnectingWebSocket {messageSubscriptions = new Set<(event: MessageEvent) => void>();errorSubscriptions = new Set<(event: Event) => void>();- constructor(private bridge: Pick<PyodideBridge, "consumeMessages">) {}+ private bridge: Pick<PyodideBridge, "consumeMessages">;++ constructor(bridge: Pick<PyodideBridge, "consumeMessages">) {+ this.bridge = bridge;+ }private consumeMessages() {this.bridge.consumeMessages((message) => {diff --git a/frontend/src/core/wasm/store.ts b/frontend/src/core/wasm/store.tsindex 93b8cb6ba7..a23e271dbe 100644--- a/frontend/src/core/wasm/store.ts+++ b/frontend/src/core/wasm/store.ts@@ -87,7 +87,10 @@ const emptyFileStore: FileStore = {};export class CompositeFileStore implements FileStore {- constructor(private stores: FileStore[]) {}+ private stores: FileStore[];+ constructor(stores: FileStore[]) {+ this.stores = stores;+ }insert(index: number, store: FileStore) {this.stores.splice(index, 0, store);diff --git a/frontend/src/core/wasm/worker/message-buffer.ts b/frontend/src/core/wasm/worker/message-buffer.tsindex 5d18fd5484..0b011ec95b 100644--- a/frontend/src/core/wasm/worker/message-buffer.ts+++ b/frontend/src/core/wasm/worker/message-buffer.ts@@ -7,8 +7,9 @@export class MessageBuffer<T> {private buffer: T[];private started = false;-- constructor(private onMessage: (data: T) => void) {+ private onMessage: (data: T) => void;+ constructor(onMessage: (data: T) => void) {+ this.onMessage = onMessage;this.buffer = [];}diff --git a/frontend/src/core/websocket/types.ts b/frontend/src/core/websocket/types.tsindex e94aaeafbc..6e7a086a4b 100644--- a/frontend/src/core/websocket/types.ts+++ b/frontend/src/core/websocket/types.ts@@ -2,22 +2,28 @@import type ReconnectingWebSocket from "partysocket/ws";-export enum WebSocketState {- CONNECTING = "CONNECTING",- OPEN = "CONNECTED",- CLOSING = "CLOSING",- CLOSED = "CLOSED",-}--export enum WebSocketClosedReason {- KERNEL_DISCONNECTED = "KERNEL_DISCONNECTED",- ALREADY_RUNNING = "ALREADY_RUNNING",- MALFORMED_QUERY = "MALFORMED_QUERY",-}+export const WebSocketState = {+ CONNECTING: "CONNECTING",+ OPEN: "OPEN",+ CLOSING: "CLOSING",+ CLOSED: "CLOSED",+} as const;++export type WebSocketState =+ (typeof WebSocketState)[keyof typeof WebSocketState];++export const WebSocketClosedReason = {+ KERNEL_DISCONNECTED: "KERNEL_DISCONNECTED",+ ALREADY_RUNNING: "ALREADY_RUNNING",+ MALFORMED_QUERY: "MALFORMED_QUERY",+} as const;++export type WebSocketClosedReason =+ (typeof WebSocketClosedReason)[keyof typeof WebSocketClosedReason];export type ConnectionStatus =| {- state: WebSocketState.CLOSED;+ state: typeof WebSocketState.CLOSED;code: WebSocketClosedReason;/*** Human-readable reason for closing the connection.@@ -31,9 +37,9 @@ export type ConnectionStatus =}| {state:- | WebSocketState.CONNECTING- | WebSocketState.OPEN- | WebSocketState.CLOSING;+ | typeof WebSocketState.CONNECTING+ | typeof WebSocketState.OPEN+ | typeof WebSocketState.CLOSING;};type PublicInterface<T> = {diff --git a/frontend/src/plugins/impl/anywidget/model.ts b/frontend/src/plugins/impl/anywidget/model.tsindex 0a508a880e..9f913cea73 100644--- a/frontend/src/plugins/impl/anywidget/model.ts+++ b/frontend/src/plugins/impl/anywidget/model.ts@@ -17,8 +17,10 @@ export type EventHandler = (...args: any[]) => void;class ModelManager {private models = new Map<string, Deferred<Model<any>>>();-- constructor(private timeout = 10_000) {}+ private timeout: number;+ constructor(timeout = 10_000) {+ this.timeout = timeout;+ }get(key: string): Promise<Model<any>> {let deferred = this.models.get(key);@@ -64,16 +66,25 @@ export class Model<T extends Record<string, any>> implements AnyModel<T> {private ANY_CHANGE_EVENT = "change";private dirtyFields;public static _modelManager: ModelManager = MODEL_MANAGER;+ private data: T;+ private onChange: (value: Partial<T>) => void;+ private sendToWidget: (req: {+ content?: any;+ buffers?: ArrayBuffer[] | ArrayBufferView[];+ }) => Promise<null | undefined>;constructor(- private data: T,- private onChange: (value: Partial<T>) => void,- private sendToWidget: (req: {+ data: T,+ onChange: (value: Partial<T>) => void,+ sendToWidget: (req: {content?: any;buffers?: ArrayBuffer[] | ArrayBufferView[];}) => Promise<null | undefined>,initialDirtyFields: Set<keyof T>,) {+ this.data = data;+ this.onChange = onChange;+ this.sendToWidget = sendToWidget;this.dirtyFields = new Set(initialDirtyFields);}diff --git a/frontend/src/plugins/impl/data-editor/types.ts b/frontend/src/plugins/impl/data-editor/types.tsindex d073fe4775..3e48e1ab35 100644--- a/frontend/src/plugins/impl/data-editor/types.ts+++ b/frontend/src/plugins/impl/data-editor/types.ts@@ -10,11 +10,13 @@ export interface PositionalEdit {value: unknown;}-export enum BulkEdit {- Insert = "insert",- Remove = "remove",- Rename = "rename",-}+export const BulkEdit = {+ Insert: "insert",+ Remove: "remove",+ Rename: "rename",+} as const;++type BulkEdit = (typeof BulkEdit)[keyof typeof BulkEdit];export interface RowEdit {rowIdx: number;diff --git a/frontend/src/plugins/impl/panel/utils.ts b/frontend/src/plugins/impl/panel/utils.tsindex 74be9888e4..1cb8cdcd5e 100644--- a/frontend/src/plugins/impl/panel/utils.ts+++ b/frontend/src/plugins/impl/panel/utils.ts@@ -57,11 +57,13 @@ export class EventBuffer<T> {private buffer: T[] = [];private isBlocked = false;private timeout: number | null = null;+ private processEvents: () => void;+ private blockDuration: number;- constructor(- private processEvents: () => void,- private blockDuration = 200,- ) {}+ constructor(processEvents: () => void, blockDuration = 200) {+ this.processEvents = processEvents;+ this.blockDuration = blockDuration;+ }add(event: T) {this.buffer.push(event);diff --git a/frontend/src/utils/edit-distance.ts b/frontend/src/utils/edit-distance.tsindex c11615a277..02185459c9 100644--- a/frontend/src/utils/edit-distance.ts+++ b/frontend/src/utils/edit-distance.ts@@ -1,11 +1,13 @@/* Copyright 2024 Marimo. All rights reserved. */-export enum OperationType {- INSERT = "insert",- DELETE = "delete",- SUBSTITUTE = "substitute",- MATCH = "match",-}+export const OperationType = {+ INSERT: "insert",+ DELETE: "delete",+ SUBSTITUTE: "substitute",+ MATCH: "match",+};++type OperationType = (typeof OperationType)[keyof typeof OperationType];export interface EditOperation {type: OperationType;diff --git a/frontend/src/utils/id-tree.tsx b/frontend/src/utils/id-tree.tsxindex c2c6a60e2b..a10ef2c8bc 100644--- a/frontend/src/utils/id-tree.tsx+++ b/frontend/src/utils/id-tree.tsx@@ -23,11 +23,15 @@ export type CellIndex = number & { __brand?: "CellIndex" };* Tree data structure for handling ids with nested children*/export class TreeNode<T> {- constructor(- public value: T,- public isCollapsed: boolean,- public children: Array<TreeNode<T>>,- ) {}+ public value: T;+ public isCollapsed: boolean;+ public children: Array<TreeNode<T>>;++ constructor(value: T, isCollapsed: boolean, children: Array<TreeNode<T>>) {+ this.value = value;+ this.isCollapsed = isCollapsed;+ this.children = children;+ }/*** Recursively count the number of nodes in the tree@@ -102,10 +106,13 @@ export class TreeNode<T> {let uniqueId = 0;export class CollapsibleTree<T> {- private constructor(- public readonly nodes: Array<TreeNode<T>>,- public readonly id: CellColumnId,- ) {}+ public readonly nodes: Array<TreeNode<T>>;+ public readonly id: CellColumnId;++ private constructor(nodes: Array<TreeNode<T>>, id: CellColumnId) {+ this.nodes = nodes;+ this.id = id;+ }static from<T>(ids: T[]): CollapsibleTree<T> {const id = `tree_${uniqueId++}` as CellColumnId;@@ -592,7 +599,11 @@ export class CollapsibleTree<T> {}export class MultiColumn<T> {- constructor(private readonly columns: ReadonlyArray<CollapsibleTree<T>>) {+ private readonly columns: ReadonlyArray<CollapsibleTree<T>>;++ constructor(columns: ReadonlyArray<CollapsibleTree<T>>) {+ this.columns = columns;+// Ensure there is always at least one columnif (columns.length === 0) {this.columns = [CollapsibleTree.from([])];diff --git a/frontend/src/utils/localStorage.ts b/frontend/src/utils/localStorage.tsindex a651676905..1e8dcfa2ce 100644--- a/frontend/src/utils/localStorage.ts+++ b/frontend/src/utils/localStorage.ts@@ -12,7 +12,10 @@ interface Storage<T> {}export class TypedLocalStorage<T> implements Storage<T> {- constructor(private defaultValue: T) {}+ private defaultValue: T;+ constructor(defaultValue: T) {+ this.defaultValue = defaultValue;+ }get(key: string): T {try {@@ -33,10 +36,16 @@ export class TypedLocalStorage<T> implements Storage<T> {}export class ZodLocalStorage<T> implements Storage<T> {+ private schema: ZodType<T, ZodTypeDef, unknown>;+ private getDefaultValue: () => T;+constructor(- private schema: ZodType<T, ZodTypeDef, unknown>,- private getDefaultValue: () => T,- ) {}+ schema: ZodType<T, ZodTypeDef, unknown>,+ getDefaultValue: () => T,+ ) {+ this.schema = schema;+ this.getDefaultValue = getDefaultValue;+ }get(key: string): T {try {diff --git a/frontend/src/utils/paths.ts b/frontend/src/utils/paths.tsindex 355bdb4989..0f0035aee1 100644--- a/frontend/src/utils/paths.ts+++ b/frontend/src/utils/paths.ts@@ -32,7 +32,10 @@ export const Paths = {};export class PathBuilder {- constructor(public readonly deliminator: "/" | "\\") {}+ public readonly deliminator: string;+ constructor(deliminator: "/" | "\\") {+ this.deliminator = deliminator;+ }static guessDeliminator(path: string): PathBuilder {return path.includes("/") ? new PathBuilder("/") : new PathBuilder("\\");diff --git a/frontend/src/utils/pluralize.ts b/frontend/src/utils/pluralize.tsindex af7a65cba5..cddce434c0 100644--- a/frontend/src/utils/pluralize.ts+++ b/frontend/src/utils/pluralize.ts@@ -1,10 +1,13 @@/* Copyright 2024 Marimo. All rights reserved. */export class PluralWord {- constructor(- public singular: string,- public _plural?: string,- ) {}+ public singular: string;+ public _plural?: string;++ constructor(singular: string, _plural?: string) {+ this.singular = singular;+ this._plural = _plural;+ }public pluralize(count: number) {return count === 1 ? this.singular : this.plural;@@ -16,7 +19,11 @@ export class PluralWord {}export class PluralWords {- constructor(private words: PluralWord[]) {}+ private words: PluralWord[];++ constructor(words: PluralWord[]) {+ this.words = words;+ }static of(...words: Array<PluralWord | string>) {return new PluralWords(diff --git a/frontend/src/utils/python-poet/poet.ts b/frontend/src/utils/python-poet/poet.tsindex f56ebffc15..35e66e36c0 100644--- a/frontend/src/utils/python-poet/poet.ts+++ b/frontend/src/utils/python-poet/poet.ts@@ -25,7 +25,10 @@ function asString(value: string | PythonCode): string {}export class Variable implements PythonCode {- constructor(public name: string) {}+ name: string;+ constructor(name: string) {+ this.name = name;+ }toCode(): string {return this.name;@@ -38,10 +41,12 @@ interface LiteralOptions {}export class Literal implements PythonCode {- constructor(- public readonly value: unknown,- public readonly opts: LiteralOptions = {},- ) {}+ public readonly value: unknown;+ public readonly opts: LiteralOptions;+ constructor(value: unknown, opts: LiteralOptions = {}) {+ this.value = value;+ this.opts = opts;+ }static from(value: unknown, opts: LiteralOptions = {}): Literal {return new Literal(value, opts);@@ -114,10 +119,13 @@ export class Literal implements PythonCode {}export class VariableDeclaration implements PythonCode {- constructor(- public name: string,- public value: string | PythonCode,- ) {}+ public name: string;+ public value: string | PythonCode;++ constructor(name: string, value: string | PythonCode) {+ this.name = name;+ this.value = value;+ }toCode(): string {const right = asString(this.value);@@ -129,10 +137,13 @@ export class VariableDeclaration implements PythonCode {}export class FunctionArg implements PythonCode {- constructor(- public name: string,- public value: string | PythonCode,- ) {}+ public name: string;+ public value: string | PythonCode;++ constructor(name: string, value: string | PythonCode) {+ this.name = name;+ this.value = value;+ }toCode(): string {return `${this.name}=${asString(this.value)}`;@@ -141,12 +152,16 @@ export class FunctionArg implements PythonCode {export class FunctionCall implements PythonCode {private args: PythonCode[];+ public name: string;+ public multiLine: boolean;constructor(- public name: string,+ name: string,args: PythonCode[] | Record<string, PythonCode>,- public multiLine = false,+ multiLine = false,) {+ this.name = name;+ this.multiLine = multiLine;this.args = objectToArgs(args);}diff --git a/frontend/src/utils/time.ts b/frontend/src/utils/time.tsindex db618f5348..6aa6e8454b 100644--- a/frontend/src/utils/time.ts+++ b/frontend/src/utils/time.ts@@ -5,6 +5,8 @@ export type Milliseconds = number & { __type__: "milliseconds" };export type Seconds = number & { __type__: "seconds" };export class Time {+ private readonly ms: Milliseconds;+static fromMilliseconds(ms: Milliseconds): Time;static fromMilliseconds(ms: Milliseconds | null): Time | null;static fromMilliseconds(ms: Milliseconds | null): Time | null {@@ -27,7 +29,9 @@ export class Time {return new Time(Date.now() as Milliseconds);}- private constructor(private readonly ms: Milliseconds) {}+ private constructor(ms: Milliseconds) {+ this.ms = ms;+ }toMilliseconds(): Milliseconds {return this.ms;diff --git a/frontend/tsconfig.json b/frontend/tsconfig.jsonindex 8ce23df6ab..92d6f4e1db 100644--- a/frontend/tsconfig.json+++ b/frontend/tsconfig.json@@ -28,6 +28,7 @@"forceConsistentCasingInFileNames": true,"useDefineForClassFields": true,"experimentalDecorators": true,+ "erasableSyntaxOnly": true,/* Perf */"incremental": true,