A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
fix(frontend): keep interactively-created hidden cells editable on creation (#9958)
Kiran Gadhavedeb65f0edb19
diff --git a/frontend/src/core/cells/__tests__/cells.test.ts b/frontend/src/core/cells/__tests__/cells.test.tsindex 768935812f..0f7133613c 100644--- a/frontend/src/core/cells/__tests__/cells.test.ts+++ b/frontend/src/core/cells/__tests__/cells.test.ts@@ -2920,6 +2920,39 @@ describe("cell reducer", () => {expect(state.untouchedNewCells.has(newCellId)).toBe(true);});+ it("adds interactively-created hidden cell with boilerplate code to untouchedNewCells", () => {+ // Markdown cells are created with hideCode and non-empty default code+ // (e.g. `mo.md(r"""\n""")`). They are user-initiated, so their editor+ // should be shown until first blur.+ actions.createNewCell({+ cellId: "__end__",+ before: false,+ code: 'mo.md(r"""\n""")',+ hideCode: true,+ autoFocus: true,+ });++ const newCellId =+ state.cellIds.inOrderIds[state.cellIds.inOrderIds.length - 1];+ expect(state.untouchedNewCells.has(newCellId)).toBe(true);+ });++ it("does not add programmatically-created hidden cell with code to untouchedNewCells", () => {+ // Cells created by the kernel (e.g. via code_mode) carry code and+ // autoFocus=false; their hide_code must take effect immediately.+ actions.createNewCell({+ cellId: "__end__",+ before: false,+ code: "x = 1",+ hideCode: true,+ autoFocus: false,+ });++ const newCellId =+ state.cellIds.inOrderIds[state.cellIds.inOrderIds.length - 1];+ expect(state.untouchedNewCells.has(newCellId)).toBe(false);+ });+it("does not add cell to untouchedNewCells when hideCode is false", () => {actions.createNewCell({cellId: "__end__",diff --git a/frontend/src/core/cells/cells.ts b/frontend/src/core/cells/cells.tsindex cb9e407a15..e32c7900b2 100644--- a/frontend/src/core/cells/cells.ts+++ b/frontend/src/core/cells/cells.ts@@ -276,7 +276,7 @@ const {},scrollKey: autoFocus ? newCellId : null,untouchedNewCells:- hideCode && !code+ hideCode && autoFocus? new Set([...state.untouchedNewCells, newCellId]): state.untouchedNewCells,};