A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.
Python artificial-intelligencedagdata-sciencedata-visualizationdataflowdeveloper-toolsmachine-learningnotebookspipelinepythonreactivesqlweb-app
Fixes cases where images end up clipped when taking screenshots for pdf downloads (#7933)
Shahmir Varqhadfe3e2895640
diff --git a/frontend/e2e-tests/py/kitchen_sink.py b/frontend/e2e-tests/py/kitchen_sink.pyindex e4152a2ced..a1ab8ea035 100644--- a/frontend/e2e-tests/py/kitchen_sink.py+++ b/frontend/e2e-tests/py/kitchen_sink.py@@ -1,10 +1,21 @@# /// script+# dependencies = [+# "altair==6.0.0",+# "marimo>=0.19.4",+# "matplotlib==3.10.8",+# "numpy==2.4.1",+# "plotly==6.5.2",+# "vega-datasets==0.9.0",+# ]# [tool.marimo.runtime]# auto_instantiate = true+# [tool.marimo.experimental]+# server_side_pdf_export = true# ///+import marimo-__generated_with = "0.13.15"+__generated_with = "0.19.4"app = marimo.App()@@ -18,7 +29,6 @@ def _(np, plt):plt.title("Random Bar Chart")plt.xlabel("Categories")plt.ylabel("Values")- Nonereturn (bar,)@@ -45,7 +55,7 @@ def _(mo):@app.cell-def _(alt, callout_kind, mo, office_characters, vega_datasets):+def _(alt, callout_kind, mo, office_characters, px, vega_datasets):options = ["Apples", "Oranges", "Pears"]# inputs@@ -64,16 +74,28 @@ def _(alt, callout_kind, mo, office_characters, vega_datasets):text = mo.ui.text(placeholder="Search...", label="Filter")refresh = mo.ui.refresh(label="Refresh", options=["1s", "5s", "10s", "30s"])microphone = mo.ui.microphone(label="Drop a beat!")+ _cars_df = vega_datasets.data.cars()chart = mo.ui.altair_chart(- alt.Chart(vega_datasets.data.cars())+ alt.Chart(_cars_df).mark_point()- .encode(- x="Horsepower",- y="Miles_per_Gallon",- color="Origin",- )+ .encode(x="Horsepower", y="Miles_per_Gallon", color="Origin"))+ figure = px.scatter(+ _cars_df,+ x="Horsepower",+ y="Miles_per_Gallon",+ color="Origin",+ hover_data=["Name", "Horsepower", "Miles_per_Gallon", "Origin"],+ title="Car Horsepower vs. Miles per Gallon",+ labels={+ "Horsepower": "Horsepower",+ "Miles_per_Gallon": "Miles per Gallon",+ "Origin": "Origin",+ },+ )+ plotly_chart = mo.ui.plotly(figure)+# formform = mo.ui.text_area(placeholder="...").form()@@ -115,6 +137,7 @@ def _(alt, callout_kind, mo, office_characters, vega_datasets):microphone,multiselect,number,+ plotly_chart,progress_bar,radio,refresh,@@ -548,6 +571,14 @@ def _(chart, create_wrapper, mo):return+def _(create_wrapper, mo, plotly_chart):+ create_wrapper(+ mo.vstack([plotly_chart, mo.ui.table(plotly_chart.value)]), "plotly-chart"+ )+ return++@app.celldef _(mo):def create_box(num=1):@@ -595,7 +626,8 @@ def _():import marimo as moimport matplotlib.pyplot as pltimport numpy as np- return alt, mo, np, plt, vega_datasets+ import plotly.express as px+ return alt, mo, np, plt, px, vega_datasetsif __name__ == "__main__":diff --git a/frontend/src/components/editor/actions/useCellActionButton.tsx b/frontend/src/components/editor/actions/useCellActionButton.tsxindex 4444187792..c0a91531a4 100644--- a/frontend/src/components/editor/actions/useCellActionButton.tsx+++ b/frontend/src/components/editor/actions/useCellActionButton.tsx@@ -26,7 +26,6 @@ import {ZapIcon,ZapOffIcon,} from "lucide-react";-import { downloadCellOutput } from "@/components/export/export-output-button";import { MultiIcon } from "@/components/icons/multi-icon";import { useImperativeModal } from "@/components/modal/ImperativeModal";import {@@ -54,6 +53,7 @@ import { useRequestClient } from "@/core/network/requests";import type { CellConfig, RuntimeState } from "@/core/network/types";import { canLinkToCell, createCellLink } from "@/utils/cell-urls";import { copyToClipboard } from "@/utils/copy";+import { downloadCellOutputAsImage } from "@/utils/download";import { MarkdownIcon, PythonIcon } from "../cell/code/icons";import { useDeleteCellCallback } from "../cell/useDeleteCell";import { useRunCell } from "../cell/useRunCells";@@ -341,7 +341,7 @@ export function useCellActionButtons({ cell, closePopover }: Props) {icon: <ImageIcon size={13} strokeWidth={1.5} />,label: "Export output as PNG",hidden: !hasOutput,- handle: () => downloadCellOutput(cellId),+ handle: () => downloadCellOutputAsImage(cellId, "result"),},{icon: <XCircleIcon size={13} strokeWidth={1.5} />,diff --git a/frontend/src/components/editor/actions/useNotebookActions.tsx b/frontend/src/components/editor/actions/useNotebookActions.tsxindex c3e51e80d8..7d430d9edb 100644--- a/frontend/src/components/editor/actions/useNotebookActions.tsx+++ b/frontend/src/components/editor/actions/useNotebookActions.tsx@@ -134,6 +134,12 @@ export function useNotebookActions() {const sharingHtmlEnabled = resolvedConfig.sharing?.html ?? true;const sharingWasmEnabled = resolvedConfig.sharing?.wasm ?? true;+ const isServerSidePdfExportEnabled = getFeatureFlag("server_side_pdf_export");+ // With server side pdf export, it doesn't matter what mode we are in,+ // Default export uses browser print, which is better in present mode+ const pdfDownloadEnabled =+ isServerSidePdfExportEnabled || viewState.mode !== "present";+const renderCheckboxElement = (checked: boolean) => (<div className="w-8 flex justify-end">{checked && <CheckIcon size={14} />}@@ -209,22 +215,24 @@ export function useNotebookActions() {if (!app) {return;}- await downloadHTMLAsImage(app, document.title);+ await downloadHTMLAsImage({+ element: app,+ filename: document.title,+ });},},{icon: <FileIcon size={14} strokeWidth={1.5} />,label: "Download as PDF",- disabled: viewState.mode !== "present",- tooltip:- viewState.mode === "present" ? undefined : (- <span>- Only available in app view. <br />- Toggle with: {renderShortcut("global.hideCode", false)}- </span>- ),+ disabled: !pdfDownloadEnabled,+ tooltip: pdfDownloadEnabled ? undefined : (+ <span>+ Only available in app view. <br />+ Toggle with: {renderShortcut("global.hideCode", false)}+ </span>+ ),handle: async () => {- if (getFeatureFlag("server_side_pdf_export")) {+ if (isServerSidePdfExportEnabled) {if (!filename) {toastNotebookMustBeNamed();return;diff --git a/frontend/src/components/editor/renderers/vertical-layout/vertical-layout.tsx b/frontend/src/components/editor/renderers/vertical-layout/vertical-layout.tsxindex 3542fea22a..777957f944 100644--- a/frontend/src/components/editor/renderers/vertical-layout/vertical-layout.tsx+++ b/frontend/src/components/editor/renderers/vertical-layout/vertical-layout.tsx@@ -185,7 +185,7 @@ const ActionButtons: React.FC<{if (!app) {return;}- await downloadHTMLAsImage(app, document.title);+ await downloadHTMLAsImage({ element: app, filename: document.title });};const handleDownloadAsHTML = async () => {diff --git a/frontend/src/components/export/export-output-button.tsx b/frontend/src/components/export/export-output-button.tsxdeleted file mode 100644index f9749c7a1a..0000000000--- a/frontend/src/components/export/export-output-button.tsx+++ /dev/null@@ -1,14 +0,0 @@-/* Copyright 2026 Marimo. All rights reserved. */--import { type CellId, CellOutputId } from "@/core/cells/ids";-import { downloadHTMLAsImage } from "@/utils/download";--export function downloadCellOutput(cellId: CellId) {- const output = document.getElementById(CellOutputId.create(cellId));- if (output) {- output.classList.add("printing-output");- downloadHTMLAsImage(output, "result.png").finally(() => {- output.classList.remove("printing-output");- });- }-}diff --git a/frontend/src/core/export/hooks.ts b/frontend/src/core/export/hooks.tsindex 87a3c0c941..324ee2cd82 100644--- a/frontend/src/core/export/hooks.ts+++ b/frontend/src/core/export/hooks.ts@@ -1,14 +1,14 @@/* Copyright 2026 Marimo. All rights reserved. */-import { toPng } from "html-to-image";import { atom, useAtom, useAtomValue } from "jotai";import type { MimeType } from "@/components/editor/Output";import { toast } from "@/components/ui/use-toast";import { appConfigAtom } from "@/core/config/config";import { useInterval } from "@/hooks/useInterval";+import { getImageDataUrlForCell } from "@/utils/download";import { Logger } from "@/utils/Logger";import { Objects } from "@/utils/objects";import { cellsRuntimeAtom } from "../cells/cells";-import { type CellId, CellOutputId } from "../cells/ids";+import type { CellId } from "../cells/ids";import { connectionAtom } from "../network/connection";import { useRequestClient } from "../network/requests";import type { UpdateCellOutputsRequest } from "../network/types";@@ -131,16 +131,12 @@ export function useEnrichCellOutputs() {// Capture screenshotsconst results = await Promise.all(cellsToCaptureScreenshot.map(async ([cellId]) => {- const outputElement = document.getElementById(- CellOutputId.create(cellId),- );- if (!outputElement) {- Logger.error(`Output element not found for cell ${cellId}`);- return null;- }-try {- const dataUrl = await toPng(outputElement);+ const dataUrl = await getImageDataUrlForCell(cellId);+ if (!dataUrl) {+ Logger.error(`Failed to capture screenshot for cell ${cellId}`);+ return null;+ }return [cellId, ["image/png", dataUrl]] as [CellId,["image/png", string],diff --git a/frontend/src/utils/__tests__/download.test.tsx b/frontend/src/utils/__tests__/download.test.tsxindex d93bc7d386..904d4cb366 100644--- a/frontend/src/utils/__tests__/download.test.tsx+++ b/frontend/src/utils/__tests__/download.test.tsx@@ -1,6 +1,19 @@/* Copyright 2026 Marimo. All rights reserved. */-import { beforeEach, describe, expect, it, vi } from "vitest";-import { withLoadingToast } from "../download";+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";+import type { CellId } from "@/core/cells/ids";+import { CellOutputId } from "@/core/cells/ids";+import {+ downloadByURL,+ downloadCellOutputAsImage,+ downloadHTMLAsImage,+ getImageDataUrlForCell,+ withLoadingToast,+} from "../download";++// Mock html-to-image+vi.mock("html-to-image", () => ({+ toPng: vi.fn(),+}));// Mock the toast moduleconst mockDismiss = vi.fn();@@ -15,7 +28,23 @@ vi.mock("@/components/icons/spinner", () => ({Spinner: () => "MockSpinner",}));+// Mock Logger+vi.mock("@/utils/Logger", () => ({+ Logger: {+ error: vi.fn(),+ },+}));++// Mock Filenames+vi.mock("@/utils/filenames", () => ({+ Filenames: {+ toPNG: (name: string) => `${name}.png`,+ },+}));++import { toPng } from "html-to-image";import { toast } from "@/components/ui/use-toast";+import { Logger } from "@/utils/Logger";describe("withLoadingToast", () => {beforeEach(() => {@@ -30,6 +59,7 @@ describe("withLoadingToast", () => {expect(toast).toHaveBeenCalledTimes(1);expect(toast).toHaveBeenCalledWith({title: "Loading...",+ duration: Infinity,});expect(mockDismiss).toHaveBeenCalledTimes(1);expect(result).toBe("success");@@ -94,3 +124,369 @@ describe("withLoadingToast", () => {expect(mockDismiss).toHaveBeenCalledTimes(1);});});++describe("getImageDataUrlForCell", () => {+ const mockDataUrl = "data:image/png;base64,mockbase64data";+ let mockElement: HTMLElement;++ beforeEach(() => {+ vi.clearAllMocks();+ mockElement = document.createElement("div");+ mockElement.id = CellOutputId.create("cell-1" as CellId);+ document.body.append(mockElement);+ });++ afterEach(() => {+ mockElement.remove();+ });++ it("should return undefined if element is not found", async () => {+ const result = await getImageDataUrlForCell("nonexistent" as CellId);++ expect(result).toBeUndefined();+ expect(Logger.error).toHaveBeenCalledWith(+ "Output element not found for cell nonexistent",+ );+ });++ it("should capture screenshot and return data URL", async () => {+ vi.mocked(toPng).mockResolvedValue(mockDataUrl);++ const result = await getImageDataUrlForCell("cell-1" as CellId);++ expect(result).toBe(mockDataUrl);+ expect(toPng).toHaveBeenCalledWith(mockElement);+ });++ it("should add printing classes before capture", async () => {+ vi.mocked(toPng).mockImplementation(async () => {+ // Check classes are applied during capture+ expect(mockElement.classList.contains("printing-output")).toBe(true);+ expect(document.body.classList.contains("printing")).toBe(true);+ expect(mockElement.style.overflow).toBe("auto");+ return mockDataUrl;+ });++ await getImageDataUrlForCell("cell-1" as CellId);+ });++ it("should remove printing classes after capture", async () => {+ vi.mocked(toPng).mockResolvedValue(mockDataUrl);++ await getImageDataUrlForCell("cell-1" as CellId);++ expect(mockElement.classList.contains("printing-output")).toBe(false);+ expect(document.body.classList.contains("printing")).toBe(false);+ });++ it("should restore original overflow style after capture", async () => {+ mockElement.style.overflow = "hidden";+ vi.mocked(toPng).mockResolvedValue(mockDataUrl);++ await getImageDataUrlForCell("cell-1" as CellId);++ expect(mockElement.style.overflow).toBe("hidden");+ });++ it("should throw error on failure", async () => {+ vi.mocked(toPng).mockRejectedValue(new Error("Capture failed"));++ await expect(getImageDataUrlForCell("cell-1" as CellId)).rejects.toThrow(+ "Capture failed",+ );+ });++ it("should cleanup even on failure", async () => {+ mockElement.style.overflow = "scroll";+ vi.mocked(toPng).mockRejectedValue(new Error("Capture failed"));++ await expect(getImageDataUrlForCell("cell-1" as CellId)).rejects.toThrow();++ expect(mockElement.classList.contains("printing-output")).toBe(false);+ expect(document.body.classList.contains("printing")).toBe(false);+ expect(mockElement.style.overflow).toBe("scroll");+ });++ it("should maintain body.printing during concurrent captures", async () => {+ // Create a second element+ const mockElement2 = document.createElement("div");+ mockElement2.id = CellOutputId.create("cell-2" as CellId);+ document.body.append(mockElement2);++ // Track body.printing state during each capture+ const printingStateDuringCaptures: boolean[] = [];+ let resolveFirst: () => void;+ let resolveSecond: () => void;++ const firstPromise = new Promise<void>((resolve) => {+ resolveFirst = resolve;+ });+ const secondPromise = new Promise<void>((resolve) => {+ resolveSecond = resolve;+ });++ vi.mocked(toPng).mockImplementation(async (element) => {+ printingStateDuringCaptures.push(+ document.body.classList.contains("printing"),+ );++ // Simulate async work - first capture takes longer+ await (element.id.includes("cell-1") ? firstPromise : secondPromise);++ // Check state again after waiting+ printingStateDuringCaptures.push(+ document.body.classList.contains("printing"),+ );++ return mockDataUrl;+ });++ // Start both captures concurrently+ const capture1 = getImageDataUrlForCell("cell-1" as CellId);+ const capture2 = getImageDataUrlForCell("cell-2" as CellId);++ // Let second capture complete first+ resolveSecond!();+ await new Promise((r) => setTimeout(r, 0));++ // body.printing should still be present because cell-1 is still capturing+ expect(document.body.classList.contains("printing")).toBe(true);++ // Now let first capture complete+ resolveFirst!();+ await Promise.all([capture1, capture2]);++ // After all captures complete, body.printing should be removed+ expect(document.body.classList.contains("printing")).toBe(false);++ // All captures should have seen body.printing = true+ expect(printingStateDuringCaptures.every(Boolean)).toBe(true);++ mockElement2.remove();+ });+});++describe("downloadHTMLAsImage", () => {+ const mockDataUrl = "data:image/png;base64,mockbase64data";+ let mockElement: HTMLElement;+ let mockAppEl: HTMLElement;+ let mockAnchor: HTMLAnchorElement;++ beforeEach(() => {+ vi.clearAllMocks();+ mockElement = document.createElement("div");+ mockAppEl = document.createElement("div");+ mockAppEl.id = "App";+ // Mock scrollTo since jsdom doesn't implement it+ mockAppEl.scrollTo = vi.fn();+ document.body.append(mockElement);+ document.body.append(mockAppEl);++ // Mock anchor element for download+ mockAnchor = document.createElement("a");+ vi.spyOn(document, "createElement").mockReturnValue(mockAnchor);+ vi.spyOn(mockAnchor, "click").mockImplementation(() => {+ // <noop></noop>+ });+ vi.spyOn(mockAnchor, "remove").mockImplementation(() => {+ // noop+ });+ });++ afterEach(() => {+ mockElement.remove();+ mockAppEl.remove();+ vi.restoreAllMocks();+ });++ it("should download image without prepare function", async () => {+ vi.mocked(toPng).mockResolvedValue(mockDataUrl);++ await downloadHTMLAsImage({ element: mockElement, filename: "test" });++ expect(toPng).toHaveBeenCalledWith(mockElement);+ expect(mockAnchor.href).toBe(mockDataUrl);+ expect(mockAnchor.download).toBe("test.png");+ expect(mockAnchor.click).toHaveBeenCalled();+ });++ it("should add body.printing class without prepare function", async () => {+ vi.mocked(toPng).mockImplementation(async () => {+ expect(document.body.classList.contains("printing")).toBe(true);+ return mockDataUrl;+ });++ await downloadHTMLAsImage({ element: mockElement, filename: "test" });+ });++ it("should remove body.printing class after download without prepare", async () => {+ vi.mocked(toPng).mockResolvedValue(mockDataUrl);++ await downloadHTMLAsImage({ element: mockElement, filename: "test" });++ expect(document.body.classList.contains("printing")).toBe(false);+ });++ it("should use prepare function when provided", async () => {+ vi.mocked(toPng).mockResolvedValue(mockDataUrl);+ const cleanup = vi.fn();+ const prepare = vi.fn().mockReturnValue(cleanup);++ await downloadHTMLAsImage({+ element: mockElement,+ filename: "test",+ prepare,+ });++ expect(prepare).toHaveBeenCalledWith(mockElement);+ expect(cleanup).toHaveBeenCalled();+ });++ it("should not add body.printing when prepare is provided", async () => {+ let bodyPrintingDuringCapture = false;+ vi.mocked(toPng).mockImplementation(async () => {+ // Capture the state during toPng execution+ bodyPrintingDuringCapture = document.body.classList.contains("printing");+ return mockDataUrl;+ });+ const cleanup = vi.fn();+ const prepare = vi.fn().mockReturnValue(cleanup);++ await downloadHTMLAsImage({+ element: mockElement,+ filename: "test",+ prepare,+ });++ // body.printing should NOT be added by downloadHTMLAsImage when prepare is provided+ // (the prepare function is responsible for managing its own classes)+ expect(bodyPrintingDuringCapture).toBe(false);+ expect(document.body.classList.contains("printing")).toBe(false);+ expect(prepare).toHaveBeenCalledWith(mockElement);+ expect(cleanup).toHaveBeenCalled();+ });++ it("should show error toast on failure", async () => {+ vi.mocked(toPng).mockRejectedValue(new Error("Failed"));++ await downloadHTMLAsImage({ element: mockElement, filename: "test" });++ expect(toast).toHaveBeenCalledWith({+ title: "Error",+ description: "Failed to download as PNG.",+ variant: "danger",+ });+ });++ it("should cleanup on failure", async () => {+ vi.mocked(toPng).mockRejectedValue(new Error("Failed"));++ await downloadHTMLAsImage({ element: mockElement, filename: "test" });++ expect(document.body.classList.contains("printing")).toBe(false);+ });+});++describe("downloadCellOutputAsImage", () => {+ const mockDataUrl = "data:image/png;base64,mockbase64data";+ let mockElement: HTMLElement;+ let mockAppEl: HTMLElement;+ let mockAnchor: HTMLAnchorElement;++ beforeEach(() => {+ vi.clearAllMocks();+ mockElement = document.createElement("div");+ mockElement.id = CellOutputId.create("cell-1" as CellId);+ mockAppEl = document.createElement("div");+ mockAppEl.id = "App";+ // Mock scrollTo since jsdom doesn't implement it+ mockAppEl.scrollTo = vi.fn();+ document.body.append(mockElement);+ document.body.append(mockAppEl);++ mockAnchor = document.createElement("a");+ vi.spyOn(document, "createElement").mockReturnValue(mockAnchor);+ vi.spyOn(mockAnchor, "click").mockImplementation(() => {+ // <noop></noop>+ });+ vi.spyOn(mockAnchor, "remove").mockImplementation(() => {+ // <noop></noop>+ });+ });++ afterEach(() => {+ mockElement.remove();+ mockAppEl.remove();+ vi.restoreAllMocks();+ });++ it("should return early if element not found", async () => {+ await downloadCellOutputAsImage("nonexistent" as CellId, "test");++ expect(toPng).not.toHaveBeenCalled();+ expect(Logger.error).toHaveBeenCalledWith(+ "Output element not found for cell nonexistent",+ );+ });++ it("should download cell output as image", async () => {+ vi.mocked(toPng).mockResolvedValue(mockDataUrl);++ await downloadCellOutputAsImage("cell-1" as CellId, "result");++ expect(toPng).toHaveBeenCalledWith(mockElement);+ expect(mockAnchor.download).toBe("result.png");+ });++ it("should apply cell-specific preparation", async () => {+ vi.mocked(toPng).mockImplementation(async () => {+ // Check that cell-specific classes are applied+ expect(mockElement.classList.contains("printing-output")).toBe(true);+ expect(document.body.classList.contains("printing")).toBe(true);+ expect(mockElement.style.overflow).toBe("auto");+ return mockDataUrl;+ });++ await downloadCellOutputAsImage("cell-1" as CellId, "result");+ });++ it("should cleanup after download", async () => {+ mockElement.style.overflow = "visible";+ vi.mocked(toPng).mockResolvedValue(mockDataUrl);++ await downloadCellOutputAsImage("cell-1" as CellId, "result");++ expect(mockElement.classList.contains("printing-output")).toBe(false);+ expect(document.body.classList.contains("printing")).toBe(false);+ expect(mockElement.style.overflow).toBe("visible");+ });+});++describe("downloadByURL", () => {+ let mockAnchor: HTMLAnchorElement;++ beforeEach(() => {+ mockAnchor = document.createElement("a");+ vi.spyOn(document, "createElement").mockReturnValue(mockAnchor);+ vi.spyOn(mockAnchor, "click").mockImplementation(() => {+ // <noop></noop>+ });+ vi.spyOn(mockAnchor, "remove").mockImplementation(() => {+ // <noop></noop>+ });+ });++ afterEach(() => {+ vi.restoreAllMocks();+ });++ it("should create anchor, set attributes, click, and remove", () => {+ downloadByURL("data:test", "filename.png");++ expect(document.createElement).toHaveBeenCalledWith("a");+ expect(mockAnchor.href).toBe("data:test");+ expect(mockAnchor.download).toBe("filename.png");+ expect(mockAnchor.click).toHaveBeenCalled();+ expect(mockAnchor.remove).toHaveBeenCalled();+ });+});diff --git a/frontend/src/utils/download.ts b/frontend/src/utils/download.tsindex 94822a2d7d..6e37f024d5 100644--- a/frontend/src/utils/download.ts+++ b/frontend/src/utils/download.ts@@ -1,10 +1,12 @@/* Copyright 2026 Marimo. All rights reserved. */import { toPng } from "html-to-image";import { toast } from "@/components/ui/use-toast";+import { type CellId, CellOutputId } from "@/core/cells/ids";import { getRequestClient } from "@/core/network/requests";import { Filenames } from "@/utils/filenames";import { Paths } from "@/utils/paths";import { prettyError } from "./errors";+import { Logger } from "./Logger";/*** Show a loading toast while an async operation is in progress.@@ -16,6 +18,7 @@ export async function withLoadingToast<T>(): Promise<T> {const loadingToast = toast({title,+ duration: Infinity,});try {const result = await fn();@@ -27,15 +30,111 @@ export async function withLoadingToast<T>(}}-export async function downloadHTMLAsImage(- element: HTMLElement,+function findElementForCell(cellId: CellId): HTMLElement | undefined {+ const element = document.getElementById(CellOutputId.create(cellId));+ if (!element) {+ Logger.error(`Output element not found for cell ${cellId}`);+ return;+ }+ return element;+}++/**+ * Reference counter for body.printing class to handle concurrent screenshot captures.+ * Only adds the class when count goes 0→1, only removes when count goes 1→0.+ */+let bodyPrintingRefCount = 0;++function acquireBodyPrinting() {+ bodyPrintingRefCount++;+ if (bodyPrintingRefCount === 1) {+ document.body.classList.add("printing");+ }+}++function releaseBodyPrinting() {+ bodyPrintingRefCount--;+ if (bodyPrintingRefCount === 0) {+ document.body.classList.remove("printing");+ }+}++/*+ * Prepare a cell element for screenshot capture.+ * Returns a cleanup function that should be called when the screenshot is complete.+ */+function prepareCellElementForScreenshot(element: HTMLElement) {+ element.classList.add("printing-output");+ acquireBodyPrinting();+ const originalOverflow = element.style.overflow;+ element.style.overflow = "auto";++ return () => {+ element.classList.remove("printing-output");+ releaseBodyPrinting();+ element.style.overflow = originalOverflow;+ };+}++/**+ * Capture a cell output as a PNG data URL.+ */+export async function getImageDataUrlForCell(+ cellId: CellId,+): Promise<string | undefined> {+ const element = findElementForCell(cellId);+ if (!element) {+ return;+ }+ const cleanup = prepareCellElementForScreenshot(element);++ try {+ return await toPng(element);+ } finally {+ cleanup();+ }+}++/**+ * Download a cell output as a PNG image file.+ */+export async function downloadCellOutputAsImage(+ cellId: CellId,filename: string,) {+ const element = findElementForCell(cellId);+ if (!element) {+ return;+ }++ await downloadHTMLAsImage({+ element,+ filename,+ prepare: prepareCellElementForScreenshot,+ });+}++export async function downloadHTMLAsImage(opts: {+ element: HTMLElement;+ filename: string;+ prepare?: (element: HTMLElement) => () => void;+}) {+ const { element, filename, prepare } = opts;+// Capture current scroll positionconst appEl = document.getElementById("App");const currentScrollY = appEl?.scrollTop ?? 0;- // Add classnames for printing- document.body.classList.add("printing");++ let cleanup: (() => void) | undefined;+ if (prepare) {+ // Let the prepare function handle adding classes (e.g., body.printing)+ cleanup = prepare(element);+ } else {+ // When no prepare function is provided (e.g., downloading full notebook),+ // add body.printing ourselves+ document.body.classList.add("printing");+ }+try {// Get screenshotconst dataUrl = await toPng(element);@@ -47,8 +146,10 @@ export async function downloadHTMLAsImage(variant: "danger",});} finally {- // Remove classnames for printing- document.body.classList.remove("printing");+ cleanup?.();+ if (document.body.classList.contains("printing")) {+ document.body.classList.remove("printing");+ }// Restore scroll positionrequestAnimationFrame(() => {appEl?.scrollTo(0, currentScrollY);