Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

chore: re-enable low-noise oxlint rules (#10951)

Shahmir Varqhae32b8041661b
diff --git a/frontend/.oxlintrc.json b/frontend/.oxlintrc.json
index 642d91f2f0..a0e19a5b82 100644
--- a/frontend/.oxlintrc.json
+++ b/frontend/.oxlintrc.json
@@ -90,12 +90,6 @@
"no-new": "off",
"no-bitwise": "off",
// TODO: re-enable
- "no-control-regex": "warn",
- // TODO: re-enable
- "no-unsafe-optional-chaining": "warn",
- // TODO: re-enable
- "no-unused-expressions": "warn",
- // TODO: re-enable
"no-unused-vars": "warn",
// === TypeScript ===
@@ -127,10 +121,9 @@
"react/jsx-pascal-case": "error",
"react/no-multi-comp": "off",
"react/jsx-filename-extension": "off",
- // TODO: re-enable as error
- "react/jsx-no-useless-fragment": "warn",
- "react/jsx-no-target-blank": "warn",
- "react/jsx-no-comment-textnodes": "warn",
+ "react/jsx-no-useless-fragment": "error",
+ "react/jsx-no-target-blank": "error",
+ "react/jsx-no-comment-textnodes": "error",
"react/self-closing-comp": "error",
// === React Hooks ===
@@ -138,10 +131,10 @@
"react-hooks/exhaustive-deps": "warn",
// === JSX A11y ===
- // TODO: re-enable all of these as error
+ // TODO: re-enable the remaining rules as error
"jsx-a11y/click-events-have-key-events": "off",
"jsx-a11y/heading-has-content": "off",
- "jsx-a11y/iframe-has-title": "warn",
+ "jsx-a11y/iframe-has-title": "error",
"jsx-a11y/media-has-caption": "off",
"jsx-a11y/no-autofocus": "off",
"jsx-a11y/no-noninteractive-tabindex": "warn",
diff --git a/frontend/src/components/editor/chrome/components/contribute-snippet-button.tsx b/frontend/src/components/editor/chrome/components/contribute-snippet-button.tsx
index 41f5c941e7..7ec4ee8dfa 100644
--- a/frontend/src/components/editor/chrome/components/contribute-snippet-button.tsx
+++ b/frontend/src/components/editor/chrome/components/contribute-snippet-button.tsx
@@ -40,7 +40,12 @@ const ContributeSnippetModal: React.FC<{
<DialogDescription>
Have a useful snippet you want to share with the community? Make a
pull request{" "}
- <a href={Constants.githubPage} target="_blank" className="underline">
+ <a
+ href={Constants.githubPage}
+ target="_blank"
+ rel="noreferrer"
+ className="underline"
+ >
on GitHub
</a>
.
diff --git a/frontend/src/components/editor/notebook-cell.tsx b/frontend/src/components/editor/notebook-cell.tsx
index 45022de9b1..f5b53dfe9c 100644
--- a/frontend/src/components/editor/notebook-cell.tsx
+++ b/frontend/src/components/editor/notebook-cell.tsx
@@ -762,7 +762,7 @@ const EditableCellComponent = ({
href="https://links.marimo.app/reusable-definitions"
target="_blank"
className="hover:underline text-muted-foreground text-xs font-bold"
- rel="noopener"
+ rel="noreferrer"
>
reusable
</a>
@@ -801,7 +801,7 @@ const EditableCellComponent = ({
<a
href="https://links.marimo.app/reusable-definitions"
target="_blank"
- rel="noopener"
+ rel="noreferrer"
>
<HelpCircleIcon
size={16}
diff --git a/frontend/src/components/editor/output/MarimoTracebackOutput.tsx b/frontend/src/components/editor/output/MarimoTracebackOutput.tsx
index a63e21cffe..2722d593f4 100644
--- a/frontend/src/components/editor/output/MarimoTracebackOutput.tsx
+++ b/frontend/src/components/editor/output/MarimoTracebackOutput.tsx
@@ -177,7 +177,7 @@ export const MarimoTracebackOutput = ({
<a
target="_blank"
href="https://marimo.io/discord?ref=notebook"
- rel="noopener"
+ rel="noreferrer"
>
<MessageCircleIcon className="h-4 w-4 mr-2" />
Ask in Discord
diff --git a/frontend/src/components/editor/output/VideoOutput.tsx b/frontend/src/components/editor/output/VideoOutput.tsx
index ec9b1879db..6d06a14354 100644
--- a/frontend/src/components/editor/output/VideoOutput.tsx
+++ b/frontend/src/components/editor/output/VideoOutput.tsx
@@ -7,5 +7,5 @@ interface Props {
}
export const VideoOutput = ({ src, className }: Props): JSX.Element => {
- return <iframe className={className} src={src} />;
+ return <iframe className={className} src={src} title="Video output" />;
};
diff --git a/frontend/src/components/editor/output/ansi-reduce.ts b/frontend/src/components/editor/output/ansi-reduce.ts
index 1b9be7f742..76f6a4a448 100644
--- a/frontend/src/components/editor/output/ansi-reduce.ts
+++ b/frontend/src/components/editor/output/ansi-reduce.ts
@@ -13,8 +13,10 @@ export interface Cursor {
export class TerminalBuffer {
private lines: string[] = [""];
private cursor: Cursor = { row: 0, col: 0 };
- // oxlint-ignore-next-line no-control-regex -- Needed for ANSI escape sequence parsing
- private static readonly ESCAPE_REGEX = /\u001B\[([0-9;]*)([A-DJKH])/u;
+ private static readonly ESCAPE_REGEX = new RegExp(
+ String.raw`\u001B\[([0-9;]*)([A-DJKH])`,
+ "u",
+ );
/** Ensure the internal lines array is large enough. */
private ensureLine(row: number) {
@@ -180,8 +182,10 @@ export class TerminalBuffer {
*/
export class AnsiParser {
// Matches both CSI sequences (ESC[...letter) and other escape sequences like character set selection (ESC(B)
- // oxlint-ignore-next-line no-control-regex -- Needed for ANSI parsing
- private ESC_REGEX = /\u001B(?:\[[0-9;]*[A-Za-z]|\([0-9A-Za-z])/gu;
+ private ESC_REGEX = new RegExp(
+ String.raw`\u001B(?:\[[0-9;]*[A-Za-z]|\([0-9A-Za-z])`,
+ "gu",
+ );
parse(input: string): { type: "text" | "escape"; value: string }[] {
const tokens: { type: "text" | "escape"; value: string }[] = [];
diff --git a/frontend/src/components/editor/output/console/text-rendering.tsx b/frontend/src/components/editor/output/console/text-rendering.tsx
index 6e739c1fcb..b7437425f1 100644
--- a/frontend/src/components/editor/output/console/text-rendering.tsx
+++ b/frontend/src/components/editor/output/console/text-rendering.tsx
@@ -256,6 +256,7 @@ export const pipInstallReplacer: Replacer = (domNode: DOMNode) => {
);
}
+ // oxlint-disable-next-line react/jsx-no-useless-fragment -- html-react-parser replacers must return a React element.
return <>{segments}</>;
};
@@ -283,6 +284,7 @@ export const urlReplacer: Replacer = (domNode: DOMNode) => {
return undefined;
}
+ // oxlint-disable-next-line react/jsx-no-useless-fragment -- html-react-parser replacers must return a React element.
return <>{result}</>;
};
@@ -331,5 +333,5 @@ export const RenderTextWithLinks = ({ text }: { text: string }) => {
);
}, [text]);
- return <>{content}</>;
+ return content;
};
diff --git a/frontend/src/components/home/components.tsx b/frontend/src/components/home/components.tsx
index a852a5954f..d1fd4de163 100644
--- a/frontend/src/components/home/components.tsx
+++ b/frontend/src/components/home/components.tsx
@@ -170,6 +170,7 @@ export const ResourceLinks: React.FC = () => {
key={resource.title}
href={resource.url}
target="_blank"
+ rel="noreferrer"
aria-label={`${resource.title}: ${resource.description}`}
className="flex items-start gap-3 py-3 px-3 rounded-lg border hover:bg-accent/20 transition-colors shadow-xs"
>
diff --git a/frontend/src/components/pages/run-page.tsx b/frontend/src/components/pages/run-page.tsx
index 2b0c412d07..90f7291dc5 100644
--- a/frontend/src/components/pages/run-page.tsx
+++ b/frontend/src/components/pages/run-page.tsx
@@ -50,6 +50,7 @@ const Watermark = () => {
<a
href={Constants.githubPage}
target="_blank"
+ rel="noreferrer"
className="text-sm text-(--grass-11) font-bold tracking-wide transition-colors bg-(--grass-4) hover:bg-(--grass-5) border-t border-l border-(--grass-8) px-3 py-1 rounded-tl-md flex items-center gap-2"
>
<span>made with marimo</span>
diff --git a/frontend/src/components/static-html/share-modal.tsx b/frontend/src/components/static-html/share-modal.tsx
index 182b03dba5..c0b5ade9be 100644
--- a/frontend/src/components/static-html/share-modal.tsx
+++ b/frontend/src/components/static-html/share-modal.tsx
@@ -74,6 +74,7 @@ export const ShareStaticNotebookModal: React.FC<{
<a
href={Constants.issuesPage}
target="_blank"
+ rel="noreferrer"
className="underline"
>
GitHub
@@ -102,7 +103,7 @@ export const ShareStaticNotebookModal: React.FC<{
<DialogDescription>
You can publish a static, non-interactive version of this notebook
to the public web. We will create a link for you that lives on{" "}
- <a href={BASE_URL} target="_blank">
+ <a href={BASE_URL} target="_blank" rel="noreferrer">
{BASE_URL}
</a>
.
diff --git a/frontend/src/components/static-html/static-banner.tsx b/frontend/src/components/static-html/static-banner.tsx
index 5ec023f149..1c1d975b46 100644
--- a/frontend/src/components/static-html/static-banner.tsx
+++ b/frontend/src/components/static-html/static-banner.tsx
@@ -1,6 +1,5 @@
/* Copyright 2026 Marimo. All rights reserved. */
/* oxlint-disable react/jsx-no-comment-textnodes */
-/* oxlint-disable react/jsx-no-target-blank */
import { useAtomValue } from "jotai";
import { CopyIcon, DownloadIcon } from "lucide-react";
@@ -49,6 +48,7 @@ export const StaticBanner: React.FC = () => {
<a
href={Constants.githubPage}
target="_blank"
+ rel="noreferrer"
className="text-(--sky-11) font-medium underline"
>
marimo
@@ -93,6 +93,7 @@ const StaticBannerDialog = ({ code }: { code: string }) => {
<a
href={Constants.githubPage}
target="_blank"
+ rel="noreferrer"
className="text-(--sky-11) hover:underline font-medium"
>
marimo
diff --git a/frontend/src/components/ui/links.tsx b/frontend/src/components/ui/links.tsx
index 1041e7f195..1c4d0c0bf4 100644
--- a/frontend/src/components/ui/links.tsx
+++ b/frontend/src/components/ui/links.tsx
@@ -21,7 +21,12 @@ export const ExternalLink = ({
children: React.ReactNode;
}) => {
return (
- <a href={href} target="_blank" className="text-link hover:underline">
+ <a
+ href={href}
+ target="_blank"
+ rel="noreferrer"
+ className="text-link hover:underline"
+ >
{children}
</a>
);
diff --git a/frontend/src/plugins/layout/RoutesPlugin.tsx b/frontend/src/plugins/layout/RoutesPlugin.tsx
index 4948ff475c..54de400217 100644
--- a/frontend/src/plugins/layout/RoutesPlugin.tsx
+++ b/frontend/src/plugins/layout/RoutesPlugin.tsx
@@ -1,6 +1,5 @@
/* Copyright 2026 Marimo. All rights reserved. */
import React, {
- type JSX,
type PropsWithChildren,
useEffect,
useMemo,
@@ -28,7 +27,7 @@ export class RoutesPlugin implements IStatelessPlugin<Data> {
routes: z.array(z.string()),
});
- render(props: IStatelessPluginProps<Data>): JSX.Element {
+ render(props: IStatelessPluginProps<Data>): React.ReactElement {
return <RoutesComponent {...props.data}>{props.children}</RoutesComponent>;
}
}
@@ -36,7 +35,7 @@ export class RoutesPlugin implements IStatelessPlugin<Data> {
const RoutesComponent = ({
routes,
children,
-}: PropsWithChildren<Data>): JSX.Element => {
+}: PropsWithChildren<Data>): React.ReactNode => {
const childCount = React.Children.count(children);
if (childCount !== routes.length) {
throw new Error(
@@ -69,12 +68,11 @@ const RoutesComponent = ({
}, [handleFindMatch]);
if (!matched) {
- // oxlint-disable-next-line react/jsx-no-useless-fragment
- return <></>;
+ return null;
}
const matchedIndex = routes.indexOf(matched);
const child = React.Children.toArray(children)[matchedIndex];
- return <>{child}</>;
+ return child;
};