Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

style: shadow adjustments (#7700)

Martin Marke4ddc4f28d4b
diff --git a/frontend/src/components/editor/Output.tsx b/frontend/src/components/editor/Output.tsx
index d2313564d4..d1657dc177 100644
--- a/frontend/src/components/editor/Output.tsx
+++ b/frontend/src/components/editor/Output.tsx
@@ -404,7 +404,14 @@ OutputArea.displayName = "OutputArea";
const Div = React.forwardRef<
HTMLDivElement,
React.ComponentPropsWithoutRef<"div">
->((props, ref) => <div ref={ref} {...props} />);
+>((props, ref) => (
+ <div
+ ref={ref}
+ {...props}
+ // biome-ignore lint/a11y/noNoninteractiveTabindex: Needed to capture keypress events (similar to ConsoleOutput)
+ tabIndex={0}
+ />
+));
Div.displayName = "Div";
/**
@@ -505,6 +512,8 @@ const ExpandableOutput = React.memo(
style={
isExpanded || forceExpand ? { maxHeight: "none" } : undefined
}
+ // biome-ignore lint/a11y/noNoninteractiveTabindex: Needed to capture keypress events (similar to ConsoleOutput)
+ tabIndex={0}
>
{children}
</div>
diff --git a/frontend/src/css/app/Cell.css b/frontend/src/css/app/Cell.css
index 1de19c109d..83aee00e8d 100644
--- a/frontend/src/css/app/Cell.css
+++ b/frontend/src/css/app/Cell.css
@@ -15,6 +15,9 @@
border: 1px solid var(--gray-4);
@apply divide-y divide-(--gray-5);
+ &:hover {
+ border-color: var(--gray-6);
+ }
&:focus-visible {
/* focus-visible outlines the entire cell body in black, but the cell's
@@ -156,11 +159,15 @@
/* Error styles for Cell, less precedence than needs run */
&.has-error:not(.needs-run),
&.error-outline {
- border: 1px solid var(--red-4);
+ @apply border-error/20 border-1 divide-error/20 outline-1 outline-error/20;
+ }
+
+ &.has-error:not(.needs-run):hover {
+ @apply border-error/30 outline-error/30;
}
&.has-error:not(.needs-run):focus-within {
- @apply shadow-md-solid shadow-error/10;
+ @apply border-1 outline-0 shadow-md-solid divide-error/20 shadow-error/20;
}
&.error-outline,
@@ -173,11 +180,14 @@
&.needs-run {
/* TODO(akshayka): Can give this an outline to make more visible. */
- border-color: var(--stale);
- @apply divide-stale shadow-sm-solid shadow-stale;
+ @apply border-stale border-1 divide-stale outline-1 outline-stale;
+
+ &:hover {
+ @apply border-action-foreground/30 outline-action-foreground/30;
+ }
&:focus-within {
- @apply divide-stale shadow-md-solid shadow-stale;
+ @apply border-1 outline-0 divide-stale shadow-md-solid shadow-stale;
}
&:focus-within .cm-editor {