Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

chore: enable noninteractive interaction lint (#10861)

Shahmir Varqhae6eab8d2ddd1
diff --git a/frontend/.oxlintrc.json b/frontend/.oxlintrc.json
index 9f773945f2..5ca7ae03b1 100644
--- a/frontend/.oxlintrc.json
+++ b/frontend/.oxlintrc.json
@@ -56,7 +56,6 @@
// === Newly enabled in oxlint 1.79 ===
// Adopt these incrementally
"no-underscore-dangle": "off",
- "jsx-a11y/no-noninteractive-element-interactions": "off",
"react/exhaustive-effect-dependencies": "off",
"react/forbid-component-props": "off",
"react/immutability": "off",
diff --git a/frontend/src/components/editor/RecoveryButton.tsx b/frontend/src/components/editor/RecoveryButton.tsx
index e4502da75f..178c5fdbd1 100644
--- a/frontend/src/components/editor/RecoveryButton.tsx
+++ b/frontend/src/components/editor/RecoveryButton.tsx
@@ -60,6 +60,7 @@ const RecoveryModal = (props: {
// NB: we use markdown class to have sane styling for list, paragraph
return (
<DialogContent className="w-fit">
+ {/* oxlint-disable-next-line jsx-a11y/no-noninteractive-element-interactions -- Handle Escape from any control within the recovery form. */}
<form
onSubmit={(e) => {
e.preventDefault();
diff --git a/frontend/src/components/slides/slide-form.tsx b/frontend/src/components/slides/slide-form.tsx
index 762c3da2a7..26acb5637b 100644
--- a/frontend/src/components/slides/slide-form.tsx
+++ b/frontend/src/components/slides/slide-form.tsx
@@ -427,6 +427,7 @@ export const SlideSidebar = ({
const [isConfigOpen, setIsConfigOpen] = useAtom(slideConfigOpenAtom);
return (
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-element-interactions -- Prevent slide navigation while using controls in the sidebar.
<aside
className="h-full flex flex-col border-l border-border/60 bg-muted/20 transition-[width] duration-200 ease-out overflow-hidden"
style={{
diff --git a/frontend/src/components/slides/slide-notes-editor.tsx b/frontend/src/components/slides/slide-notes-editor.tsx
index 42e8a872f4..a7ae4ea333 100644
--- a/frontend/src/components/slides/slide-notes-editor.tsx
+++ b/frontend/src/components/slides/slide-notes-editor.tsx
@@ -89,6 +89,7 @@ export const SlideNotesEditor = ({
};
return (
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-element-interactions -- Prevent slide navigation while editing speaker notes.
<section
className={cn(
"h-full min-h-0 flex flex-col bg-muted/40 dark:bg-muted/20 border-t",
diff --git a/frontend/src/plugins/impl/data-frames/panel.tsx b/frontend/src/plugins/impl/data-frames/panel.tsx
index 482ed89d93..e788464356 100644
--- a/frontend/src/plugins/impl/data-frames/panel.tsx
+++ b/frontend/src/plugins/impl/data-frames/panel.tsx
@@ -177,6 +177,7 @@ export const TransformPanel: React.FC<Props> = ({
return (
<ColumnInfoContext value={effectiveColumns}>
<ColumnFetchValuesContext value={getColumnValues}>
+ {/* oxlint-disable-next-line jsx-a11y/no-noninteractive-element-interactions -- Prevent Enter from submitting while using controls in the lazy form. */}
<form
onSubmit={(e) => e.preventDefault()}
// When lazy, prevent Enter from submitting