Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

Prune redundant traceback item at start of all traces (#6589)

Yair Chucheme78412e2aa55
diff --git a/marimo/_messaging/tracebacks.py b/marimo/_messaging/tracebacks.py
index ae8f1224e4..0e1a7019c4 100644
--- a/marimo/_messaging/tracebacks.py
+++ b/marimo/_messaging/tracebacks.py
@@ -24,12 +24,31 @@ def _highlight_traceback(traceback: str) -> str:
def write_traceback(traceback: str) -> None:
if isinstance(sys.stderr, Stderr):
sys.stderr._write_with_mimetype(
- _highlight_traceback(traceback),
+ _highlight_traceback(_trim_traceback(traceback)),
mimetype="application/vnd.marimo+traceback",
)
else:
sys.stderr.write(traceback)
+def _trim_traceback(traceback: str) -> str:
+ """
+ Skip first DefaultExecutor.execute_cell traceback item which all traces start with.
+ """
+
+ lines = traceback.split("\n")
+ if (
+ len(lines) > 2
+ and lines[0] == "Traceback (most recent call last):"
+ and '/marimo/_runtime/executor.py", line ' in lines[1]
+ and lines[1].endswith(", in execute_cell")
+ ):
+ for i in range(2, len(lines)):
+ if lines[i].startswith(" File "):
+ return "\n".join(lines[:1] + lines[i:])
+
+ return traceback
+
+
def is_code_highlighting(value: str) -> bool:
return 'class="codehilite"' in value
diff --git a/tests/_messaging/test_tracebacks.py b/tests/_messaging/test_tracebacks.py
index 7c887b9abd..178350dc46 100644
--- a/tests/_messaging/test_tracebacks.py
+++ b/tests/_messaging/test_tracebacks.py
@@ -5,6 +5,7 @@ from unittest.mock import MagicMock, patch
from marimo._messaging.tracebacks import (
_highlight_traceback,
+ _trim_traceback,
is_code_highlighting,
write_traceback,
)
@@ -79,3 +80,11 @@ class TestTracebacks:
assert is_code_highlighting("<span>code</span>") is False
assert is_code_highlighting("") is False
assert is_code_highlighting('class="not-codehilite"') is False
+
+ def test_trim(self) -> None:
+ prefix = "Traceback (most recent call last):\n"
+ head = ' File ".../marimo/_runtime/executor.py", line 139, in execute_cell\n return eval(cell.last_expr, glbls)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n'
+ rest = (
+ ' File ".../__marimo__cell_Hbol_.py", line 2, in <module>\n...\n'
+ )
+ assert _trim_traceback(f"{prefix}{head}{rest}") == f"{prefix}{rest}"