Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

tests: Ensure consistent checking with unparsable cells (#6702)

Dylan Madisettiea8c87e07861
diff --git a/tests/_lint/snapshots/mixed_issues_errors.txt b/tests/_lint/snapshots/mixed_issues_errors.txt
new file mode 100644
index 0000000000..57022d87e6
--- /dev/null
+++ b/tests/_lint/snapshots/mixed_issues_errors.txt
@@ -0,0 +1,157 @@
+critical[unparsable-cells]: Notebook contains unparsable code
+ --> tests/_lint/test_files/mixed_issues.py:7:0
+ 7 | app._unparsable_cell(
+ 8 | r"""
+ | ^
+ 9 | This is a syntax error
+
+critical[unparsable-cells]: Notebook contains unparsable code
+ --> tests/_lint/test_files/mixed_issues.py:27:0
+ 27 | app._unparsable_cell(
+ 28 | r"""
+ | ^
+ 29 | This is another syntax error
+
+critical[unparsable-cells]: Notebook contains unparsable code
+ --> tests/_lint/test_files/mixed_issues.py:41:0
+ 41 | app._unparsable_cell(
+ 42 | r"""
+ | ^
+ 43 | from math import *
+
+critical[unparsable-cells]: Notebook contains unparsable code
+ --> tests/_lint/test_files/mixed_issues.py:63:0
+ 63 | app._unparsable_cell(
+ 64 | r"""
+ | ^
+ 65 | x = 1 +
+
+critical[unparsable-cells]: Notebook contains unparsable code
+ --> tests/_lint/test_files/mixed_issues.py:86:0
+ 86 | app._unparsable_cell(
+ 87 | r"""
+ | ^
+ 88 | def broken(
+
+critical[unparsable-cells]: Notebook contains unparsable code
+ --> tests/_lint/test_files/mixed_issues.py:110:0
+ 110 | app._unparsable_cell(
+ 111 | r"""
+ | ^
+ 112 | class Broken
+
+critical[unparsable-cells]: Notebook contains unparsable code
+ --> tests/_lint/test_files/mixed_issues.py:133:0
+ 133 | app._unparsable_cell(
+ 134 | r"""
+ | ^
+ 135 | import sys as
+
+critical[unparsable-cells]: Notebook contains unparsable code
+ --> tests/_lint/test_files/mixed_issues.py:154:0
+ 154 | app._unparsable_cell(
+ 155 | r"""
+ | ^
+ 156 | for i in
+
+critical[multiple-definitions]: Variable 'Bar' is defined in multiple cells
+ --> tests/_lint/test_files/mixed_issues.py:104:1
+ 104 | def _():
+ 105 | class Bar:
+ | ^
+ 106 | pass
+ ...
+ 120 | def _():
+ 121 | class Bar:
+ | ^
+ 122 | pass
+hint: Variables must be unique across cells. Alternatively, they can be private with an underscore prefix (i.e. `_Bar`.)
+
+critical[multiple-definitions]: Variable 'a' is defined in multiple cells
+ --> tests/_lint/test_files/mixed_issues.py:22:1
+ 22 | def _():
+ 23 | a = 1
+ | ^
+ 24 | return
+ ...
+ 36 | def _():
+ 37 | a = 2
+ | ^
+ 38 | return
+ ...
+ 50 | def _():
+ 51 | a = 3
+ | ^
+ 52 | return
+hint: Variables must be unique across cells. Alternatively, they can be private with an underscore prefix (i.e. `_a`.)
+
+critical[multiple-definitions]: Variable 'b' is defined in multiple cells
+ --> tests/_lint/test_files/mixed_issues.py:57:1
+ 57 | def _():
+ 58 | b = 1
+ | ^
+ 59 | c = 1
+ ...
+ 72 | def _():
+ 73 | b = 2
+ | ^
+ 74 | c = 2
+hint: Variables must be unique across cells. Alternatively, they can be private with an underscore prefix (i.e. `_b`.)
+
+critical[multiple-definitions]: Variable 'c' is defined in multiple cells
+ --> tests/_lint/test_files/mixed_issues.py:58:1
+ 58 | b = 1
+ 59 | c = 1
+ | ^
+ 60 | return b, c
+ ...
+ 73 | b = 2
+ 74 | c = 2
+ | ^
+ 75 | return b, c
+hint: Variables must be unique across cells. Alternatively, they can be private with an underscore prefix (i.e. `_c`.)
+
+critical[multiple-definitions]: Variable 'foo' is defined in multiple cells
+ --> tests/_lint/test_files/mixed_issues.py:80:1
+ 80 | def _():
+ 81 | def foo():
+ | ^
+ 82 | return 1
+ ...
+ 96 | def _():
+ 97 | def foo():
+ | ^
+ 98 | return 2
+hint: Variables must be unique across cells. Alternatively, they can be private with an underscore prefix (i.e. `_foo`.)
+
+critical[multiple-definitions]: Variable 'os' is defined in multiple cells
+ --> tests/_lint/test_files/mixed_issues.py:128:1
+ 128 | def _():
+ 129 | import os
+ | ^
+ 130 | return os,
+ ...
+ 142 | def _():
+ 143 | import os
+ | ^
+ 144 | return os,
+hint: Variables must be unique across cells. Alternatively, they can be private with an underscore prefix (i.e. `_os`.)
+
+critical[cycle-dependencies]: Cell is part of a circular dependency
+ --> tests/_lint/test_files/mixed_issues.py:149:1
+ 149 | def _():
+ 150 | d = e + 1
+ | ^
+ 151 | return d,
+ ...
+ 163 | def _():
+ 164 | e = d + 1
+ | ^
+ 165 | return e,
+
+warning[empty-cells]: Empty cell can be removed (contains only whitespace, comments, or pass)
+ --> tests/_lint/test_files/mixed_issues.py:15:0
+ 15 | @app.cell
+ 16 | def _():
+ | ^
+ 17 | # This is a blank cell
diff --git a/tests/_lint/test_files/mixed_issues.py b/tests/_lint/test_files/mixed_issues.py
new file mode 100644
index 0000000000..360f0eebc3
--- /dev/null
+++ b/tests/_lint/test_files/mixed_issues.py
@@ -0,0 +1,169 @@
+import marimo
+
+__generated_with = "0.16.5"
+app = marimo.App(width="medium")
+
+
+app._unparsable_cell(
+ r"""
+ This is a syntax error
+ """,
+ name="_"
+)
+
+
+def _():
+ # This is a blank cell
+ return
+
+
+def _():
+ a = 1
+ return
+
+
+app._unparsable_cell(
+ r"""
+ This is another syntax error
+ """,
+ name="_"
+)
+
+
+def _():
+ a = 2
+ return
+
+
+app._unparsable_cell(
+ r"""
+ from math import *
+ """,
+ name="_"
+)
+
+
+def _():
+ a = 3
+ return
+
+
+# Test multiple variables with multiple definitions
+def _():
+ b = 1
+ c = 1
+ return b, c
+
+
+app._unparsable_cell(
+ r"""
+ x = 1 +
+ """,
+ name="_"
+)
+
+
+def _():
+ b = 2
+ c = 2
+ return b, c
+
+
+# Test with function definitions
+def _():
+ def foo():
+ return 1
+ return foo,
+
+
+app._unparsable_cell(
+ r"""
+ def broken(
+ x
+ """,
+ name="_"
+)
+
+
+def _():
+ def foo():
+ return 2
+ return foo,
+
+
+# Test with class definitions
+def _():
+ class Bar:
+ pass
+ return Bar,
+
+
+app._unparsable_cell(
+ r"""
+ class Broken
+ pass
+ """,
+ name="_"
+)
+
+
+def _():
+ class Bar:
+ pass
+ return Bar,
+
+
+# Test with import statements
+def _():
+ import os
+ return os,
+
+
+app._unparsable_cell(
+ r"""
+ import sys as
+ """,
+ name="_"
+)
+
+
+def _():
+ import os
+ return os,
+
+
+# Test multiple definitions with cycles (referencing each other)
+def _():
+ d = e + 1
+ return d,
+
+
+app._unparsable_cell(
+ r"""
+ for i in
+ """,
+ name="_"
+)
+
+
+def _():
+ e = d + 1
+ return e,
+
+
+if __name__ == "__main__":
+ app.run()
diff --git a/tests/_lint/test_runtime_errors_snapshot.py b/tests/_lint/test_runtime_errors_snapshot.py
index f5abf61bef..8f7cee63b6 100644
--- a/tests/_lint/test_runtime_errors_snapshot.py
+++ b/tests/_lint/test_runtime_errors_snapshot.py
@@ -207,3 +207,20 @@ def test_self_import_requests_snapshot(tmp_path):
error_output.append(normalized)
snapshot("self_import_requests_errors.txt", "\n".join(error_output))
+
+
+def test_mixed_issues_snapshot():
+ """Test snapshot for mixed issues (syntax errors + multiple definitions)."""
+ file = "tests/_lint/test_files/mixed_issues.py"
+ with open(file) as f:
+ code = f.read()
+
+ notebook = parse_notebook(code, filepath=file)
+ errors = lint_notebook(notebook)
+
+ # Format errors for snapshot
+ error_output = []
+ for error in errors:
+ error_output.append(error.format())
+
+ snapshot("mixed_issues_errors.txt", "\n".join(error_output))