Skip to content

A reactive notebook for Python — run reproducible experiments, query with SQL, execute as a script, deploy as an app, and version with git. Stored as pure Python. All in a modern, AI-native editor.

fix: style edits and popover close on table cells (#10622)

Shahmir Varqhaec6ed9a0fcf7
diff --git a/frontend/src/components/data-table/__tests__/columns.test.tsx b/frontend/src/components/data-table/__tests__/columns.test.tsx
index 3404078a65..831598c4c7 100644
--- a/frontend/src/components/data-table/__tests__/columns.test.tsx
+++ b/frontend/src/components/data-table/__tests__/columns.test.tsx
@@ -1,7 +1,7 @@
/* Copyright 2026 Marimo. All rights reserved. */
import type { Column } from "@tanstack/react-table";
-import { fireEvent, render } from "@testing-library/react";
+import { fireEvent, render, waitFor } from "@testing-library/react";
import { I18nProvider } from "react-aria";
import { describe, expect, it, test, vi } from "vitest";
import { TooltipProvider } from "@/components/ui/tooltip";
@@ -809,6 +809,48 @@ describe("renderCellValue with string + edge whitespace", () => {
</I18nProvider>,
);
+ it("closes a long-string popover when its shadow-DOM trigger is clicked again", async () => {
+ const value = "This string is long enough to render in a cell popover.";
+ const result = renderCellValue({
+ column: createMockStringColumn(),
+ renderValue: () => value,
+ getValue: () => value,
+ selectCell: undefined,
+ cellStyles: "",
+ });
+ const host = document.createElement("div");
+ document.body.append(host);
+ try {
+ const shadowRoot = host.attachShadow({ mode: "open" });
+ const { unmount } = render(
+ <I18nProvider locale="en-US">
+ <TooltipProvider>{result}</TooltipProvider>
+ </I18nProvider>,
+ { container: shadowRoot as unknown as HTMLElement },
+ );
+ try {
+ const trigger =
+ shadowRoot.querySelector<HTMLButtonElement>("button[data-state]");
+ const getCopyButton = () =>
+ document.querySelector('[aria-label="Copy to clipboard"]') ??
+ shadowRoot.querySelector('[aria-label="Copy to clipboard"]');
+
+ expect(trigger).not.toBeNull();
+ fireEvent.pointerDown(trigger!);
+ fireEvent.click(trigger!);
+ await waitFor(() => expect(getCopyButton()).not.toBeNull());
+
+ fireEvent.pointerDown(trigger!);
+ fireEvent.click(trigger!);
+ expect(getCopyButton()).toBeNull();
+ } finally {
+ unmount();
+ }
+ } finally {
+ host.remove();
+ }
+ });
+
it("renders edge whitespace markers and still detects the URL in the middle", () => {
const mockColumn = createMockStringColumn();
const value = " https://example.com ";
diff --git a/frontend/src/components/data-table/columns.tsx b/frontend/src/components/data-table/columns.tsx
index 783d776579..a42b46d4fc 100644
--- a/frontend/src/components/data-table/columns.tsx
+++ b/frontend/src/components/data-table/columns.tsx
@@ -7,12 +7,14 @@ const PopoverClose = PopoverPrimitive.Close;
import type { Column, ColumnDef } from "@tanstack/react-table";
import { formatDate, isValid } from "date-fns";
+import { useRef } from "react";
import { useLocale, useNumberFormatter } from "react-aria";
import { WithLocale } from "@/core/i18n/with-locale";
import type { DataType } from "@/core/kernel/messages";
import type { CalculateTopKRows } from "@/plugins/impl/DataTablePlugin";
import { cn } from "@/utils/cn";
import { type DateFormat, exactDateTime, getDateFormat } from "@/utils/dates";
+import { Events } from "@/utils/events";
import { Logger } from "@/utils/Logger";
import { Maps } from "@/utils/maps";
import { maxFractionalDigits } from "@/utils/numbers";
@@ -382,9 +384,10 @@ const PopoutColumn = ({
rawStringValue,
edges,
contentClassName,
- buttonText,
+ scrollable = false,
wrapped,
children,
+ buttonText,
}: {
cellStyles?: string;
selectCell?: () => void;
@@ -393,10 +396,12 @@ const PopoutColumn = ({
// still use `rawStringValue`. Middle is sliced from `rawStringValue`.
edges?: { leading: string; trailing: string };
contentClassName?: string;
- buttonText?: string;
+ scrollable?: boolean;
wrapped?: boolean;
+ buttonText?: string;
children: React.ReactNode;
}) => {
+ const triggerRef = useRef<HTMLButtonElement>(null);
const hasEdgeWhitespace =
edges !== undefined &&
(edges.leading.length > 0 || edges.trailing.length > 0);
@@ -412,6 +417,7 @@ const PopoutColumn = ({
<EmotionCacheProvider container={null}>
<Popover>
<PopoverTrigger
+ ref={triggerRef}
className={cn(cellStyles, "max-w-fit outline-hidden")}
onClick={selectCell}
onMouseDown={(e) => {
@@ -432,23 +438,49 @@ const PopoutColumn = ({
</span>
</PopoverTrigger>
<PopoverContent
- className={contentClassName}
+ className={cn(
+ contentClassName,
+ scrollable && "flex flex-col overflow-hidden",
+ )}
align="start"
alignOffset={10}
+ onInteractOutside={(event) => {
+ // Radix sees the shadow host as the target. Resolve the original
+ // target so pointer-down does not dismiss before click toggles.
+ const target = Events.composedTarget(event.detail.originalEvent);
+ if (triggerRef.current?.contains(target)) {
+ event.preventDefault();
+ }
+ }}
>
- <div className="absolute top-2 right-2">
+ <div
+ className={cn(
+ "flex -mt-3 -mr-2",
+ scrollable ? "shrink-0 justify-end" : "float-right",
+ )}
+ >
<CopyClipboardIcon
value={rawStringValue}
- className="w-2.5 h-2.5"
+ className="size-3 hover:text-link"
+ buttonClassName="flex size-5 items-center justify-center"
tooltip={false}
/>
- <PopoverClose>
- <Button variant="link" size="xs">
+ <PopoverClose asChild={true}>
+ <Button
+ variant="link"
+ size="xs"
+ className={cn("size-5 p-0", !buttonText && "ml-1.5 mr-1")}
+ aria-label="Close"
+ >
{buttonText ?? "Close"}
</Button>
</PopoverClose>
</div>
- {children}
+ {scrollable ? (
+ <div className="min-h-0 overflow-auto">{children}</div>
+ ) : (
+ children
+ )}
</PopoverContent>
</Popover>
</EmotionCacheProvider>
@@ -662,9 +694,10 @@ export function renderCellValue<TData, TValue>({
selectCell={selectCell}
rawStringValue={stringValue}
edges={{ leading, trailing }}
- contentClassName="max-h-64 overflow-auto whitespace-pre-wrap wrap-break-word text-sm w-96"
- buttonText="X"
+ contentClassName="max-h-64 whitespace-pre-wrap wrap-break-word text-sm w-96"
+ scrollable={true}
wrapped={isWrapped}
+ buttonText="X"
>
<MarkdownUrlDetector
content={stringValue}